netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Yuval Mintz <Yuval.Mintz@qlogic.com>
To: Michal Schmidt <mschmidt@redhat.com>
Cc: David Miller <davem@davemloft.net>,
	netdev <netdev@vger.kernel.org>,
	Dmitry Kravkov <Dmitry.Kravkov@qlogic.com>,
	Ariel Elior <Ariel.Elior@qlogic.com>
Subject: RE: [PATCH net] bnx2x: really disable TPA if 'disable_tpa' option is set
Date: Tue, 28 Apr 2015 09:11:41 +0000	[thread overview]
Message-ID: <B5657A6538887040AD3A81F1008BEC63D23FAC@AVMB1.qlogic.org> (raw)
In-Reply-To: <553F4D3F.7000301@redhat.com>

> > I agree that this fixes an incorrect logic, but its incomplete as the
> > bnx2x 'bp->flags' no longer represent the correct logic. I.e., it
> > might cause additional issues down the road, as the 'fp->mode' and 'fp-
> >disable_tpa'
> > are no longer in sync.
> 
> > We already have a fix for this issue, we just haven't sent it to 'net'
> > yet. Are you willing to give us an additional day to send an
> > alternative fix?  Or do you prefer to take this, and possibly later
> > we'll remove the logic added by this patch in our own?
> 
> Yuval,
> 
> I also have a patch that removes fp->disable_tpa by merging it into
> fp->mode (adding a 3rd mode: TPA_MODE_DISABLED). And another patch that
> removes {TPA,GRO}_ENABLE_FLAG by using dev->features everywhere.
> I'll wait and see what changes you have.
> 
> Regards,
> Michal

Ours is merely a point fix that differentiate GRO_ENABLE_FLAG from
NETIF_F_GRO.
If you have a ready patch that removes the flags altogether I think
we can skip ours and review that one instead.

Thanks,
Yuval

      reply	other threads:[~2015-04-28  9:11 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-27 15:20 [PATCH net] bnx2x: really disable TPA if 'disable_tpa' option is set Michal Schmidt
2015-04-27 17:43 ` David Miller
2015-04-27 18:15   ` Yuval Mintz
2015-04-28  3:14     ` David Miller
2015-04-28  9:05     ` Michal Schmidt
2015-04-28  9:11       ` Yuval Mintz [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=B5657A6538887040AD3A81F1008BEC63D23FAC@AVMB1.qlogic.org \
    --to=yuval.mintz@qlogic.com \
    --cc=Ariel.Elior@qlogic.com \
    --cc=Dmitry.Kravkov@qlogic.com \
    --cc=davem@davemloft.net \
    --cc=mschmidt@redhat.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).