* [PATCH for 4.1] rtlwifi: rtl8192cu: Fix kernel deadlock
@ 2015-04-24 16:03 Larry Finger
2015-04-28 10:55 ` [for,4.1] " Kalle Valo
0 siblings, 1 reply; 2+ messages in thread
From: Larry Finger @ 2015-04-24 16:03 UTC (permalink / raw)
To: kvalo
Cc: linux-wireless, Larry Finger, netdev, Stable, Bernhard Wiedemann,
Takashi Iwai
The USB mini-driver in rtlwifi, which is used by rtl8192cu, issues a call to
usb_control_msg() with a timeout value of 0. In some instances where the
interface is shutting down, this infinite wait results in a CPU deadlock. A
one second timeout fixes this problem without affecting any normal operations.
This bug is reported at https://bugzilla.novell.com/show_bug.cgi?id=927786.
Reported-by: Bernhard Wiedemann <bwiedemann@suse.com>
Tested-by: Bernhard Wiedemann <bwiedemann@suse.com>
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
Cc: Stable <stable@vger.kernel.org>
Cc: Bernhard Wiedemann <bwiedemann@suse.com>
Cc: Takashi Iwai<tiwai@suse.com>
---
Kalle,
I marked this patch for V4.1, and I hope that timing can be met.
Thanks,
Larry
---
drivers/net/wireless/rtlwifi/usb.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/wireless/rtlwifi/usb.c b/drivers/net/wireless/rtlwifi/usb.c
index 46ee956..27cd6ca 100644
--- a/drivers/net/wireless/rtlwifi/usb.c
+++ b/drivers/net/wireless/rtlwifi/usb.c
@@ -126,7 +126,7 @@ static int _usbctrl_vendorreq_sync_read(struct usb_device *udev, u8 request,
do {
status = usb_control_msg(udev, pipe, request, reqtype, value,
- index, pdata, len, 0); /*max. timeout*/
+ index, pdata, len, 1000);
if (status < 0) {
/* firmware download is checksumed, don't retry */
if ((value >= FW_8192C_START_ADDRESS &&
--
2.1.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [for,4.1] rtlwifi: rtl8192cu: Fix kernel deadlock
2015-04-24 16:03 [PATCH for 4.1] rtlwifi: rtl8192cu: Fix kernel deadlock Larry Finger
@ 2015-04-28 10:55 ` Kalle Valo
0 siblings, 0 replies; 2+ messages in thread
From: Kalle Valo @ 2015-04-28 10:55 UTC (permalink / raw)
To: Larry Finger
Cc: linux-wireless, Larry Finger, netdev, Stable, Bernhard Wiedemann,
Takashi Iwai
> The USB mini-driver in rtlwifi, which is used by rtl8192cu, issues a call to
> usb_control_msg() with a timeout value of 0. In some instances where the
> interface is shutting down, this infinite wait results in a CPU deadlock. A
> one second timeout fixes this problem without affecting any normal operations.
>
> This bug is reported at https://bugzilla.novell.com/show_bug.cgi?id=927786.
>
> Reported-by: Bernhard Wiedemann <bwiedemann@suse.com>
> Tested-by: Bernhard Wiedemann <bwiedemann@suse.com>
> Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
> Cc: Stable <stable@vger.kernel.org>
> Cc: Bernhard Wiedemann <bwiedemann@suse.com>
> Cc: Takashi Iwai<tiwai@suse.com>
Thanks, applied to wireless-drivers.git.
Kalle Valo
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-04-28 10:56 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-04-24 16:03 [PATCH for 4.1] rtlwifi: rtl8192cu: Fix kernel deadlock Larry Finger
2015-04-28 10:55 ` [for,4.1] " Kalle Valo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).