[PATCH net-next v3] be2net: log link status

[PATCH net-next v3] be2net: log link status

[Ivan Vecera]

The driver unlike other drivers does not log link state changes. It's 
better for an user when asynchronous link states are logged in the 
system log.

v3: Changes from v2 discarded as "not necessary"

Cc: Sathya Perla <sathya.perla@emulex.com>
Cc: Subbu Seetharaman <subbu.seetharaman@emulex.com>
Cc: Ajit Khaparde <ajit.khaparde@emulex.com>
Signed-off-by: Ivan Vecera <ivecera@redhat.com>
---
  drivers/net/ethernet/emulex/benet/be_main.c | 2 ++
  1 file changed, 2 insertions(+)

diff --git a/drivers/net/ethernet/emulex/benet/be_main.c 
b/drivers/net/ethernet/emulex/benet/be_main.c
index fb0bc3c..e349131 100644
--- a/drivers/net/ethernet/emulex/benet/be_main.c
+++ b/drivers/net/ethernet/emulex/benet/be_main.c
@@ -662,6 +662,8 @@ void be_link_status_update(struct be_adapter 
*adapter, u8 link_status)
  		netif_carrier_on(netdev);
  	else
  		netif_carrier_off(netdev);
+
+	netdev_info(netdev, "Link is %s\n", link_status ? "Up" : "Down");
  }
   static void be_tx_stats_update(struct be_tx_obj *txo, struct sk_buff 
*skb)
-- 
2.0.5

RE: [PATCH net-next v3] be2net: log link status

[Sathya Perla]

> -----Original Message-----
> From: Ivan Vecera [mailto:ivecera@redhat.com]
> 
> The driver unlike other drivers does not log link state changes. It's
> better for an user when asynchronous link states are logged in the
> system log.
> 
> v3: Changes from v2 discarded as "not necessary"
> 
> Cc: Sathya Perla <sathya.perla@emulex.com>
> Cc: Subbu Seetharaman <subbu.seetharaman@emulex.com>
> Cc: Ajit Khaparde <ajit.khaparde@emulex.com>
> Signed-off-by: Ivan Vecera <ivecera@redhat.com>

Acked-by: Sathya Perla <sathya.perla@emulex.com>

Re: [PATCH net-next v3] be2net: log link status

[David Miller]

From: Ivan Vecera <ivecera@redhat.com>
Date: Tue, 28 Apr 2015 21:39:32 +0200

> The driver unlike other drivers does not log link state changes. It's
> better for an user when asynchronous link states are logged in the
> system log.
> 
> v3: Changes from v2 discarded as "not necessary"
> 
> Cc: Sathya Perla <sathya.perla@emulex.com>
> Cc: Subbu Seetharaman <subbu.seetharaman@emulex.com>
> Cc: Ajit Khaparde <ajit.khaparde@emulex.com>
> Signed-off-by: Ivan Vecera <ivecera@redhat.com>
> ---
>  drivers/net/ethernet/emulex/benet/be_main.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/net/ethernet/emulex/benet/be_main.c
> b/drivers/net/ethernet/emulex/benet/be_main.c
> index fb0bc3c..e349131 100644
> --- a/drivers/net/ethernet/emulex/benet/be_main.c
> +++ b/drivers/net/ethernet/emulex/benet/be_main.c
> @@ -662,6 +662,8 @@ void be_link_status_update(struct be_adapter
> *adapter, u8 link_status)

Patch has been corrupted by your email client.

Please fix this up and resubmit.

[PATCH net-next v3] be2net: log link status

[Ivan Vecera]

The driver unlike other drivers does not log link state changes. It's
better for an user when asynchronous link states are logged to the system
log.

v3: Changes from v2 discarded as "not necessary"

Cc: Sathya Perla <sathya.perla@emulex.com>
Cc: Subbu Seetharaman <subbu.seetharaman@emulex.com>
Cc: Ajit Khaparde <ajit.khaparde@emulex.com>
Signed-off-by: Ivan Vecera <ivecera@redhat.com>
---
 drivers/net/ethernet/emulex/benet/be_main.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/net/ethernet/emulex/benet/be_main.c b/drivers/net/ethernet/emulex/benet/be_main.c
index fb0bc3c..e349131 100644
--- a/drivers/net/ethernet/emulex/benet/be_main.c
+++ b/drivers/net/ethernet/emulex/benet/be_main.c
@@ -662,6 +662,8 @@ void be_link_status_update(struct be_adapter *adapter, u8 link_status)
 		netif_carrier_on(netdev);
 	else
 		netif_carrier_off(netdev);
+
+	netdev_info(netdev, "Link is %s\n", link_status ? "Up" : "Down");
 }
 
 static void be_tx_stats_update(struct be_tx_obj *txo, struct sk_buff *skb)
-- 
2.0.5

Re: [PATCH net-next v3] be2net: log link status

[David Miller]

From: Ivan Vecera <ivecera@redhat.com>
Date: Thu, 30 Apr 2015 11:59:49 +0200

> The driver unlike other drivers does not log link state changes. It's
> better for an user when asynchronous link states are logged to the system
> log.
> 
> v3: Changes from v2 discarded as "not necessary"
> 
> Cc: Sathya Perla <sathya.perla@emulex.com>
> Cc: Subbu Seetharaman <subbu.seetharaman@emulex.com>
> Cc: Ajit Khaparde <ajit.khaparde@emulex.com>
> Signed-off-by: Ivan Vecera <ivecera@redhat.com>

Applied.