From: David Miller <davem@davemloft.net>
To: willemb@google.com
Cc: netdev@vger.kernel.org, eric.dumazet@gmail.com, david.laight@aculab.com
Subject: Re: [PATCH net-next v2 6/6] packet: rollover statistics
Date: Mon, 11 May 2015 13:09:50 -0400 (EDT) [thread overview]
Message-ID: <20150511.130950.1321194163068727654.davem@davemloft.net> (raw)
In-Reply-To: <1431206701-5019-7-git-send-email-willemb@google.com>
From: Willem de Bruijn <willemb@google.com>
Date: Sat, 9 May 2015 17:25:01 -0400
> From: Willem de Bruijn <willemb@google.com>
>
> Rollover indicates exceptional conditions. Export a counter to inform
> socket owners of this state.
>
> If no socket with sufficient room is found, rollover fails. Also count
> these events.
>
> Finally, also count when flows are rolled over early thanks to huge
> flow detection, to validate its correctness.
>
> Tested:
> Read counters in bench_rollover on all other tests in the patchset
>
> Signed-off-by: Willem de Bruijn <willemb@google.com>
> ---
> include/uapi/linux/if_packet.h | 7 +++++++
> net/packet/af_packet.c | 19 ++++++++++++++++++-
> net/packet/internal.h | 3 +++
> 3 files changed, 28 insertions(+), 1 deletion(-)
>
> diff --git a/include/uapi/linux/if_packet.h b/include/uapi/linux/if_packet.h
> index 053bd10..52b6501 100644
> --- a/include/uapi/linux/if_packet.h
> +++ b/include/uapi/linux/if_packet.h
> @@ -54,6 +54,7 @@ struct sockaddr_ll {
> #define PACKET_FANOUT 18
> #define PACKET_TX_HAS_OFF 19
> #define PACKET_QDISC_BYPASS 20
> +#define PACKET_ROLLOVER_STATS 21
>
> #define PACKET_FANOUT_HASH 0
> #define PACKET_FANOUT_LB 1
> @@ -75,6 +76,12 @@ struct tpacket_stats_v3 {
> unsigned int tp_freeze_q_cnt;
> };
>
> +struct tpacket_rollover_stats {
> + unsigned long tp_all;
> + unsigned long tp_huge;
> + unsigned long tp_failed;
> +};
Please do not use variably sized types, especially "long" for user exported
interfaces. Otherwise you will need to add a compat layer to translate
the data into userspace for 32-bit tasks running on a 64-bit kernel.
If a 32-bit value really is not sufficient, use __aligned_u64.
next prev parent reply other threads:[~2015-05-11 17:09 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-09 21:24 [PATCH net-next v2 0/6] packet: refine rollover Willem de Bruijn
2015-05-09 21:24 ` [PATCH net-next v2 1/6] packet: rollover prepare: move code out of callsites Willem de Bruijn
2015-05-09 21:24 ` [PATCH net-next v2 2/6] packet: rollover prepare: per-socket state Willem de Bruijn
2015-05-09 21:24 ` [PATCH net-next v2 3/6] packet: rollover only to socket with headroom Willem de Bruijn
2015-05-09 21:24 ` [PATCH net-next v2 4/6] packet: rollover lock contention avoidance Willem de Bruijn
2015-05-09 21:25 ` [PATCH net-next v2 5/6] packet: rollover huge flows before small flows Willem de Bruijn
2015-05-09 21:25 ` [PATCH net-next v2 6/6] packet: rollover statistics Willem de Bruijn
2015-05-11 17:09 ` David Miller [this message]
2015-05-12 15:04 ` Willem de Bruijn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150511.130950.1321194163068727654.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=david.laight@aculab.com \
--cc=eric.dumazet@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=willemb@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).