From: Willem de Bruijn <willemb@google.com>
To: David Miller <davem@davemloft.net>
Cc: Network Development <netdev@vger.kernel.org>,
Eric Dumazet <eric.dumazet@gmail.com>,
David Laight <david.laight@aculab.com>
Subject: Re: [PATCH net-next v2 6/6] packet: rollover statistics
Date: Tue, 12 May 2015 11:04:19 -0400 [thread overview]
Message-ID: <CA+FuTSc5AJA7_p_mAT9DXqsBDd-D=HSZ=yJnofFnQLisFNom9Q@mail.gmail.com> (raw)
In-Reply-To: <20150511.130950.1321194163068727654.davem@davemloft.net>
>>
>> +struct tpacket_rollover_stats {
>> + unsigned long tp_all;
>> + unsigned long tp_huge;
>> + unsigned long tp_failed;
>> +};
>
> Please do not use variably sized types, especially "long" for user exported
> interfaces. Otherwise you will need to add a compat layer to translate
> the data into userspace for 32-bit tasks running on a 64-bit kernel.
>
> If a 32-bit value really is not sufficient, use __aligned_u64.
Thanks for catching that. I converted them to __aligned_u64. The
internal counters remain atomic_long_t.
I'll push v3 of the patchset with only this change.
prev parent reply other threads:[~2015-05-12 15:04 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-09 21:24 [PATCH net-next v2 0/6] packet: refine rollover Willem de Bruijn
2015-05-09 21:24 ` [PATCH net-next v2 1/6] packet: rollover prepare: move code out of callsites Willem de Bruijn
2015-05-09 21:24 ` [PATCH net-next v2 2/6] packet: rollover prepare: per-socket state Willem de Bruijn
2015-05-09 21:24 ` [PATCH net-next v2 3/6] packet: rollover only to socket with headroom Willem de Bruijn
2015-05-09 21:24 ` [PATCH net-next v2 4/6] packet: rollover lock contention avoidance Willem de Bruijn
2015-05-09 21:25 ` [PATCH net-next v2 5/6] packet: rollover huge flows before small flows Willem de Bruijn
2015-05-09 21:25 ` [PATCH net-next v2 6/6] packet: rollover statistics Willem de Bruijn
2015-05-11 17:09 ` David Miller
2015-05-12 15:04 ` Willem de Bruijn [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CA+FuTSc5AJA7_p_mAT9DXqsBDd-D=HSZ=yJnofFnQLisFNom9Q@mail.gmail.com' \
--to=willemb@google.com \
--cc=davem@davemloft.net \
--cc=david.laight@aculab.com \
--cc=eric.dumazet@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).