From: David Miller <davem@davemloft.net>
To: amirv@mellanox.com
Cc: netdev@vger.kernel.org, ogerlitz@mellanox.com,
talal@mellanox.com, achiad@mellanox.com, saeedm@mellanox.com
Subject: Re: [PATCH net-next V3 02/11] net/mlx5_core: Add EQ renaming mechanism
Date: Mon, 11 May 2015 13:40:08 -0400 (EDT) [thread overview]
Message-ID: <20150511.134008.7539040783838247.davem@davemloft.net> (raw)
In-Reply-To: <1431250746-11941-3-git-send-email-amirv@mellanox.com>
From: Amir Vadai <amirv@mellanox.com>
Date: Sun, 10 May 2015 12:38:57 +0300
> +int mlx5_rename_eq(struct mlx5_core_dev *dev, int eq_ix, char *name)
> +{
> + struct mlx5_priv *priv = &dev->priv;
> + struct mlx5_eq_table *table = &priv->eq_table;
> + struct mlx5_eq *eq;
> + int err = -ENOENT;
> +
> + spin_lock(&table->lock);
> + list_for_each_entry(eq, &table->comp_eqs_list, list) {
> + if (eq->index == eq_ix) {
> + snprintf(priv->irq_info[eq_ix].name, MLX5_MAX_IRQ_NAME,
> + "%s-%d", name, eq_ix);
> + err = 0;
> + break;
> + }
> + }
> + spin_unlock(&table->lock);
> +
> + return err;
> +}
You have to be very careful with this.
If you change these names after the request_irq() call(s), the new name string
will not propagate to /proc/interrupts output etc.
Looking at your later patches, this seems to be invoked very late in
mlx5e_open_locked(), so I am concerned.
next prev parent reply other threads:[~2015-05-11 17:40 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-10 9:38 [PATCH net-next V3 00/11] net/mlx5: ConnectX-4 100G Ethernet driver Amir Vadai
2015-05-10 9:38 ` [PATCH net-next V3 01/11] net/mlx5_core: Set irq affinity hints Amir Vadai
2015-05-10 9:38 ` [PATCH net-next V3 02/11] net/mlx5_core: Add EQ renaming mechanism Amir Vadai
2015-05-11 17:40 ` David Miller [this message]
2015-05-12 11:55 ` Amir Vadai
2015-05-14 15:19 ` Or Gerlitz
2015-05-10 9:38 ` [PATCH net-next V3 03/11] net/mlx5_core: HW data structs/types definitions cleanup Amir Vadai
2015-05-10 9:38 ` [PATCH net-next V3 04/11] net/mlx5_core: New device capabilities handling Amir Vadai
2015-05-10 9:39 ` [PATCH net-next V3 05/11] net/mlx5_core: Implement access functions of ptys register fields Amir Vadai
2015-05-10 9:39 ` [PATCH net-next V3 06/11] net/mlx5_core: Implement get/set port status Amir Vadai
2015-05-10 9:39 ` [PATCH net-next V3 07/11] net/mlx5_core: Modify CQ moderation parameters Amir Vadai
2015-05-10 9:39 ` [PATCH net-next V3 08/11] net/mlx5_core: Set/Query port MTU commands Amir Vadai
2015-05-10 16:32 ` Sergei Shtylyov
2015-05-12 8:19 ` Amir Vadai
2015-05-10 9:39 ` [PATCH net-next V3 09/11] net/mlx5: Ethernet Datapath files Amir Vadai
2015-05-10 9:39 ` [PATCH net-next V3 10/11] net/mlx5: Ethernet resource handling files Amir Vadai
2015-05-10 9:39 ` [PATCH net-next V3 11/11] net/mlx5: Extend mlx5_core to support ConnectX-4 Ethernet functionality Amir Vadai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150511.134008.7539040783838247.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=achiad@mellanox.com \
--cc=amirv@mellanox.com \
--cc=netdev@vger.kernel.org \
--cc=ogerlitz@mellanox.com \
--cc=saeedm@mellanox.com \
--cc=talal@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).