From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: Amir Vadai <amirv@mellanox.com>, "David S. Miller" <davem@davemloft.net>
Cc: netdev@vger.kernel.org, Or Gerlitz <ogerlitz@mellanox.com>,
Tal Alon <talal@mellanox.com>,
Achiad Shochat <achiad@mellanox.com>,
Saeed Mahameed <saeedm@mellanox.com>
Subject: Re: [PATCH net-next V3 08/11] net/mlx5_core: Set/Query port MTU commands
Date: Sun, 10 May 2015 19:32:11 +0300 [thread overview]
Message-ID: <554F880B.8060203@cogentembedded.com> (raw)
In-Reply-To: <1431250746-11941-9-git-send-email-amirv@mellanox.com>
Hello.
On 5/10/2015 12:39 PM, Amir Vadai wrote:
> From: Saeed Mahameed <saeedm@mellanox.com>
> Introduce set/Query low level functions to access MTU in hardware. To be
> used by the netdev.
> Signed-off-by: Saeed Mahameed <saeedm@mellanox.com>
> Signed-off-by: Amir Vadai <amirv@mellanox.com>
> ---
> drivers/net/ethernet/mellanox/mlx5/core/port.c | 56 ++++++++++++++++++++++++++
> include/linux/mlx5/driver.h | 4 ++
> 2 files changed, 60 insertions(+)
> diff --git a/drivers/net/ethernet/mellanox/mlx5/core/port.c b/drivers/net/ethernet/mellanox/mlx5/core/port.c
> index 742a6fb..e56a0b6 100644
> --- a/drivers/net/ethernet/mellanox/mlx5/core/port.c
> +++ b/drivers/net/ethernet/mellanox/mlx5/core/port.c
> @@ -211,3 +211,59 @@ int mlx5_query_port_status(struct mlx5_core_dev *dev, u8 *status)
[...]
> +int mlx5_set_port_mtu(struct mlx5_core_dev *dev, int mtu)
> +{
> + u32 in[MLX5_ST_SZ_DW(pmtu_reg)];
> + u32 out[MLX5_ST_SZ_DW(pmtu_reg)];
> + int err;
> +
> + memset(in, 0, sizeof(in));
> +
> + MLX5_SET(pmtu_reg, in, admin_mtu, mtu);
> + MLX5_SET(pmtu_reg, in, local_port, 1);
> +
> + err = mlx5_core_access_reg(dev, in, sizeof(in), out,
> + sizeof(out), MLX5_REG_PMTU, 0, 1);
> +
> + return err;
Why not just return directly?
[...]
WBR, Sergei
next prev parent reply other threads:[~2015-05-10 16:32 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-10 9:38 [PATCH net-next V3 00/11] net/mlx5: ConnectX-4 100G Ethernet driver Amir Vadai
2015-05-10 9:38 ` [PATCH net-next V3 01/11] net/mlx5_core: Set irq affinity hints Amir Vadai
2015-05-10 9:38 ` [PATCH net-next V3 02/11] net/mlx5_core: Add EQ renaming mechanism Amir Vadai
2015-05-11 17:40 ` David Miller
2015-05-12 11:55 ` Amir Vadai
2015-05-14 15:19 ` Or Gerlitz
2015-05-10 9:38 ` [PATCH net-next V3 03/11] net/mlx5_core: HW data structs/types definitions cleanup Amir Vadai
2015-05-10 9:38 ` [PATCH net-next V3 04/11] net/mlx5_core: New device capabilities handling Amir Vadai
2015-05-10 9:39 ` [PATCH net-next V3 05/11] net/mlx5_core: Implement access functions of ptys register fields Amir Vadai
2015-05-10 9:39 ` [PATCH net-next V3 06/11] net/mlx5_core: Implement get/set port status Amir Vadai
2015-05-10 9:39 ` [PATCH net-next V3 07/11] net/mlx5_core: Modify CQ moderation parameters Amir Vadai
2015-05-10 9:39 ` [PATCH net-next V3 08/11] net/mlx5_core: Set/Query port MTU commands Amir Vadai
2015-05-10 16:32 ` Sergei Shtylyov [this message]
2015-05-12 8:19 ` Amir Vadai
2015-05-10 9:39 ` [PATCH net-next V3 09/11] net/mlx5: Ethernet Datapath files Amir Vadai
2015-05-10 9:39 ` [PATCH net-next V3 10/11] net/mlx5: Ethernet resource handling files Amir Vadai
2015-05-10 9:39 ` [PATCH net-next V3 11/11] net/mlx5: Extend mlx5_core to support ConnectX-4 Ethernet functionality Amir Vadai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=554F880B.8060203@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=achiad@mellanox.com \
--cc=amirv@mellanox.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=ogerlitz@mellanox.com \
--cc=saeedm@mellanox.com \
--cc=talal@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).