* [PATCH] isdn/hisax: Convert use of __constant_cpu_to_le16 to cpu_to_le16
@ 2015-06-06 1:14 Vaishali Thakkar
2015-06-08 2:42 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Vaishali Thakkar @ 2015-06-06 1:14 UTC (permalink / raw)
To: Karsten Keil; +Cc: netdev, linux-kernel, Julia Lawall
In big endian cases, macro cpu_to_le16 unfolds to __swab16 which
provides special case for constants. In little endian cases,
__constant_cpu_to_le16 and cpu_to_le16 expand directly to the
same expression. So, replace __constant_cpu_to_le16 with
cpu_to_le16 with the goal of getting rid of the definition of
__constant_cpu_to_le16 completely.
The semantic patch that performs this transformation is as follows:
@@expression x;@@
- __constant_cpu_to_le16(x)
+ cpu_to_le16(x)
Signed-off-by: Vaishali Thakkar <vthakkar1994@gmail.com>
---
drivers/isdn/hisax/st5481_usb.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/isdn/hisax/st5481_usb.c b/drivers/isdn/hisax/st5481_usb.c
index ead0a4f..a0fdbc0 100644
--- a/drivers/isdn/hisax/st5481_usb.c
+++ b/drivers/isdn/hisax/st5481_usb.c
@@ -267,8 +267,8 @@ int st5481_setup_usb(struct st5481_adapter *adapter)
}
// The descriptor is wrong for some early samples of the ST5481 chip
- altsetting->endpoint[3].desc.wMaxPacketSize = __constant_cpu_to_le16(32);
- altsetting->endpoint[4].desc.wMaxPacketSize = __constant_cpu_to_le16(32);
+ altsetting->endpoint[3].desc.wMaxPacketSize = cpu_to_le16(32);
+ altsetting->endpoint[4].desc.wMaxPacketSize = cpu_to_le16(32);
// Use alternative setting 3 on interface 0 to have 2B+D
if ((status = usb_set_interface(dev, 0, 3)) < 0) {
--
1.9.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] isdn/hisax: Convert use of __constant_cpu_to_le16 to cpu_to_le16
2015-06-06 1:14 [PATCH] isdn/hisax: Convert use of __constant_cpu_to_le16 to cpu_to_le16 Vaishali Thakkar
@ 2015-06-08 2:42 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2015-06-08 2:42 UTC (permalink / raw)
To: vthakkar1994; +Cc: isdn, netdev, linux-kernel, julia.lawall
From: Vaishali Thakkar <vthakkar1994@gmail.com>
Date: Sat, 6 Jun 2015 06:44:00 +0530
> In big endian cases, macro cpu_to_le16 unfolds to __swab16 which
> provides special case for constants. In little endian cases,
> __constant_cpu_to_le16 and cpu_to_le16 expand directly to the
> same expression. So, replace __constant_cpu_to_le16 with
> cpu_to_le16 with the goal of getting rid of the definition of
> __constant_cpu_to_le16 completely.
>
> The semantic patch that performs this transformation is as follows:
>
> @@expression x;@@
>
> - __constant_cpu_to_le16(x)
> + cpu_to_le16(x)
>
> Signed-off-by: Vaishali Thakkar <vthakkar1994@gmail.com>
Applied, thanks.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-06-08 2:42 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-06-06 1:14 [PATCH] isdn/hisax: Convert use of __constant_cpu_to_le16 to cpu_to_le16 Vaishali Thakkar
2015-06-08 2:42 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).