* [patch net] niu: don't count tx error twice in case of headroom realloc fails
@ 2015-07-23 10:20 Jiri Pirko
2015-07-27 4:18 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Jiri Pirko @ 2015-07-23 10:20 UTC (permalink / raw)
To: netdev; +Cc: davem
Fixes: a3138df9 ("[NIU]: Add Sun Neptune ethernet driver.")
Signed-off-by: Jiri Pirko <jiri@resnulli.us>
---
drivers/net/ethernet/sun/niu.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/net/ethernet/sun/niu.c b/drivers/net/ethernet/sun/niu.c
index 0c5842a..ab6051a 100644
--- a/drivers/net/ethernet/sun/niu.c
+++ b/drivers/net/ethernet/sun/niu.c
@@ -6658,10 +6658,8 @@ static netdev_tx_t niu_start_xmit(struct sk_buff *skb,
struct sk_buff *skb_new;
skb_new = skb_realloc_headroom(skb, len);
- if (!skb_new) {
- rp->tx_errors++;
+ if (!skb_new)
goto out_drop;
- }
kfree_skb(skb);
skb = skb_new;
} else
--
1.9.3
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [patch net] niu: don't count tx error twice in case of headroom realloc fails
2015-07-23 10:20 [patch net] niu: don't count tx error twice in case of headroom realloc fails Jiri Pirko
@ 2015-07-27 4:18 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2015-07-27 4:18 UTC (permalink / raw)
To: jiri; +Cc: netdev
From: Jiri Pirko <jiri@resnulli.us>
Date: Thu, 23 Jul 2015 12:20:37 +0200
> Fixes: a3138df9 ("[NIU]: Add Sun Neptune ethernet driver.")
> Signed-off-by: Jiri Pirko <jiri@resnulli.us>
Applied, thank you.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-07-27 4:18 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-07-23 10:20 [patch net] niu: don't count tx error twice in case of headroom realloc fails Jiri Pirko
2015-07-27 4:18 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).