netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] bgmac: Update fixed_phy_register()
@ 2015-09-02 16:25 Fabio Estevam
  2015-09-02 18:40 ` David Miller
  0 siblings, 1 reply; 2+ messages in thread
From: Fabio Estevam @ 2015-09-02 16:25 UTC (permalink / raw)
  To: davem; +Cc: nbd, andrew, broonie, netdev, Fabio Estevam

From: Fabio Estevam <fabio.estevam@freescale.com>

Commit a5597008dbc2 ("phy: fixed_phy: Add gpio to determine link up/down.")
added a new argument to fixed_phy_register(), but missed to update bgmac
driver, causing the following build failure:

drivers/net/ethernet/broadcom/bgmac.c:1450:2: error: too few arguments to function 'fixed_phy_register'

Add the missing argument.

Reported-by: Mark Brown <broonie@kernel.org>
Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
---
 drivers/net/ethernet/broadcom/bgmac.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/broadcom/bgmac.c b/drivers/net/ethernet/broadcom/bgmac.c
index d043746..28f7610 100644
--- a/drivers/net/ethernet/broadcom/bgmac.c
+++ b/drivers/net/ethernet/broadcom/bgmac.c
@@ -1447,7 +1447,7 @@ static int bgmac_fixed_phy_register(struct bgmac *bgmac)
 	struct phy_device *phy_dev;
 	int err;
 
-	phy_dev = fixed_phy_register(PHY_POLL, &fphy_status, NULL);
+	phy_dev = fixed_phy_register(PHY_POLL, &fphy_status, -1, NULL);
 	if (!phy_dev || IS_ERR(phy_dev)) {
 		bgmac_err(bgmac, "Failed to register fixed PHY device\n");
 		return -ENODEV;
-- 
1.9.1

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] bgmac: Update fixed_phy_register()
  2015-09-02 16:25 [PATCH] bgmac: Update fixed_phy_register() Fabio Estevam
@ 2015-09-02 18:40 ` David Miller
  0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2015-09-02 18:40 UTC (permalink / raw)
  To: festevam; +Cc: nbd, andrew, broonie, netdev, fabio.estevam

From: Fabio Estevam <festevam@gmail.com>
Date: Wed,  2 Sep 2015 13:25:59 -0300

> From: Fabio Estevam <fabio.estevam@freescale.com>
> 
> Commit a5597008dbc2 ("phy: fixed_phy: Add gpio to determine link up/down.")
> added a new argument to fixed_phy_register(), but missed to update bgmac
> driver, causing the following build failure:
> 
> drivers/net/ethernet/broadcom/bgmac.c:1450:2: error: too few arguments to function 'fixed_phy_register'
> 
> Add the missing argument.
> 
> Reported-by: Mark Brown <broonie@kernel.org>
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>

Applied, thanks.

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2015-09-02 18:40 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-09-02 16:25 [PATCH] bgmac: Update fixed_phy_register() Fabio Estevam
2015-09-02 18:40 ` David Miller

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).