* [PATCH] fixed_phy: pass 'irq' to fixed_phy_add()
@ 2015-09-03 20:22 Sergei Shtylyov
2015-09-03 20:23 ` Florian Fainelli
2015-09-07 6:49 ` David Miller
0 siblings, 2 replies; 3+ messages in thread
From: Sergei Shtylyov @ 2015-09-03 20:22 UTC (permalink / raw)
To: netdev, f.fainelli; +Cc: linux-kernel
I've noticed that fixed_phy_register() ignores its 'irq' parameter instead of
passing it to fixed_phy_add(). Luckily, fixed_phy_register() seems to always
be called with PHY_POLL for 'irq'... :-)
Fixes: a75951217472 ("net: phy: extend fixed driver with fixed_phy_register()")
Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
---
The patch is against DaveM's 'net.git' repo.
drivers/net/phy/fixed_phy.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Index: net/drivers/net/phy/fixed_phy.c
===================================================================
--- net.orig/drivers/net/phy/fixed_phy.c
+++ net/drivers/net/phy/fixed_phy.c
@@ -325,7 +325,7 @@ struct phy_device *fixed_phy_register(un
phy_addr = phy_fixed_addr++;
spin_unlock(&phy_fixed_addr_lock);
- ret = fixed_phy_add(PHY_POLL, phy_addr, status, link_gpio);
+ ret = fixed_phy_add(irq, phy_addr, status, link_gpio);
if (ret < 0)
return ERR_PTR(ret);
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] fixed_phy: pass 'irq' to fixed_phy_add()
2015-09-03 20:22 [PATCH] fixed_phy: pass 'irq' to fixed_phy_add() Sergei Shtylyov
@ 2015-09-03 20:23 ` Florian Fainelli
2015-09-07 6:49 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: Florian Fainelli @ 2015-09-03 20:23 UTC (permalink / raw)
To: Sergei Shtylyov, netdev; +Cc: linux-kernel
On 03/09/15 13:22, Sergei Shtylyov wrote:
> I've noticed that fixed_phy_register() ignores its 'irq' parameter instead of
> passing it to fixed_phy_add(). Luckily, fixed_phy_register() seems to always
> be called with PHY_POLL for 'irq'... :-)
So not critical for -stable, good!
>
> Fixes: a75951217472 ("net: phy: extend fixed driver with fixed_phy_register()")
> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Acked-by: Florian Fainelli <f.fainelli@gmail.com>
--
Florian
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] fixed_phy: pass 'irq' to fixed_phy_add()
2015-09-03 20:22 [PATCH] fixed_phy: pass 'irq' to fixed_phy_add() Sergei Shtylyov
2015-09-03 20:23 ` Florian Fainelli
@ 2015-09-07 6:49 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2015-09-07 6:49 UTC (permalink / raw)
To: sergei.shtylyov; +Cc: netdev, f.fainelli, linux-kernel
From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Date: Thu, 03 Sep 2015 23:22:16 +0300
> I've noticed that fixed_phy_register() ignores its 'irq' parameter instead of
> passing it to fixed_phy_add(). Luckily, fixed_phy_register() seems to always
> be called with PHY_POLL for 'irq'... :-)
>
> Fixes: a75951217472 ("net: phy: extend fixed driver with fixed_phy_register()")
> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Applied, thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-09-07 6:49 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-09-03 20:22 [PATCH] fixed_phy: pass 'irq' to fixed_phy_add() Sergei Shtylyov
2015-09-03 20:23 ` Florian Fainelli
2015-09-07 6:49 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).