* [PATCH] net/mlx5: Avoid setting unused var when modifying vport node GUID
@ 2016-07-05 9:17 Or Gerlitz
2016-07-05 9:59 ` Saeed Mahameed
2016-07-05 19:13 ` David Miller
0 siblings, 2 replies; 3+ messages in thread
From: Or Gerlitz @ 2016-07-05 9:17 UTC (permalink / raw)
To: David S. Miller; +Cc: netdev, Noa Osherovich, Saeed Mahameed, Or Gerlitz
GCC complains on unused-but-set-variable, clean this up.
Fixes: 23898c763f4a ('net/mlx5: E-Switch, Modify node guid on vf set MAC')
Signed-off-by: Or Gerlitz <ogerlitz@mellanox.com>
---
drivers/net/ethernet/mellanox/mlx5/core/vport.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/net/ethernet/mellanox/mlx5/core/vport.c b/drivers/net/ethernet/mellanox/mlx5/core/vport.c
index daf44cd..91846df 100644
--- a/drivers/net/ethernet/mellanox/mlx5/core/vport.c
+++ b/drivers/net/ethernet/mellanox/mlx5/core/vport.c
@@ -513,7 +513,6 @@ int mlx5_modify_nic_vport_node_guid(struct mlx5_core_dev *mdev,
{
int inlen = MLX5_ST_SZ_BYTES(modify_nic_vport_context_in);
void *nic_vport_context;
- u8 *guid;
void *in;
int err;
@@ -535,8 +534,6 @@ int mlx5_modify_nic_vport_node_guid(struct mlx5_core_dev *mdev,
nic_vport_context = MLX5_ADDR_OF(modify_nic_vport_context_in,
in, nic_vport_context);
- guid = MLX5_ADDR_OF(nic_vport_context, nic_vport_context,
- node_guid);
MLX5_SET64(nic_vport_context, nic_vport_context, node_guid, node_guid);
err = mlx5_modify_nic_vport_context(mdev, in, inlen);
--
2.3.7
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] net/mlx5: Avoid setting unused var when modifying vport node GUID
2016-07-05 9:17 [PATCH] net/mlx5: Avoid setting unused var when modifying vport node GUID Or Gerlitz
@ 2016-07-05 9:59 ` Saeed Mahameed
2016-07-05 19:13 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: Saeed Mahameed @ 2016-07-05 9:59 UTC (permalink / raw)
To: Or Gerlitz
Cc: David S. Miller, Linux Netdev List, Noa Osherovich, Saeed Mahameed
On Tue, Jul 5, 2016 at 12:17 PM, Or Gerlitz <ogerlitz@mellanox.com> wrote:
> GCC complains on unused-but-set-variable, clean this up.
>
> Fixes: 23898c763f4a ('net/mlx5: E-Switch, Modify node guid on vf set MAC')
> Signed-off-by: Or Gerlitz <ogerlitz@mellanox.com>
Acked-by: Saeed Mahameed <saeedm@mellanox.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] net/mlx5: Avoid setting unused var when modifying vport node GUID
2016-07-05 9:17 [PATCH] net/mlx5: Avoid setting unused var when modifying vport node GUID Or Gerlitz
2016-07-05 9:59 ` Saeed Mahameed
@ 2016-07-05 19:13 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2016-07-05 19:13 UTC (permalink / raw)
To: ogerlitz; +Cc: netdev, noaos, saeedm
From: Or Gerlitz <ogerlitz@mellanox.com>
Date: Tue, 5 Jul 2016 12:17:12 +0300
> GCC complains on unused-but-set-variable, clean this up.
>
> Fixes: 23898c763f4a ('net/mlx5: E-Switch, Modify node guid on vf set MAC')
> Signed-off-by: Or Gerlitz <ogerlitz@mellanox.com>
Applied.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-07-05 19:13 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-07-05 9:17 [PATCH] net/mlx5: Avoid setting unused var when modifying vport node GUID Or Gerlitz
2016-07-05 9:59 ` Saeed Mahameed
2016-07-05 19:13 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).