netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH net-next] openvswitch: Set internal device max mtu to ETH_MAX_MTU.
@ 2017-02-15  5:16 Jarno Rajahalme
  2017-02-15 17:40 ` David Miller
  0 siblings, 1 reply; 2+ messages in thread
From: Jarno Rajahalme @ 2017-02-15  5:16 UTC (permalink / raw)
  To: netdev; +Cc: jarno, jarod, pshelar

Commit 91572088e3fd ("net: use core MTU range checking in core net
infra") changed the openvswitch internal device to use the core net
infra for controlling the MTU range, but failed to actually set the
max_mtu as described in the commit message, which now defaults to
ETH_DATA_LEN.

This patch fixes this by setting max_mtu to ETH_MAX_MTU after
ether_setup() call.

Fixes: 91572088e3fd ("net: use core MTU range checking in core net infra")
Signed-off-by: Jarno Rajahalme <jarno@ovn.org>
---
 net/openvswitch/vport-internal_dev.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/net/openvswitch/vport-internal_dev.c b/net/openvswitch/vport-internal_dev.c
index 09141a1..89193a6 100644
--- a/net/openvswitch/vport-internal_dev.c
+++ b/net/openvswitch/vport-internal_dev.c
@@ -149,6 +149,8 @@ static void do_setup(struct net_device *netdev)
 {
 	ether_setup(netdev);
 
+	netdev->max_mtu = ETH_MAX_MTU;
+
 	netdev->netdev_ops = &internal_dev_netdev_ops;
 
 	netdev->priv_flags &= ~IFF_TX_SKB_SHARING;
-- 
2.1.4

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH net-next] openvswitch: Set internal device max mtu to ETH_MAX_MTU.
  2017-02-15  5:16 [PATCH net-next] openvswitch: Set internal device max mtu to ETH_MAX_MTU Jarno Rajahalme
@ 2017-02-15 17:40 ` David Miller
  0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2017-02-15 17:40 UTC (permalink / raw)
  To: jarno; +Cc: netdev, jarod, pshelar

From: Jarno Rajahalme <jarno@ovn.org>
Date: Tue, 14 Feb 2017 21:16:28 -0800

> Commit 91572088e3fd ("net: use core MTU range checking in core net
> infra") changed the openvswitch internal device to use the core net
> infra for controlling the MTU range, but failed to actually set the
> max_mtu as described in the commit message, which now defaults to
> ETH_DATA_LEN.
> 
> This patch fixes this by setting max_mtu to ETH_MAX_MTU after
> ether_setup() call.
> 
> Fixes: 91572088e3fd ("net: use core MTU range checking in core net infra")
> Signed-off-by: Jarno Rajahalme <jarno@ovn.org>

Applied, thank you.

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2017-02-15 17:40 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-02-15  5:16 [PATCH net-next] openvswitch: Set internal device max mtu to ETH_MAX_MTU Jarno Rajahalme
2017-02-15 17:40 ` David Miller

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).