* [PATCH net-next] net: phy: lxt: Export link partner advertising
@ 2017-06-19 14:00 Thomas Bogendoerfer
2017-06-20 14:30 ` Andrew Lunn
2017-06-20 17:41 ` David Miller
0 siblings, 2 replies; 3+ messages in thread
From: Thomas Bogendoerfer @ 2017-06-19 14:00 UTC (permalink / raw)
To: andrew, f.fainelli, netdev, linux-kernel
From: Thomas Bogendoerfer <tbogendoerfer@suse.de>
Provide link partner advertising information.
Removed testing for gigabit modes, which is useless for a fast ethernet phy.
Signed-off-by: Thomas Bogendoerfer <tbogendoerfer@suse.de>
---
drivers/net/phy/lxt.c | 11 ++++-------
1 file changed, 4 insertions(+), 7 deletions(-)
diff --git a/drivers/net/phy/lxt.c b/drivers/net/phy/lxt.c
index 8d198a1f0031..09d215177fff 100644
--- a/drivers/net/phy/lxt.c
+++ b/drivers/net/phy/lxt.c
@@ -152,7 +152,6 @@ static int lxt973a2_read_status(struct phy_device *phydev)
int adv;
int err;
int lpa;
- int lpagb = 0;
/* Update the link, but return if there was an error */
err = lxt973a2_update_link(phydev);
@@ -178,18 +177,15 @@ static int lxt973a2_read_status(struct phy_device *phydev)
*/
} while (lpa == adv && retry--);
+ phydev->lp_advertising = mii_lpa_to_ethtool_lpa_t(lpa);
+
lpa &= adv;
phydev->speed = SPEED_10;
phydev->duplex = DUPLEX_HALF;
phydev->pause = phydev->asym_pause = 0;
- if (lpagb & (LPA_1000FULL | LPA_1000HALF)) {
- phydev->speed = SPEED_1000;
-
- if (lpagb & LPA_1000FULL)
- phydev->duplex = DUPLEX_FULL;
- } else if (lpa & (LPA_100FULL | LPA_100HALF)) {
+ if (lpa & (LPA_100FULL | LPA_100HALF)) {
phydev->speed = SPEED_100;
if (lpa & LPA_100FULL)
@@ -222,6 +218,7 @@ static int lxt973a2_read_status(struct phy_device *phydev)
phydev->speed = SPEED_10;
phydev->pause = phydev->asym_pause = 0;
+ phydev->lp_advertising = 0;
}
return 0;
--
2.12.3
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH net-next] net: phy: lxt: Export link partner advertising
2017-06-19 14:00 [PATCH net-next] net: phy: lxt: Export link partner advertising Thomas Bogendoerfer
@ 2017-06-20 14:30 ` Andrew Lunn
2017-06-20 17:41 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: Andrew Lunn @ 2017-06-20 14:30 UTC (permalink / raw)
To: Thomas Bogendoerfer; +Cc: f.fainelli, netdev, linux-kernel
On Mon, Jun 19, 2017 at 04:00:22PM +0200, Thomas Bogendoerfer wrote:
> From: Thomas Bogendoerfer <tbogendoerfer@suse.de>
>
> Provide link partner advertising information.
> Removed testing for gigabit modes, which is useless for a fast ethernet phy.
>
> Signed-off-by: Thomas Bogendoerfer <tbogendoerfer@suse.de>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Andrew
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH net-next] net: phy: lxt: Export link partner advertising
2017-06-19 14:00 [PATCH net-next] net: phy: lxt: Export link partner advertising Thomas Bogendoerfer
2017-06-20 14:30 ` Andrew Lunn
@ 2017-06-20 17:41 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2017-06-20 17:41 UTC (permalink / raw)
To: tsbogend; +Cc: andrew, f.fainelli, netdev, linux-kernel
From: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
Date: Mon, 19 Jun 2017 16:00:22 +0200
> From: Thomas Bogendoerfer <tbogendoerfer@suse.de>
>
> Provide link partner advertising information.
> Removed testing for gigabit modes, which is useless for a fast ethernet phy.
>
> Signed-off-by: Thomas Bogendoerfer <tbogendoerfer@suse.de>
Applied, thank you.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-06-20 17:41 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-06-19 14:00 [PATCH net-next] net: phy: lxt: Export link partner advertising Thomas Bogendoerfer
2017-06-20 14:30 ` Andrew Lunn
2017-06-20 17:41 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).