* rtnetlink: add IFLA_GROUP to ifla_policy
@ 2017-06-16 12:22 Serhey Popovych
2017-06-19 18:47 ` David Miller
0 siblings, 1 reply; 5+ messages in thread
From: Serhey Popovych @ 2017-06-16 12:22 UTC (permalink / raw)
To: netdev
Network interface groups support added while ago, however
there is no IFLA_GROUP attribute description in policy
and netlink message size calculations until now.
Add IFLA_GROUP attribute to the policy.
Fixes: cbda10fa97d7 ("net_device: add support for network device groups")
Signed-off-by: Serhey Popovych <serhe.popovych@gmail.com>
---
net/core/rtnetlink.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/net/core/rtnetlink.c b/net/core/rtnetlink.c
index 2769ad9..6e4d6c2 100644
--- a/net/core/rtnetlink.c
+++ b/net/core/rtnetlink.c
@@ -931,6 +931,7 @@ static noinline size_t if_nlmsg_size(const struct net_device *dev,
+ nla_total_size(1) /* IFLA_LINKMODE */
+ nla_total_size(4) /* IFLA_CARRIER_CHANGES */
+ nla_total_size(4) /* IFLA_LINK_NETNSID */
+ + nla_total_size(4) /* IFLA_GROUP */
+ nla_total_size(ext_filter_mask
& RTEXT_FILTER_VF ? 4 : 0) /* IFLA_NUM_VF */
+ rtnl_vfinfo_size(dev, ext_filter_mask) /* IFLA_VFINFO_LIST */
@@ -1506,6 +1507,7 @@ static int rtnl_fill_ifinfo(struct sk_buff *skb, struct net_device *dev,
[IFLA_PROTO_DOWN] = { .type = NLA_U8 },
[IFLA_XDP] = { .type = NLA_NESTED },
[IFLA_EVENT] = { .type = NLA_U32 },
+ [IFLA_GROUP] = { .type = NLA_U32 },
};
static const struct nla_policy ifla_info_policy[IFLA_INFO_MAX+1] = {
--
1.8.3.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: rtnetlink: add IFLA_GROUP to ifla_policy
2017-06-16 12:22 rtnetlink: add IFLA_GROUP to ifla_policy Serhey Popovych
@ 2017-06-19 18:47 ` David Miller
2017-06-19 18:48 ` David Miller
0 siblings, 1 reply; 5+ messages in thread
From: David Miller @ 2017-06-19 18:47 UTC (permalink / raw)
To: serhe.popovych; +Cc: netdev
From: Serhey Popovych <serhe.popovych@gmail.com>
Date: Fri, 16 Jun 2017 15:22:24 +0300
> Network interface groups support added while ago, however
> there is no IFLA_GROUP attribute description in policy
> and netlink message size calculations until now.
>
> Add IFLA_GROUP attribute to the policy.
>
> Fixes: cbda10fa97d7 ("net_device: add support for network device groups")
> Signed-off-by: Serhey Popovych <serhe.popovych@gmail.com>
Applied and queued up for -stable, thanks.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: rtnetlink: add IFLA_GROUP to ifla_policy
2017-06-19 18:47 ` David Miller
@ 2017-06-19 18:48 ` David Miller
2017-06-20 11:35 ` [PATCH] " Serhey Popovych
0 siblings, 1 reply; 5+ messages in thread
From: David Miller @ 2017-06-19 18:48 UTC (permalink / raw)
To: serhe.popovych; +Cc: netdev
From: David Miller <davem@davemloft.net>
Date: Mon, 19 Jun 2017 14:47:44 -0400 (EDT)
> From: Serhey Popovych <serhe.popovych@gmail.com>
> Date: Fri, 16 Jun 2017 15:22:24 +0300
>
>> Network interface groups support added while ago, however
>> there is no IFLA_GROUP attribute description in policy
>> and netlink message size calculations until now.
>>
>> Add IFLA_GROUP attribute to the policy.
>>
>> Fixes: cbda10fa97d7 ("net_device: add support for network device groups")
>> Signed-off-by: Serhey Popovych <serhe.popovych@gmail.com>
>
> Applied and queued up for -stable, thanks.
Actually, this doesn't apply cleanly to the 'net' tree, please
respin.
Thansk.
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH] rtnetlink: add IFLA_GROUP to ifla_policy
2017-06-19 18:48 ` David Miller
@ 2017-06-20 11:35 ` Serhey Popovych
2017-06-20 19:36 ` David Miller
0 siblings, 1 reply; 5+ messages in thread
From: Serhey Popovych @ 2017-06-20 11:35 UTC (permalink / raw)
To: davem; +Cc: netdev
Network interface groups support added while ago, however
there is no IFLA_GROUP attribute description in policy
and netlink message size calculations until now.
Add IFLA_GROUP attribute to the policy.
Fixes: cbda10fa97d7 ("net_device: add support for network device groups")
Signed-off-by: Serhey Popovych <serhe.popovych@gmail.com>
---
v2: Rebased to kernel/git/davem/net.git
net/core/rtnetlink.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/net/core/rtnetlink.c b/net/core/rtnetlink.c
index 5e61456..467a2f4 100644
--- a/net/core/rtnetlink.c
+++ b/net/core/rtnetlink.c
@@ -931,6 +931,7 @@ static noinline size_t if_nlmsg_size(const struct net_device *dev,
+ nla_total_size(1) /* IFLA_LINKMODE */
+ nla_total_size(4) /* IFLA_CARRIER_CHANGES */
+ nla_total_size(4) /* IFLA_LINK_NETNSID */
+ + nla_total_size(4) /* IFLA_GROUP */
+ nla_total_size(ext_filter_mask
& RTEXT_FILTER_VF ? 4 : 0) /* IFLA_NUM_VF */
+ rtnl_vfinfo_size(dev, ext_filter_mask) /* IFLA_VFINFO_LIST */
@@ -1468,6 +1469,7 @@ static int rtnl_fill_ifinfo(struct sk_buff *skb, struct net_device *dev,
[IFLA_LINK_NETNSID] = { .type = NLA_S32 },
[IFLA_PROTO_DOWN] = { .type = NLA_U8 },
[IFLA_XDP] = { .type = NLA_NESTED },
+ [IFLA_GROUP] = { .type = NLA_U32 },
};
static const struct nla_policy ifla_info_policy[IFLA_INFO_MAX+1] = {
--
1.8.3.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] rtnetlink: add IFLA_GROUP to ifla_policy
2017-06-20 11:35 ` [PATCH] " Serhey Popovych
@ 2017-06-20 19:36 ` David Miller
0 siblings, 0 replies; 5+ messages in thread
From: David Miller @ 2017-06-20 19:36 UTC (permalink / raw)
To: serhe.popovych; +Cc: netdev
From: Serhey Popovych <serhe.popovych@gmail.com>
Date: Tue, 20 Jun 2017 14:35:23 +0300
> Network interface groups support added while ago, however
> there is no IFLA_GROUP attribute description in policy
> and netlink message size calculations until now.
>
> Add IFLA_GROUP attribute to the policy.
>
> Fixes: cbda10fa97d7 ("net_device: add support for network device groups")
> Signed-off-by: Serhey Popovych <serhe.popovych@gmail.com>
> ---
> v2: Rebased to kernel/git/davem/net.git
Applied and queued up for -stable.
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2017-06-20 19:36 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-06-16 12:22 rtnetlink: add IFLA_GROUP to ifla_policy Serhey Popovych
2017-06-19 18:47 ` David Miller
2017-06-19 18:48 ` David Miller
2017-06-20 11:35 ` [PATCH] " Serhey Popovych
2017-06-20 19:36 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).