From: Jakub Kicinski <kubakici@wp.pl>
To: Andrew Lunn <andrew@lunn.ch>
Cc: Casey Leedom <leedom@chelsio.com>,
Dustin Byford <dustin@cumulusnetworks.com>,
Roopa Prabhu <roopa@cumulusnetworks.com>,
"davem@davemloft.net" <davem@davemloft.net>,
"linville@tuxdriver.com" <linville@tuxdriver.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"vidya.chowdary@gmail.com" <vidya.chowdary@gmail.com>,
"olson@cumulusnetworks.com" <olson@cumulusnetworks.com>,
Manoj Malviya <manojmalviya@chelsio.com>,
Santosh Rastapur <santosh@chelsio.com>,
"yuval.mintz@qlogic.com" <yuval.mintz@qlogic.com>,
"odedw@mellanox.com" <odedw@mellanox.com>,
"ariela@mellanox.com" <ariela@mellanox.com>,
"galp@mellanox.com" <galp@mellanox.com>,
"jeffrey.t.kirsher@intel.com" <jeffrey.t.kirsher@intel.com>
Subject: Re: [PATCH net-next 1/3] net: ethtool: add support for forward error correction modes
Date: Thu, 6 Jul 2017 16:27:49 -0700 [thread overview]
Message-ID: <20170706162749.4f51f36d@cakuba.netronome.com> (raw)
In-Reply-To: <20170706231550.GC24237@lunn.ch>
On Fri, 7 Jul 2017 01:15:50 +0200, Andrew Lunn wrote:
> > Even this feels too extreme for me. I think users would hate it. They
> > did an ifup and swapped cables. They expect the OS/Driver/Firmware
> > to continue trying to honor their ifup request.
>
> Lets take a look around at other subsystems....
>
> What happens if you hot-unplug a SATA drive?
> An MMC card?
> A USB device?
> A PCIe card?
> A CPU?
> An SDRAM?
>
> Do you know of any subsystem that tried to keep its configuration
> across a hot unplug/plug event? I suspect they all require user space
> to take some action to get the newly plugged hardware into operation.
That was exactly my thinking initially, but I'm not so sure anymore
because the layer to which configuration is applied does not reside on
the portion of HW which is hot swapped. I'm very far from an expert on
the PHY layer stuff but modules start at the PMA layer?
If only IEEE defined for us what the behaviour should be :)
next prev parent reply other threads:[~2017-07-06 23:28 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-24 19:19 [PATCH net-next 0/3] ethtool: support for forward error correction mode setting on a link Roopa Prabhu
2017-06-24 19:19 ` [PATCH net-next 1/3] net: ethtool: add support for forward error correction modes Roopa Prabhu
2017-06-25 13:38 ` Gal Pressman
2017-06-28 5:46 ` Dustin Byford
2017-06-29 15:49 ` Gal Pressman
2017-06-27 10:22 ` Jakub Kicinski
2017-06-28 6:27 ` Dustin Byford
2017-06-28 6:41 ` Jakub Kicinski
2017-06-28 13:41 ` Andrew Lunn
2017-06-28 21:47 ` Dustin Byford
2017-06-29 1:00 ` Jakub Kicinski
2017-07-06 18:53 ` Casey Leedom
2017-07-06 19:02 ` Jakub Kicinski
2017-07-06 21:06 ` Wyborny, Carolyn
2017-07-06 21:53 ` Casey Leedom
2017-07-06 22:16 ` Wyborny, Carolyn
2017-07-06 22:36 ` Andrew Lunn
2017-07-06 22:37 ` Casey Leedom
2017-07-06 22:33 ` Andrew Lunn
2017-07-06 22:47 ` Casey Leedom
2017-07-06 23:15 ` Andrew Lunn
2017-07-06 23:27 ` Jakub Kicinski [this message]
2017-07-06 23:39 ` Casey Leedom
2017-07-07 0:56 ` Andrew Lunn
2017-07-07 1:38 ` Dave Olson
2017-07-06 22:43 ` Jakub Kicinski
2017-07-06 22:57 ` Casey Leedom
2017-06-29 13:30 ` Andrew Lunn
2017-06-24 19:19 ` [PATCH net-next 2/3] cxgb4: core hardware/firmware support for Forward Error Correction on a link Roopa Prabhu
2017-06-27 3:16 ` David Miller
2017-06-24 19:19 ` [PATCH net-next 3/3] cxgb4: ethtool forward error correction management support Roopa Prabhu
2017-06-24 21:47 ` [PATCH net-next 0/3] ethtool: support for forward error correction mode setting on a link Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170706162749.4f51f36d@cakuba.netronome.com \
--to=kubakici@wp.pl \
--cc=andrew@lunn.ch \
--cc=ariela@mellanox.com \
--cc=davem@davemloft.net \
--cc=dustin@cumulusnetworks.com \
--cc=galp@mellanox.com \
--cc=jeffrey.t.kirsher@intel.com \
--cc=leedom@chelsio.com \
--cc=linville@tuxdriver.com \
--cc=manojmalviya@chelsio.com \
--cc=netdev@vger.kernel.org \
--cc=odedw@mellanox.com \
--cc=olson@cumulusnetworks.com \
--cc=roopa@cumulusnetworks.com \
--cc=santosh@chelsio.com \
--cc=vidya.chowdary@gmail.com \
--cc=yuval.mintz@qlogic.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).