* [PATCH][net-next][V3] bpf: test_maps: fix typos, "conenct" and "listeen"
@ 2017-08-30 17:15 Colin King
2017-08-30 17:31 ` John Fastabend
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Colin King @ 2017-08-30 17:15 UTC (permalink / raw)
To: Alexei Starovoitov, Daniel Borkmann, Shuah Khan, netdev,
linux-kselftest, linux-kernel
From: Colin Ian King <colin.king@canonical.com>
Trivial fix to typos in printf error messages:
"conenct" -> "connect"
"listeen" -> "listen"
thanks to Daniel Borkmann for spotting one of these mistakes
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
tools/testing/selftests/bpf/test_maps.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/tools/testing/selftests/bpf/test_maps.c b/tools/testing/selftests/bpf/test_maps.c
index 7059bb315a10..4acc772a28c0 100644
--- a/tools/testing/selftests/bpf/test_maps.c
+++ b/tools/testing/selftests/bpf/test_maps.c
@@ -504,7 +504,7 @@ static void test_sockmap(int tasks, void *data)
}
err = listen(sfd[i], 32);
if (err < 0) {
- printf("failed to listeen\n");
+ printf("failed to listen\n");
goto out;
}
}
@@ -525,7 +525,7 @@ static void test_sockmap(int tasks, void *data)
addr.sin_port = htons(ports[i - 2]);
err = connect(sfd[i], (struct sockaddr *)&addr, sizeof(addr));
if (err) {
- printf("failed to conenct\n");
+ printf("failed to connect\n");
goto out;
}
}
--
2.14.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH][net-next][V3] bpf: test_maps: fix typos, "conenct" and "listeen"
2017-08-30 17:15 [PATCH][net-next][V3] bpf: test_maps: fix typos, "conenct" and "listeen" Colin King
@ 2017-08-30 17:31 ` John Fastabend
2017-08-30 18:47 ` Daniel Borkmann
2017-08-30 22:32 ` David Miller
2 siblings, 0 replies; 6+ messages in thread
From: John Fastabend @ 2017-08-30 17:31 UTC (permalink / raw)
To: Colin King, Alexei Starovoitov, Daniel Borkmann, Shuah Khan,
netdev, linux-kselftest, linux-kernel
On 08/30/2017 10:15 AM, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> Trivial fix to typos in printf error messages:
> "conenct" -> "connect"
> "listeen" -> "listen"
>
> thanks to Daniel Borkmann for spotting one of these mistakes
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
Thanks. Even though its a spelling typo best to add fixes tag
I think.
Fixes: 6f6d33f3b3d0 ("bpf: selftests add sockmap tests")
Acked-by: John Fastabend <john.fastabend@gmail.com>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH][net-next][V3] bpf: test_maps: fix typos, "conenct" and "listeen"
2017-08-30 17:15 [PATCH][net-next][V3] bpf: test_maps: fix typos, "conenct" and "listeen" Colin King
2017-08-30 17:31 ` John Fastabend
@ 2017-08-30 18:47 ` Daniel Borkmann
2017-08-30 20:13 ` Shuah Khan
2017-08-30 22:32 ` David Miller
2 siblings, 1 reply; 6+ messages in thread
From: Daniel Borkmann @ 2017-08-30 18:47 UTC (permalink / raw)
To: Colin King, Alexei Starovoitov, Shuah Khan, netdev,
linux-kselftest, linux-kernel
On 08/30/2017 07:15 PM, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> Trivial fix to typos in printf error messages:
> "conenct" -> "connect"
> "listeen" -> "listen"
>
> thanks to Daniel Borkmann for spotting one of these mistakes
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Acked-by: Daniel Borkmann <daniel@iogearbox.net>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH][net-next][V3] bpf: test_maps: fix typos, "conenct" and "listeen"
2017-08-30 18:47 ` Daniel Borkmann
@ 2017-08-30 20:13 ` Shuah Khan
2017-08-30 20:24 ` Daniel Borkmann
0 siblings, 1 reply; 6+ messages in thread
From: Shuah Khan @ 2017-08-30 20:13 UTC (permalink / raw)
To: Daniel Borkmann, Colin King, Alexei Starovoitov, netdev,
linux-kselftest, linux-kernel, Shuah Khan
Cc: Shuah Khan
On 08/30/2017 12:47 PM, Daniel Borkmann wrote:
> On 08/30/2017 07:15 PM, Colin King wrote:
>> From: Colin Ian King <colin.king@canonical.com>
>>
>> Trivial fix to typos in printf error messages:
>> "conenct" -> "connect"
>> "listeen" -> "listen"
>>
>> thanks to Daniel Borkmann for spotting one of these mistakes
>>
>> Signed-off-by: Colin Ian King <colin.king@canonical.com>
>
> Acked-by: Daniel Borkmann <daniel@iogearbox.net>
>
>
I can get this into 4.14-rc1 unless it should go through net-next
for dependencies. In which case,
Acked-by: Shuah Khan <shuahkh@osg.samsung.com>
thanks,
-- Shuah
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH][net-next][V3] bpf: test_maps: fix typos, "conenct" and "listeen"
2017-08-30 20:13 ` Shuah Khan
@ 2017-08-30 20:24 ` Daniel Borkmann
0 siblings, 0 replies; 6+ messages in thread
From: Daniel Borkmann @ 2017-08-30 20:24 UTC (permalink / raw)
To: shuah, Colin King, Alexei Starovoitov, netdev, linux-kselftest,
linux-kernel, Shuah Khan
On 08/30/2017 10:13 PM, Shuah Khan wrote:
> On 08/30/2017 12:47 PM, Daniel Borkmann wrote:
>> On 08/30/2017 07:15 PM, Colin King wrote:
>>> From: Colin Ian King <colin.king@canonical.com>
>>>
>>> Trivial fix to typos in printf error messages:
>>> "conenct" -> "connect"
>>> "listeen" -> "listen"
>>>
>>> thanks to Daniel Borkmann for spotting one of these mistakes
>>>
>>> Signed-off-by: Colin Ian King <colin.king@canonical.com>
>>
>> Acked-by: Daniel Borkmann <daniel@iogearbox.net>
>
> I can get this into 4.14-rc1 unless it should go through net-next
> for dependencies. In which case,
Yeah, it does depends on work sitting in net-next so easier
to go that route.
Thanks,
Daniel
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH][net-next][V3] bpf: test_maps: fix typos, "conenct" and "listeen"
2017-08-30 17:15 [PATCH][net-next][V3] bpf: test_maps: fix typos, "conenct" and "listeen" Colin King
2017-08-30 17:31 ` John Fastabend
2017-08-30 18:47 ` Daniel Borkmann
@ 2017-08-30 22:32 ` David Miller
2 siblings, 0 replies; 6+ messages in thread
From: David Miller @ 2017-08-30 22:32 UTC (permalink / raw)
To: colin.king; +Cc: ast, daniel, shuah, netdev, linux-kselftest, linux-kernel
From: Colin King <colin.king@canonical.com>
Date: Wed, 30 Aug 2017 18:15:25 +0100
> From: Colin Ian King <colin.king@canonical.com>
>
> Trivial fix to typos in printf error messages:
> "conenct" -> "connect"
> "listeen" -> "listen"
>
> thanks to Daniel Borkmann for spotting one of these mistakes
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Applied.
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2017-08-30 22:33 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-08-30 17:15 [PATCH][net-next][V3] bpf: test_maps: fix typos, "conenct" and "listeen" Colin King
2017-08-30 17:31 ` John Fastabend
2017-08-30 18:47 ` Daniel Borkmann
2017-08-30 20:13 ` Shuah Khan
2017-08-30 20:24 ` Daniel Borkmann
2017-08-30 22:32 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).