* [PATCH net] udp: fix secpath leak
@ 2017-09-01 12:42 Paolo Abeni
2017-09-01 17:30 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Paolo Abeni @ 2017-09-01 12:42 UTC (permalink / raw)
To: netdev; +Cc: David S. Miller, Yossi Kuperman, Paul Moore
From: Yossi Kuperman <yossiku@mellanox.com>
After commit dce4551cb2ad ("udp: preserve head state for IP_CMSG_PASSSEC")
we preserve the secpath for the whole skb lifecycle, but we also
end up leaking a reference to it.
We must clear the head state on skb reception, if secpath is
present.
Fixes: dce4551cb2ad ("udp: preserve head state for IP_CMSG_PASSSEC")
Signed-off-by: Yossi Kuperman <yossiku@mellanox.com>
Signed-off-by: Paolo Abeni <pabeni@redhat.com>
---
net/ipv4/udp.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/ipv4/udp.c b/net/ipv4/udp.c
index a6dc48d76a29..62344804baae 100644
--- a/net/ipv4/udp.c
+++ b/net/ipv4/udp.c
@@ -1176,7 +1176,7 @@ static void udp_set_dev_scratch(struct sk_buff *skb)
scratch->csum_unnecessary = !!skb_csum_unnecessary(skb);
scratch->is_linear = !skb_is_nonlinear(skb);
#endif
- if (likely(!skb->_skb_refdst))
+ if (likely(!skb->_skb_refdst && !skb_sec_path(skb)))
scratch->_tsize_state |= UDP_SKB_IS_STATELESS;
}
--
2.13.5
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH net] udp: fix secpath leak
2017-09-01 12:42 [PATCH net] udp: fix secpath leak Paolo Abeni
@ 2017-09-01 17:30 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2017-09-01 17:30 UTC (permalink / raw)
To: pabeni; +Cc: netdev, yossiku, paul
From: Paolo Abeni <pabeni@redhat.com>
Date: Fri, 1 Sep 2017 14:42:30 +0200
> From: Yossi Kuperman <yossiku@mellanox.com>
>
> After commit dce4551cb2ad ("udp: preserve head state for IP_CMSG_PASSSEC")
> we preserve the secpath for the whole skb lifecycle, but we also
> end up leaking a reference to it.
>
> We must clear the head state on skb reception, if secpath is
> present.
>
> Fixes: dce4551cb2ad ("udp: preserve head state for IP_CMSG_PASSSEC")
> Signed-off-by: Yossi Kuperman <yossiku@mellanox.com>
> Signed-off-by: Paolo Abeni <pabeni@redhat.com>
Applied.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-09-01 17:30 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-09-01 12:42 [PATCH net] udp: fix secpath leak Paolo Abeni
2017-09-01 17:30 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).