* [PATCH 0/2] blackfin: Drop non-functional DSA code
@ 2017-09-20 1:03 Florian Fainelli
2017-09-20 1:03 ` [PATCH 1/2] blackfin: tcm-bf518: Remove dsa.h inclusion Florian Fainelli
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Florian Fainelli @ 2017-09-20 1:03 UTC (permalink / raw)
To: netdev
Cc: davem, andrew, vivien.didelot, realmz6, adi-buildroot-devel,
Florian Fainelli
Hi David,
I sent those many months ago in the hope that the bfin-linux people
would pick those patches but nobody seems to be responding, can you
queue those via net-next since this affects DSA?
Thanks!
Florian Fainelli (2):
blackfin: tcm-bf518: Remove dsa.h inclusion
blackfin: ezbrd: Remove non-functional DSA/KSZ8893M code
arch/blackfin/mach-bf518/boards/ezbrd.c | 47 -----------------------------
arch/blackfin/mach-bf518/boards/tcm-bf518.c | 1 -
2 files changed, 48 deletions(-)
--
2.11.0
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH 1/2] blackfin: tcm-bf518: Remove dsa.h inclusion
2017-09-20 1:03 [PATCH 0/2] blackfin: Drop non-functional DSA code Florian Fainelli
@ 2017-09-20 1:03 ` Florian Fainelli
2017-09-20 1:03 ` [PATCH 2/2] blackfin: ezbrd: Remove non-functional DSA/KSZ8893M code Florian Fainelli
2017-09-20 22:57 ` [PATCH 0/2] blackfin: Drop non-functional DSA code David Miller
2 siblings, 0 replies; 4+ messages in thread
From: Florian Fainelli @ 2017-09-20 1:03 UTC (permalink / raw)
To: netdev
Cc: davem, andrew, vivien.didelot, realmz6, adi-buildroot-devel,
Florian Fainelli
Nothing in that file uses definitions from that header, so just get rid of it.
Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
---
arch/blackfin/mach-bf518/boards/tcm-bf518.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/arch/blackfin/mach-bf518/boards/tcm-bf518.c b/arch/blackfin/mach-bf518/boards/tcm-bf518.c
index 240d5cb1f02c..37d868085f6a 100644
--- a/arch/blackfin/mach-bf518/boards/tcm-bf518.c
+++ b/arch/blackfin/mach-bf518/boards/tcm-bf518.c
@@ -25,7 +25,6 @@
#include <asm/dpmc.h>
#include <asm/bfin_sdh.h>
#include <linux/spi/ad7877.h>
-#include <net/dsa.h>
/*
* Name the Board for the /proc/cpuinfo
--
2.11.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH 2/2] blackfin: ezbrd: Remove non-functional DSA/KSZ8893M code
2017-09-20 1:03 [PATCH 0/2] blackfin: Drop non-functional DSA code Florian Fainelli
2017-09-20 1:03 ` [PATCH 1/2] blackfin: tcm-bf518: Remove dsa.h inclusion Florian Fainelli
@ 2017-09-20 1:03 ` Florian Fainelli
2017-09-20 22:57 ` [PATCH 0/2] blackfin: Drop non-functional DSA code David Miller
2 siblings, 0 replies; 4+ messages in thread
From: Florian Fainelli @ 2017-09-20 1:03 UTC (permalink / raw)
To: netdev
Cc: davem, andrew, vivien.didelot, realmz6, adi-buildroot-devel,
Florian Fainelli
There is no in tree driver for the KSZ8893M switch driver, so just get rid of
the code in that board file.
Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
---
arch/blackfin/mach-bf518/boards/ezbrd.c | 47 ---------------------------------
1 file changed, 47 deletions(-)
diff --git a/arch/blackfin/mach-bf518/boards/ezbrd.c b/arch/blackfin/mach-bf518/boards/ezbrd.c
index d022112927c2..c51d1b810ac3 100644
--- a/arch/blackfin/mach-bf518/boards/ezbrd.c
+++ b/arch/blackfin/mach-bf518/boards/ezbrd.c
@@ -25,7 +25,6 @@
#include <asm/dpmc.h>
#include <asm/bfin_sdh.h>
#include <linux/spi/ad7877.h>
-#include <net/dsa.h>
/*
* Name the Board for the /proc/cpuinfo
@@ -105,11 +104,7 @@ static const unsigned short bfin_mac_peripherals[] = {
static struct bfin_phydev_platform_data bfin_phydev_data[] = {
{
-#if IS_ENABLED(CONFIG_NET_DSA_KSZ8893M)
- .addr = 3,
-#else
.addr = 1,
-#endif
.irq = IRQ_MAC_PHYINT,
},
};
@@ -119,9 +114,6 @@ static struct bfin_mii_bus_platform_data bfin_mii_bus_data = {
.phydev_data = bfin_phydev_data,
.phy_mode = PHY_INTERFACE_MODE_MII,
.mac_peripherals = bfin_mac_peripherals,
-#if IS_ENABLED(CONFIG_NET_DSA_KSZ8893M)
- .phy_mask = 0xfff7, /* Only probe the port phy connect to the on chip MAC */
-#endif
.vlan1_mask = 1,
.vlan2_mask = 2,
};
@@ -140,29 +132,6 @@ static struct platform_device bfin_mac_device = {
}
};
-#if IS_ENABLED(CONFIG_NET_DSA_KSZ8893M)
-static struct dsa_chip_data ksz8893m_switch_chip_data = {
- .mii_bus = &bfin_mii_bus.dev,
- .port_names = {
- NULL,
- "eth%d",
- "eth%d",
- "cpu",
- },
-};
-static struct dsa_platform_data ksz8893m_switch_data = {
- .nr_chips = 1,
- .netdev = &bfin_mac_device.dev,
- .chip = &ksz8893m_switch_chip_data,
-};
-
-static struct platform_device ksz8893m_switch_device = {
- .name = "dsa",
- .id = 0,
- .num_resources = 0,
- .dev.platform_data = &ksz8893m_switch_data,
-};
-#endif
#endif
#if IS_ENABLED(CONFIG_MTD_M25P80)
@@ -228,19 +197,6 @@ static struct spi_board_info bfin_spi_board_info[] __initdata = {
},
#endif
-#if IS_ENABLED(CONFIG_BFIN_MAC)
-#if IS_ENABLED(CONFIG_NET_DSA_KSZ8893M)
- {
- .modalias = "ksz8893m",
- .max_speed_hz = 5000000,
- .bus_num = 0,
- .chip_select = 1,
- .platform_data = NULL,
- .mode = SPI_MODE_3,
- },
-#endif
-#endif
-
#if IS_ENABLED(CONFIG_MMC_SPI)
{
.modalias = "mmc_spi",
@@ -714,9 +670,6 @@ static struct platform_device *stamp_devices[] __initdata = {
#if IS_ENABLED(CONFIG_BFIN_MAC)
&bfin_mii_bus,
&bfin_mac_device,
-#if IS_ENABLED(CONFIG_NET_DSA_KSZ8893M)
- &ksz8893m_switch_device,
-#endif
#endif
#if IS_ENABLED(CONFIG_SPI_BFIN5XX)
--
2.11.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH 0/2] blackfin: Drop non-functional DSA code
2017-09-20 1:03 [PATCH 0/2] blackfin: Drop non-functional DSA code Florian Fainelli
2017-09-20 1:03 ` [PATCH 1/2] blackfin: tcm-bf518: Remove dsa.h inclusion Florian Fainelli
2017-09-20 1:03 ` [PATCH 2/2] blackfin: ezbrd: Remove non-functional DSA/KSZ8893M code Florian Fainelli
@ 2017-09-20 22:57 ` David Miller
2 siblings, 0 replies; 4+ messages in thread
From: David Miller @ 2017-09-20 22:57 UTC (permalink / raw)
To: f.fainelli; +Cc: netdev, andrew, vivien.didelot, realmz6, adi-buildroot-devel
From: Florian Fainelli <f.fainelli@gmail.com>
Date: Tue, 19 Sep 2017 18:03:44 -0700
> I sent those many months ago in the hope that the bfin-linux people
> would pick those patches but nobody seems to be responding, can you
> queue those via net-next since this affects DSA?
Ok, if they aren't responding what can we do. Probably should update
the MAINTAINERS file to reflect this...
Series applied to net-next, thanks.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-09-20 22:57 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-09-20 1:03 [PATCH 0/2] blackfin: Drop non-functional DSA code Florian Fainelli
2017-09-20 1:03 ` [PATCH 1/2] blackfin: tcm-bf518: Remove dsa.h inclusion Florian Fainelli
2017-09-20 1:03 ` [PATCH 2/2] blackfin: ezbrd: Remove non-functional DSA/KSZ8893M code Florian Fainelli
2017-09-20 22:57 ` [PATCH 0/2] blackfin: Drop non-functional DSA code David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).