* [PATCH net-next] tc-testing: correction to docstring in get_unique_item
@ 2017-10-31 18:28 Brenda J. Butler
2017-10-31 18:42 ` Lucas Bates
2017-11-01 2:06 ` David Miller
0 siblings, 2 replies; 5+ messages in thread
From: Brenda J. Butler @ 2017-10-31 18:28 UTC (permalink / raw)
To: davem
Cc: jhs, xiyou.wangcong, jiri, chrism, lucasb, aring, mrv, netdev,
Brenda J. Butler
Signed-off-by: Brenda J. Butler <bjb@mojatatu.com>
---
tools/testing/selftests/tc-testing/tdc_helper.py | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/testing/selftests/tc-testing/tdc_helper.py b/tools/testing/selftests/tc-testing/tdc_helper.py
index c3254f861fb2..6f99a4efe761 100644
--- a/tools/testing/selftests/tc-testing/tdc_helper.py
+++ b/tools/testing/selftests/tc-testing/tdc_helper.py
@@ -15,7 +15,7 @@ def get_categorized_testlist(alltests, ucat):
def get_unique_item(lst):
- """ For a list, return a set of the unique items in the list. """
+ """ For a list, return a list of the unique items in the list. """
return list(set(lst))
--
2.15.0.rc0
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH net-next] tc-testing: correction to docstring in get_unique_item
2017-10-31 18:28 [PATCH net-next] tc-testing: correction to docstring in get_unique_item Brenda J. Butler
@ 2017-10-31 18:42 ` Lucas Bates
2017-11-01 2:06 ` David Miller
1 sibling, 0 replies; 5+ messages in thread
From: Lucas Bates @ 2017-10-31 18:42 UTC (permalink / raw)
To: Brenda J. Butler
Cc: davem, Jamal Hadi Salim, Cong Wang, Jiri Pirko, Chris Mi,
Alexander Aring, Roman Mashak, Linux Kernel Network Developers
On Tue, Oct 31, 2017 at 2:28 PM, Brenda J. Butler <bjb@mojatatu.com> wrote:
> Signed-off-by: Brenda J. Butler <bjb@mojatatu.com>
> ---
> tools/testing/selftests/tc-testing/tdc_helper.py | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/testing/selftests/tc-testing/tdc_helper.py b/tools/testing/selftests/tc-testing/tdc_helper.py
> index c3254f861fb2..6f99a4efe761 100644
> --- a/tools/testing/selftests/tc-testing/tdc_helper.py
> +++ b/tools/testing/selftests/tc-testing/tdc_helper.py
> @@ -15,7 +15,7 @@ def get_categorized_testlist(alltests, ucat):
>
>
> def get_unique_item(lst):
> - """ For a list, return a set of the unique items in the list. """
> + """ For a list, return a list of the unique items in the list. """
> return list(set(lst))
>
>
> --
> 2.15.0.rc0
>
Acked-by: Lucas Bates <lucasb@mojatatu.com>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH net-next] tc-testing: correction to docstring in get_unique_item
2017-10-31 18:28 [PATCH net-next] tc-testing: correction to docstring in get_unique_item Brenda J. Butler
2017-10-31 18:42 ` Lucas Bates
@ 2017-11-01 2:06 ` David Miller
1 sibling, 0 replies; 5+ messages in thread
From: David Miller @ 2017-11-01 2:06 UTC (permalink / raw)
To: bjb; +Cc: jhs, xiyou.wangcong, jiri, chrism, lucasb, aring, mrv, netdev
From: "Brenda J. Butler" <bjb@mojatatu.com>
Date: Tue, 31 Oct 2017 14:28:02 -0400
> Signed-off-by: Brenda J. Butler <bjb@mojatatu.com>
Applied.
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH net-next] tc-testing: correction to docstring in get_unique_item
@ 2017-10-31 0:37 Brenda J. Butler
2017-10-31 1:49 ` Lucas Bates
0 siblings, 1 reply; 5+ messages in thread
From: Brenda J. Butler @ 2017-10-31 0:37 UTC (permalink / raw)
To: davem
Cc: jhs, xiyou.wangcong, jiri, chrism, lucasb, aring, mrv, netdev,
Brenda J. Butler
The docstring says the function returns a "set" but it returns
a "list". These are both python data types, so we should refer to
the right one that is being returned.
Signed-off-by: Brenda J. Butler <bjb@mojatatu.com>
---
This patch was formerly sent as part of a 15-patch series. It is being
split off as a stand-alone patch.
tools/testing/selftests/tc-testing/tdc_helper.py | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/testing/selftests/tc-testing/tdc_helper.py b/tools/testing/selftests/tc-testing/tdc_helper.py
index c3254f861fb2..6f99a4efe761 100644
--- a/tools/testing/selftests/tc-testing/tdc_helper.py
+++ b/tools/testing/selftests/tc-testing/tdc_helper.py
@@ -15,7 +15,7 @@ def get_categorized_testlist(alltests, ucat):
def get_unique_item(lst):
- """ For a list, return a set of the unique items in the list. """
+ """ For a list, return a list of the unique items in the list. """
return list(set(lst))
--
2.15.0.rc0
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH net-next] tc-testing: correction to docstring in get_unique_item
2017-10-31 0:37 Brenda J. Butler
@ 2017-10-31 1:49 ` Lucas Bates
0 siblings, 0 replies; 5+ messages in thread
From: Lucas Bates @ 2017-10-31 1:49 UTC (permalink / raw)
To: Brenda J. Butler
Cc: davem, Jamal Hadi Salim, Cong Wang, Jiri Pirko, Chris Mi,
Alexander Aring, Roman Mashak, Linux Kernel Network Developers
On Mon, Oct 30, 2017 at 8:37 PM, Brenda J. Butler <bjb@mojatatu.com> wrote:
> The docstring says the function returns a "set" but it returns
> a "list". These are both python data types, so we should refer to
> the right one that is being returned.
>
> Signed-off-by: Brenda J. Butler <bjb@mojatatu.com>
Acked-by: Lucas Bates <lucasb@mojatatu.com>
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2017-11-01 2:06 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-10-31 18:28 [PATCH net-next] tc-testing: correction to docstring in get_unique_item Brenda J. Butler
2017-10-31 18:42 ` Lucas Bates
2017-11-01 2:06 ` David Miller
-- strict thread matches above, loose matches on Subject: below --
2017-10-31 0:37 Brenda J. Butler
2017-10-31 1:49 ` Lucas Bates
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).