netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: bjb@mojatatu.com
Cc: jhs@mojatatu.com, xiyou.wangcong@gmail.com, jiri@resnulli.us,
	chrism@mellanox.com, lucasb@mojatatu.com, aring@mojatatu.com,
	mrv@mojatatu.com, netdev@vger.kernel.org
Subject: Re: [PATCH net-next] tc-testing: split config file
Date: Wed, 01 Nov 2017 11:06:23 +0900 (KST)	[thread overview]
Message-ID: <20171101.110623.348780136039045689.davem@davemloft.net> (raw)
In-Reply-To: <20171031182728.9725-1-bjb@mojatatu.com>

From: "Brenda J. Butler" <bjb@mojatatu.com>
Date: Tue, 31 Oct 2017 14:27:28 -0400

> Move the config customization into a site-local file
> tdc_config_local.py, so that updates of the tdc test
> software does not require hand-editing of the config.
> This patch includes a template for the site-local
> customization file.
> 
> In addition, this makes it easy to revert to a stock
> tdc environment for testing the test framework and/or
> the core tests.
> 
> Also it makes it harder for any custom config to be
> submitted back to the kernel tdc.
> 
> Signed-off-by: Brenda J. Butler <bjb@mojatatu.com>

Please always remove trailing empty lines in files, GIT even warns
about this when one tries to apply the patch:

> @@ -17,3 +17,17 @@ NAMES = {
>            # Name of the namespace to use
>            'NS': 'tcut'
>          }
> +
 ...
> +# example adding values to ENVIR, without editing tdc_config.py
> +ENVIR['VALGRIND_LIB'] = '/usr/lib/valgrind'
> +ENVIR['VALGRIND_BIN'] = '/usr/bin/valgrind'
> +ENVIR['VGDB_BIN'] = '/usr/bin/vgdb'
> +

I fixed it up this time, but please be mindful of this in the future.

Thanks.

  parent reply	other threads:[~2017-11-01  2:06 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-10-31 18:27 [PATCH net-next] tc-testing: split config file Brenda J. Butler
2017-10-31 18:40 ` Lucas Bates
2017-11-01  2:06 ` David Miller [this message]
2017-11-01  2:41   ` Brenda Butler

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171101.110623.348780136039045689.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=aring@mojatatu.com \
    --cc=bjb@mojatatu.com \
    --cc=chrism@mellanox.com \
    --cc=jhs@mojatatu.com \
    --cc=jiri@resnulli.us \
    --cc=lucasb@mojatatu.com \
    --cc=mrv@mojatatu.com \
    --cc=netdev@vger.kernel.org \
    --cc=xiyou.wangcong@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).