From: Brenda Butler <bjb@mojatatu.com>
To: David Miller <davem@davemloft.net>
Cc: Jamal Hadi Salim <jhs@mojatatu.com>,
Cong Wang <xiyou.wangcong@gmail.com>,
Jiri Pirko <jiri@resnulli.us>, Chris Mi <chrism@mellanox.com>,
Lucas Bates <lucasb@mojatatu.com>,
Alexander Aring <aring@mojatatu.com>,
Roman Mashak <mrv@mojatatu.com>,
netdev@vger.kernel.org
Subject: Re: [PATCH net-next] tc-testing: split config file
Date: Tue, 31 Oct 2017 22:41:23 -0400 [thread overview]
Message-ID: <CAEj_wPSVeSBeE=aemEtv-RUkgPDy8zgAz+f_i=W9dx7660XoBQ@mail.gmail.com> (raw)
In-Reply-To: <20171101.110623.348780136039045689.davem@davemloft.net>
On Tue, Oct 31, 2017 at 10:06 PM, David Miller <davem@davemloft.net> wrote:
> From: "Brenda J. Butler" <bjb@mojatatu.com>
> Date: Tue, 31 Oct 2017 14:27:28 -0400
>
>> Move the config customization into a site-local file
>> tdc_config_local.py, so that updates of the tdc test
...
>> Signed-off-by: Brenda J. Butler <bjb@mojatatu.com>
>
> Please always remove trailing empty lines in files, GIT even warns
> about this when one tries to apply the patch:
>
>> @@ -17,3 +17,17 @@ NAMES = {
>> # Name of the namespace to use
>> 'NS': 'tcut'
>> }
>> +
> ...
>> +# example adding values to ENVIR, without editing tdc_config.py
>> +ENVIR['VALGRIND_LIB'] = '/usr/lib/valgrind'
>> +ENVIR['VALGRIND_BIN'] = '/usr/bin/valgrind'
>> +ENVIR['VGDB_BIN'] = '/usr/bin/vgdb'
>> +
Thank you, I will make sure to that.
bjb
prev parent reply other threads:[~2017-11-01 2:41 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-31 18:27 [PATCH net-next] tc-testing: split config file Brenda J. Butler
2017-10-31 18:40 ` Lucas Bates
2017-11-01 2:06 ` David Miller
2017-11-01 2:41 ` Brenda Butler [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAEj_wPSVeSBeE=aemEtv-RUkgPDy8zgAz+f_i=W9dx7660XoBQ@mail.gmail.com' \
--to=bjb@mojatatu.com \
--cc=aring@mojatatu.com \
--cc=chrism@mellanox.com \
--cc=davem@davemloft.net \
--cc=jhs@mojatatu.com \
--cc=jiri@resnulli.us \
--cc=lucasb@mojatatu.com \
--cc=mrv@mojatatu.com \
--cc=netdev@vger.kernel.org \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).