* [PATCH net-next] selftests/bpf: remove useless bpf_trace_printk
@ 2017-10-29 0:17 Alexei Starovoitov
2017-11-01 3:06 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Alexei Starovoitov @ 2017-10-29 0:17 UTC (permalink / raw)
To: David S . Miller; +Cc: Daniel Borkmann, John Fastabend, netdev
sockmap test is using two programs that use bpf_trace_printk()
which prints into trace_pipe, but nothing is reading it.
Remove it.
Fixes: 6f6d33f3b3d0 ("bpf: selftests add sockmap tests")
Signed-off-by: Alexei Starovoitov <ast@kernel.org>
---
tools/testing/selftests/bpf/sockmap_parse_prog.c | 3 ---
tools/testing/selftests/bpf/sockmap_verdict_prog.c | 2 --
2 files changed, 5 deletions(-)
diff --git a/tools/testing/selftests/bpf/sockmap_parse_prog.c b/tools/testing/selftests/bpf/sockmap_parse_prog.c
index fae3b96c3aa4..a1dec2b6d9c5 100644
--- a/tools/testing/selftests/bpf/sockmap_parse_prog.c
+++ b/tools/testing/selftests/bpf/sockmap_parse_prog.c
@@ -29,9 +29,6 @@ int bpf_prog1(struct __sk_buff *skb)
* fields.
*/
d[7] = 1;
-
- bpf_printk("parse: data[0] = (%u): local_port %i remote %i\n",
- d[0], lport, bpf_ntohl(rport));
return skb->len;
}
diff --git a/tools/testing/selftests/bpf/sockmap_verdict_prog.c b/tools/testing/selftests/bpf/sockmap_verdict_prog.c
index 2cd2d552938b..d7bea972cb21 100644
--- a/tools/testing/selftests/bpf/sockmap_verdict_prog.c
+++ b/tools/testing/selftests/bpf/sockmap_verdict_prog.c
@@ -58,8 +58,6 @@ int bpf_prog2(struct __sk_buff *skb)
d[6] = 0xe;
d[7] = 0xf;
- bpf_printk("verdict: data[0] = redir(%u:%u)\n", map, sk);
-
if (!map)
return bpf_sk_redirect_map(skb, &sock_map_rx, sk, 0);
return bpf_sk_redirect_map(skb, &sock_map_tx, sk, 0);
--
2.9.5
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH net-next] selftests/bpf: remove useless bpf_trace_printk
2017-10-29 0:17 [PATCH net-next] selftests/bpf: remove useless bpf_trace_printk Alexei Starovoitov
@ 2017-11-01 3:06 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2017-11-01 3:06 UTC (permalink / raw)
To: ast; +Cc: daniel, john.fastabend, netdev
From: Alexei Starovoitov <ast@fb.com>
Date: Sat, 28 Oct 2017 17:17:13 -0700
> sockmap test is using two programs that use bpf_trace_printk()
> which prints into trace_pipe, but nothing is reading it.
> Remove it.
>
> Fixes: 6f6d33f3b3d0 ("bpf: selftests add sockmap tests")
> Signed-off-by: Alexei Starovoitov <ast@kernel.org>
Applied, thanks.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-11-01 3:07 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-10-29 0:17 [PATCH net-next] selftests/bpf: remove useless bpf_trace_printk Alexei Starovoitov
2017-11-01 3:06 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).