From: Stephen Hemminger <stephen@networkplumber.org>
To: Greg Greenway <ggreenway@apple.com>
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH iproute2] Add "show" subcommand to "ip fou"
Date: Thu, 16 Nov 2017 16:35:08 -0800 [thread overview]
Message-ID: <20171116163508.2f57d4e7@xeon-e3> (raw)
In-Reply-To: <9F9BDF85-1400-4CA0-A852-02EE02E7B64C@apple.com>
On Fri, 03 Nov 2017 10:19:22 -0700
Greg Greenway <ggreenway@apple.com> wrote:
> On Nov 1, 2017, at 2:03 PM, Stephen Hemminger <stephen@networkplumber.org> wrote:
> >
> > On Tue, 31 Oct 2017 13:00:47 -0700
> > Greg Greenway <ggreenway@apple.com> wrote:
> >
> >> + if (tb[FOU_ATTR_AF]) {
> >> + family = rta_getattr_u8(tb[FOU_ATTR_AF]);
> >> + if (family == AF_INET)
> >> + family_str = "AF_INET";
> >> + else if (family == AF_INET6)
> >> + family_str = "AF_INET6";
> >> + else
> >> + family_str = "unknown";
> >> + fprintf(fp, "af %s ", family_str);
> >
> > The unwritten rule for ip commands is that the show function
> > must format the output with same command syntax as the other commands set/add/delete.
> > Since there is no "af AF_INET" option to ip fou, this breaks that convention.
> > Either ignore the address family, change the add command, or output with same
> > syntax (-6); preferably the latter.
>
> That makes sense. Here's a corrected version. It also avoids a trailing-space in the output.
Yes, your followup looks correct but since it didn't follow the mailing list
patch protocol it was not picked up and managed by patchwork.
https://patchwork.ozlabs.org/patch/832717/
You need to post the patch as new patch (ie not a followup) with the "v2" designation
in order to get it correctly picked up and managed by patchwork.
prev parent reply other threads:[~2017-11-17 0:35 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-31 20:00 [PATCH iproute2] Add "show" subcommand to "ip fou" Greg Greenway
2017-11-01 21:03 ` Stephen Hemminger
2017-11-03 17:19 ` Greg Greenway
2017-11-03 17:25 ` Tom Herbert
2017-11-16 20:59 ` Greg Greenway
2017-11-17 0:35 ` Stephen Hemminger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171116163508.2f57d4e7@xeon-e3 \
--to=stephen@networkplumber.org \
--cc=ggreenway@apple.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).