netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [iproute2] ss: print tcpi_rcv_ssthresh
@ 2017-12-08  0:12 Wei Wang
  2017-12-08 18:30 ` Stephen Hemminger
  0 siblings, 1 reply; 2+ messages in thread
From: Wei Wang @ 2017-12-08  0:12 UTC (permalink / raw)
  To: netdev; +Cc: Eric Dumazet, Wei Wang

From: Wei Wang <weiwan@google.com>

tcpi_rcv_ssthresh is an important stats when debugging receive side
behavior.
Add it to the ss output.

Signed-off-by: Wei Wang <weiwan@google.com>
Signed-off-by: Eric Dumazet <edumazet@google.com>
---
 misc/ss.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/misc/ss.c b/misc/ss.c
index b5099d1e..90da93e3 100644
--- a/misc/ss.c
+++ b/misc/ss.c
@@ -751,6 +751,7 @@ struct tcpstat {
 	double		    rcv_rtt;
 	double		    min_rtt;
 	int		    rcv_space;
+	unsigned int        rcv_ssthresh;
 	unsigned long long  busy_time;
 	unsigned long long  rwnd_limited;
 	unsigned long long  sndbuf_limited;
@@ -2058,6 +2059,8 @@ static void tcp_stats_print(struct tcpstat *s)
 		printf(" rcv_rtt:%g", s->rcv_rtt);
 	if (s->rcv_space)
 		printf(" rcv_space:%d", s->rcv_space);
+	if (s->rcv_ssthresh)
+		printf(" rcv_ssthresh:%u", s->rcv_ssthresh);
 	if (s->not_sent)
 		printf(" notsent:%u", s->not_sent);
 	if (s->min_rtt)
@@ -2304,6 +2307,7 @@ static void tcp_show_info(const struct nlmsghdr *nlh, struct inet_diag_msg *r,
 		s.fackets	 = info->tcpi_fackets;
 		s.reordering	 = info->tcpi_reordering;
 		s.rcv_space	 = info->tcpi_rcv_space;
+		s.rcv_ssthresh   = info->tcpi_rcv_ssthresh;
 		s.cwnd		 = info->tcpi_snd_cwnd;
 
 		if (info->tcpi_snd_ssthresh < 0xFFFF)
-- 
2.15.1.424.g9478a66081-goog

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [iproute2] ss: print tcpi_rcv_ssthresh
  2017-12-08  0:12 [iproute2] ss: print tcpi_rcv_ssthresh Wei Wang
@ 2017-12-08 18:30 ` Stephen Hemminger
  0 siblings, 0 replies; 2+ messages in thread
From: Stephen Hemminger @ 2017-12-08 18:30 UTC (permalink / raw)
  To: Wei Wang; +Cc: netdev, Eric Dumazet, Wei Wang

On Thu,  7 Dec 2017 16:12:00 -0800
Wei Wang <tracywwnj@gmail.com> wrote:

> From: Wei Wang <weiwan@google.com>
> 
> tcpi_rcv_ssthresh is an important stats when debugging receive side
> behavior.
> Add it to the ss output.
> 
> Signed-off-by: Wei Wang <weiwan@google.com>
> Signed-off-by: Eric Dumazet <edumazet@google.com>

Applied

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2017-12-08 18:30 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-12-08  0:12 [iproute2] ss: print tcpi_rcv_ssthresh Wei Wang
2017-12-08 18:30 ` Stephen Hemminger

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).