From: Richard Leitner <dev@g0hl1n.net>
To: robh+dt@kernel.org, mark.rutland@arm.com, fugang.duan@nxp.com,
andrew@lunn.ch, f.fainelli@gmail.com, frowand.list@gmail.com
Cc: davem@davemloft.net, geert+renesas@glider.be,
sergei.shtylyov@cogentembedded.com, baruch@tkos.co.il,
david.wu@rock-chips.com, lukma@denx.de, netdev@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
richard.leitner@skidata.com
Subject: [PATCH net-next v5 3/4] net: phy: smsc: LAN8710/20: add PHY_RST_AFTER_CLK_EN flag
Date: Mon, 11 Dec 2017 13:16:59 +0100 [thread overview]
Message-ID: <20171211121700.10200-4-dev@g0hl1n.net> (raw)
In-Reply-To: <20171211121700.10200-1-dev@g0hl1n.net>
From: Richard Leitner <richard.leitner@skidata.com>
The Microchip/SMSC LAN8710/LAN8720 PHYs need (according to their
datasheet [1]) a continuous REF_CLK when configured to "REF_CLK In Mode".
Therefore set the PHY_RST_AFTER_CLK_EN flag for those PHYs to let the
ETH driver reset them after the REF_CLK is enabled.
[1] http://ww1.microchip.com/downloads/en/DeviceDoc/00002165B.pdf
Signed-off-by: Richard Leitner <richard.leitner@skidata.com>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
---
drivers/net/phy/smsc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/phy/smsc.c b/drivers/net/phy/smsc.c
index a1961ba87e2b..be399d645224 100644
--- a/drivers/net/phy/smsc.c
+++ b/drivers/net/phy/smsc.c
@@ -312,7 +312,7 @@ static struct phy_driver smsc_phy_driver[] = {
.name = "SMSC LAN8710/LAN8720",
.features = PHY_BASIC_FEATURES,
- .flags = PHY_HAS_INTERRUPT,
+ .flags = PHY_HAS_INTERRUPT | PHY_RST_AFTER_CLK_EN,
.probe = smsc_phy_probe,
--
2.11.0
next prev parent reply other threads:[~2017-12-11 12:17 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-11 12:16 [PATCH net-next v5 0/4] net: fec: fix refclk enable for SMSC LAN8710/20 Richard Leitner
2017-12-11 12:16 ` [PATCH net-next v5 1/4] phylib: Add device reset delay support Richard Leitner
2017-12-11 13:40 ` Andrew Lunn
2017-12-15 22:17 ` Rob Herring
2017-12-18 7:30 ` Richard Leitner
[not found] ` <1b230e6b-8e8c-28a4-7524-6ce60aa71591-WcANXNA0UjBBDgjK7y7TUQ@public.gmane.org>
2017-12-19 17:12 ` Rob Herring
2017-12-11 12:16 ` [PATCH net-next v5 2/4] phylib: add reset after clk enable support Richard Leitner
2017-12-11 12:16 ` Richard Leitner [this message]
2017-12-11 12:17 ` [PATCH net-next v5 4/4] net: fec: add phy_reset_after_clk_enable() support Richard Leitner
[not found] ` <20171211121700.10200-1-dev-M/VWbR8SM2SsTnJN9+BGXg@public.gmane.org>
2017-12-13 2:21 ` [PATCH net-next v5 0/4] net: fec: fix refclk enable for SMSC LAN8710/20 Andy Duan
2017-12-13 16:23 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171211121700.10200-4-dev@g0hl1n.net \
--to=dev@g0hl1n.net \
--cc=andrew@lunn.ch \
--cc=baruch@tkos.co.il \
--cc=davem@davemloft.net \
--cc=david.wu@rock-chips.com \
--cc=devicetree@vger.kernel.org \
--cc=f.fainelli@gmail.com \
--cc=frowand.list@gmail.com \
--cc=fugang.duan@nxp.com \
--cc=geert+renesas@glider.be \
--cc=linux-kernel@vger.kernel.org \
--cc=lukma@denx.de \
--cc=mark.rutland@arm.com \
--cc=netdev@vger.kernel.org \
--cc=richard.leitner@skidata.com \
--cc=robh+dt@kernel.org \
--cc=sergei.shtylyov@cogentembedded.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).