From: Rob Herring <robh@kernel.org>
To: Richard Leitner <dev@g0hl1n.net>
Cc: mark.rutland@arm.com, fugang.duan@nxp.com, andrew@lunn.ch,
f.fainelli@gmail.com, frowand.list@gmail.com,
davem@davemloft.net, geert+renesas@glider.be,
sergei.shtylyov@cogentembedded.com, baruch@tkos.co.il,
david.wu@rock-chips.com, lukma@denx.de, netdev@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
richard.leitner@skidata.com
Subject: Re: [PATCH net-next v5 1/4] phylib: Add device reset delay support
Date: Fri, 15 Dec 2017 16:17:52 -0600 [thread overview]
Message-ID: <20171215221752.42sz53izxeebkfuq@rob-hp-laptop> (raw)
In-Reply-To: <20171211121700.10200-2-dev@g0hl1n.net>
On Mon, Dec 11, 2017 at 01:16:57PM +0100, Richard Leitner wrote:
> From: Richard Leitner <richard.leitner@skidata.com>
>
> Some PHYs need a minimum time after the reset gpio was asserted and/or
> deasserted. To ensure we meet these timing requirements add two new
> optional devicetree parameters for the phy: reset-delay-us and
> reset-post-delay-us.
>
> Signed-off-by: Richard Leitner <richard.leitner@skidata.com>
> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---
> Documentation/devicetree/bindings/net/phy.txt | 10 ++++++++++
> drivers/net/phy/mdio_device.c | 13 +++++++++++--
> drivers/of/of_mdio.c | 4 ++++
> include/linux/mdio.h | 2 ++
> 4 files changed, 27 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/net/phy.txt b/Documentation/devicetree/bindings/net/phy.txt
> index c05479f5ac7c..72860ce7f610 100644
> --- a/Documentation/devicetree/bindings/net/phy.txt
> +++ b/Documentation/devicetree/bindings/net/phy.txt
> @@ -55,6 +55,12 @@ Optional Properties:
>
> - reset-gpios: The GPIO phandle and specifier for the PHY reset signal.
>
> +- reset-delay-us: Delay after the reset was asserted in microseconds.
> + If this property is missing the delay will be skipped.
> +
> +- reset-post-delay-us: Delay after the reset was deasserted in microseconds.
> + If this property is missing the delay will be skipped.
I think these names could be clearer as to exactly what they mean.
Looking at existing properties with "reset-delay" there's a mixture of
definitions whether it is the assert time or the time after deassert.
So I'd call these "reset-assert-us" and "reset-deassert-us".
Rob
next prev parent reply other threads:[~2017-12-15 22:17 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-11 12:16 [PATCH net-next v5 0/4] net: fec: fix refclk enable for SMSC LAN8710/20 Richard Leitner
2017-12-11 12:16 ` [PATCH net-next v5 1/4] phylib: Add device reset delay support Richard Leitner
2017-12-11 13:40 ` Andrew Lunn
2017-12-15 22:17 ` Rob Herring [this message]
2017-12-18 7:30 ` Richard Leitner
[not found] ` <1b230e6b-8e8c-28a4-7524-6ce60aa71591-WcANXNA0UjBBDgjK7y7TUQ@public.gmane.org>
2017-12-19 17:12 ` Rob Herring
2017-12-11 12:16 ` [PATCH net-next v5 2/4] phylib: add reset after clk enable support Richard Leitner
2017-12-11 12:16 ` [PATCH net-next v5 3/4] net: phy: smsc: LAN8710/20: add PHY_RST_AFTER_CLK_EN flag Richard Leitner
2017-12-11 12:17 ` [PATCH net-next v5 4/4] net: fec: add phy_reset_after_clk_enable() support Richard Leitner
[not found] ` <20171211121700.10200-1-dev-M/VWbR8SM2SsTnJN9+BGXg@public.gmane.org>
2017-12-13 2:21 ` [PATCH net-next v5 0/4] net: fec: fix refclk enable for SMSC LAN8710/20 Andy Duan
2017-12-13 16:23 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171215221752.42sz53izxeebkfuq@rob-hp-laptop \
--to=robh@kernel.org \
--cc=andrew@lunn.ch \
--cc=baruch@tkos.co.il \
--cc=davem@davemloft.net \
--cc=david.wu@rock-chips.com \
--cc=dev@g0hl1n.net \
--cc=devicetree@vger.kernel.org \
--cc=f.fainelli@gmail.com \
--cc=frowand.list@gmail.com \
--cc=fugang.duan@nxp.com \
--cc=geert+renesas@glider.be \
--cc=linux-kernel@vger.kernel.org \
--cc=lukma@denx.de \
--cc=mark.rutland@arm.com \
--cc=netdev@vger.kernel.org \
--cc=richard.leitner@skidata.com \
--cc=sergei.shtylyov@cogentembedded.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).