* [PATCH net, v3] of_mdio: avoid MDIO bus removal when a PHY is missing
@ 2018-01-09 12:43 Madalin Bucur
2018-01-09 13:58 ` Andrew Lunn
[not found] ` <1515501814-11517-1-git-send-email-madalin.bucur-3arQi8VN3Tc@public.gmane.org>
0 siblings, 2 replies; 3+ messages in thread
From: Madalin Bucur @ 2018-01-09 12:43 UTC (permalink / raw)
To: andrew-g2DYL2Zd6BY, f.fainelli-Re5JQEeQqe8AvxtiuMwx3w,
davem-fT/PcQaiUtIeIZ0/mPfg9Q
Cc: geert+renesas-gXvu3+zWzMSzQB+pC5nmwQ,
robh+dt-DgEjT+Ai2ygdnm+yROfE0A,
frowand.list-Re5JQEeQqe8AvxtiuMwx3w,
netdev-u79uwXL29TY76Z2rM5mHXA, devicetree-u79uwXL29TY76Z2rM5mHXA,
linux-kernel-u79uwXL29TY76Z2rM5mHXA, Madalin Bucur
If one of the child devices is missing the of_mdiobus_register_phy()
call will return -ENODEV. When a missing device is encountered the
registration of the remaining PHYs is stopped and the MDIO bus will
fail to register. Propagate all errors except ENODEV to avoid it.
Signed-off-by: Madalin Bucur <madalin.bucur-3arQi8VN3Tc@public.gmane.org>
---
v3: move if after else
v2: add an error print for the first change; the second place has
some noise already generated by the existing code
drivers/of/of_mdio.c | 9 +++++++--
1 file changed, 7 insertions(+), 2 deletions(-)
diff --git a/drivers/of/of_mdio.c b/drivers/of/of_mdio.c
index 3481e69..a327be1 100644
--- a/drivers/of/of_mdio.c
+++ b/drivers/of/of_mdio.c
@@ -231,7 +231,12 @@ int of_mdiobus_register(struct mii_bus *mdio, struct device_node *np)
rc = of_mdiobus_register_phy(mdio, child, addr);
else
rc = of_mdiobus_register_device(mdio, child, addr);
- if (rc)
+
+ if (rc == -ENODEV)
+ dev_err(&mdio->dev,
+ "MDIO device at address %d is missing.\n",
+ addr);
+ else if (rc)
goto unregister;
}
@@ -255,7 +260,7 @@ int of_mdiobus_register(struct mii_bus *mdio, struct device_node *np)
if (of_mdiobus_child_is_phy(child)) {
rc = of_mdiobus_register_phy(mdio, child, addr);
- if (rc)
+ if (rc && rc != -ENODEV)
goto unregister;
}
}
--
2.1.0
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH net, v3] of_mdio: avoid MDIO bus removal when a PHY is missing
2018-01-09 12:43 [PATCH net, v3] of_mdio: avoid MDIO bus removal when a PHY is missing Madalin Bucur
@ 2018-01-09 13:58 ` Andrew Lunn
[not found] ` <1515501814-11517-1-git-send-email-madalin.bucur-3arQi8VN3Tc@public.gmane.org>
1 sibling, 0 replies; 3+ messages in thread
From: Andrew Lunn @ 2018-01-09 13:58 UTC (permalink / raw)
To: Madalin Bucur
Cc: f.fainelli, davem, geert+renesas, robh+dt, frowand.list, netdev,
devicetree, linux-kernel
On Tue, Jan 09, 2018 at 02:43:34PM +0200, Madalin Bucur wrote:
> If one of the child devices is missing the of_mdiobus_register_phy()
> call will return -ENODEV. When a missing device is encountered the
> registration of the remaining PHYs is stopped and the MDIO bus will
> fail to register. Propagate all errors except ENODEV to avoid it.
>
> Signed-off-by: Madalin Bucur <madalin.bucur@nxp.com>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Andrew
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH net, v3] of_mdio: avoid MDIO bus removal when a PHY is missing
[not found] ` <1515501814-11517-1-git-send-email-madalin.bucur-3arQi8VN3Tc@public.gmane.org>
@ 2018-01-10 20:08 ` David Miller
0 siblings, 0 replies; 3+ messages in thread
From: David Miller @ 2018-01-10 20:08 UTC (permalink / raw)
To: madalin.bucur-3arQi8VN3Tc
Cc: andrew-g2DYL2Zd6BY, f.fainelli-Re5JQEeQqe8AvxtiuMwx3w,
geert+renesas-gXvu3+zWzMSzQB+pC5nmwQ,
robh+dt-DgEjT+Ai2ygdnm+yROfE0A,
frowand.list-Re5JQEeQqe8AvxtiuMwx3w,
netdev-u79uwXL29TY76Z2rM5mHXA, devicetree-u79uwXL29TY76Z2rM5mHXA,
linux-kernel-u79uwXL29TY76Z2rM5mHXA
From: Madalin Bucur <madalin.bucur-3arQi8VN3Tc@public.gmane.org>
Date: Tue, 9 Jan 2018 14:43:34 +0200
> If one of the child devices is missing the of_mdiobus_register_phy()
> call will return -ENODEV. When a missing device is encountered the
> registration of the remaining PHYs is stopped and the MDIO bus will
> fail to register. Propagate all errors except ENODEV to avoid it.
>
> Signed-off-by: Madalin Bucur <madalin.bucur-3arQi8VN3Tc@public.gmane.org>
Applied.
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-01-10 20:08 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-01-09 12:43 [PATCH net, v3] of_mdio: avoid MDIO bus removal when a PHY is missing Madalin Bucur
2018-01-09 13:58 ` Andrew Lunn
[not found] ` <1515501814-11517-1-git-send-email-madalin.bucur-3arQi8VN3Tc@public.gmane.org>
2018-01-10 20:08 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).