* [PATCH net v2] ipv6: sr: fix TLVs not being copied using setsockopt
@ 2018-01-10 13:35 Mathieu Xhonneux
2018-01-10 21:04 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Mathieu Xhonneux @ 2018-01-10 13:35 UTC (permalink / raw)
To: netdev; +Cc: dlebrun, m.xhonneux
Function ipv6_push_rthdr4 allows to add an IPv6 Segment Routing Header
to a socket through setsockopt, but the current implementation doesn't
copy possible TLVs at the end of the SRH received from userspace.
Therefore, the execution of the following branch if (sr_has_hmac(sr_phdr))
{ ... } will never complete since the len and type fields of a possible
HMAC TLV are not copied, hence seg6_get_tlv_hmac will return an error,
and the HMAC will not be computed.
This commit adds a memcpy in case TLVs have been appended to the SRH.
Fixes: a149e7c7ce812561f0fdc7a86ddc42f294e5eb3e ("ipv6: sr: add
support for SRH injection through setsockopt")
Acked-by: David Lebrun <dlebrun@google.com>
Signed-off-by: Mathieu Xhonneux <m.xhonneux@gmail.com>
---
net/ipv6/exthdrs.c | 9 +++++++++
1 file changed, 9 insertions(+)
diff --git a/net/ipv6/exthdrs.c b/net/ipv6/exthdrs.c
index 83bd75713535..bc68eb661970 100644
--- a/net/ipv6/exthdrs.c
+++ b/net/ipv6/exthdrs.c
@@ -925,6 +925,15 @@ static void ipv6_push_rthdr4(struct sk_buff *skb, u8 *proto,
sr_phdr->segments[0] = **addr_p;
*addr_p = &sr_ihdr->segments[sr_ihdr->segments_left];
+ if (sr_ihdr->hdrlen > hops * 2) {
+ int tlvs_offset, tlvs_length;
+
+ tlvs_offset = (1 + hops * 2) << 3;
+ tlvs_length = (sr_ihdr->hdrlen - hops * 2) << 3;
+ memcpy((char *)sr_phdr + tlvs_offset,
+ (char *)sr_ihdr + tlvs_offset, tlvs_length);
+ }
+
#ifdef CONFIG_IPV6_SEG6_HMAC
if (sr_has_hmac(sr_phdr)) {
struct net *net = NULL;
--
2.15.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH net v2] ipv6: sr: fix TLVs not being copied using setsockopt
2018-01-10 13:35 [PATCH net v2] ipv6: sr: fix TLVs not being copied using setsockopt Mathieu Xhonneux
@ 2018-01-10 21:04 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2018-01-10 21:04 UTC (permalink / raw)
To: m.xhonneux; +Cc: netdev, dlebrun
From: Mathieu Xhonneux <m.xhonneux@gmail.com>
Date: Wed, 10 Jan 2018 13:35:49 +0000
> Function ipv6_push_rthdr4 allows to add an IPv6 Segment Routing Header
> to a socket through setsockopt, but the current implementation doesn't
> copy possible TLVs at the end of the SRH received from userspace.
>
> Therefore, the execution of the following branch if (sr_has_hmac(sr_phdr))
> { ... } will never complete since the len and type fields of a possible
> HMAC TLV are not copied, hence seg6_get_tlv_hmac will return an error,
> and the HMAC will not be computed.
>
> This commit adds a memcpy in case TLVs have been appended to the SRH.
>
> Fixes: a149e7c7ce812561f0fdc7a86ddc42f294e5eb3e ("ipv6: sr: add
> support for SRH injection through setsockopt")
Please do not break up long Fixes: lines. Also, you should only
provide 12 digits of the SHA1 ID.
> Acked-by: David Lebrun <dlebrun@google.com>
> Signed-off-by: Mathieu Xhonneux <m.xhonneux@gmail.com>
Applied, thanks.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-01-10 21:04 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-01-10 13:35 [PATCH net v2] ipv6: sr: fix TLVs not being copied using setsockopt Mathieu Xhonneux
2018-01-10 21:04 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).