* [PATCH] net: ethernet: cavium: Correct Cacivum Thunderx nicvf/nicpf modules names
@ 2018-01-18 15:42 Vadim Lomovtsev
2018-01-18 15:49 ` Vadim Lomovtsev
2018-01-18 15:53 ` [PATCH v2] net: ethernet: cavium: Correct Cavium " Vadim Lomovtsev
0 siblings, 2 replies; 9+ messages in thread
From: Vadim Lomovtsev @ 2018-01-18 15:42 UTC (permalink / raw)
To: sgoutham, rric, linux-arm-kernel, netdev, linux-kernel
Cc: Vadim Lomovtsev, Dean Nelson
From: Vadim Lomovtsev <Vadim.Lomovtsev@cavium.com>
It was found that ethtool provides unexisting module name while
it queries the specified network device for associated driver
information.
This patch is to correct Cavium CN88xx Thunder nicvf/nicpf modules
names 'nicvf' to 'thunder_nicvf' and 'nicpf' to 'thunder_nicpf'.
Signed-off-by: Dean Nelson <dnelson@redhat.com>
Signed-off-by: Vadim Lomovtsev <Vadim.Lomovtsev@cavium.com>
---
drivers/net/ethernet/cavium/thunder/Makefile | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/net/ethernet/cavium/thunder/Makefile b/drivers/net/ethernet/cavium/thunder/Makefile
index 6b4d4add7353..f5642337d0fe 100644
--- a/drivers/net/ethernet/cavium/thunder/Makefile
+++ b/drivers/net/ethernet/cavium/thunder/Makefile
@@ -4,9 +4,9 @@
obj-$(CONFIG_THUNDER_NIC_RGX) += thunder_xcv.o
obj-$(CONFIG_THUNDER_NIC_BGX) += thunder_bgx.o
-obj-$(CONFIG_THUNDER_NIC_PF) += nicpf.o
-obj-$(CONFIG_THUNDER_NIC_VF) += nicvf.o
+obj-$(CONFIG_THUNDER_NIC_PF) += thunder_nicpf.o
+obj-$(CONFIG_THUNDER_NIC_VF) += thunder_nicvf.o
-nicpf-y := nic_main.o
-nicvf-y := nicvf_main.o nicvf_queues.o
-nicvf-y += nicvf_ethtool.o
+thunder_nicpf-y := nic_main.o
+thunder_nicvf-y := nicvf_main.o nicvf_queues.o
+thunder_nicvf-y += nicvf_ethtool.o
--
2.14.3
^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [PATCH] net: ethernet: cavium: Correct Cacivum Thunderx nicvf/nicpf modules names
2018-01-18 15:42 [PATCH] net: ethernet: cavium: Correct Cacivum Thunderx nicvf/nicpf modules names Vadim Lomovtsev
@ 2018-01-18 15:49 ` Vadim Lomovtsev
2018-01-18 15:53 ` [PATCH v2] net: ethernet: cavium: Correct Cavium " Vadim Lomovtsev
1 sibling, 0 replies; 9+ messages in thread
From: Vadim Lomovtsev @ 2018-01-18 15:49 UTC (permalink / raw)
To: sgoutham, rric, linux-arm-kernel, netdev, linux-kernel
Cc: Vadim Lomovtsev, Dean Nelson
Self NACK to this one, subject line typo, sorry.
Vadim
On Thu, Jan 18, 2018 at 07:42:40AM -0800, Vadim Lomovtsev wrote:
> From: Vadim Lomovtsev <Vadim.Lomovtsev@cavium.com>
>
> It was found that ethtool provides unexisting module name while
> it queries the specified network device for associated driver
> information.
>
> This patch is to correct Cavium CN88xx Thunder nicvf/nicpf modules
> names 'nicvf' to 'thunder_nicvf' and 'nicpf' to 'thunder_nicpf'.
>
> Signed-off-by: Dean Nelson <dnelson@redhat.com>
> Signed-off-by: Vadim Lomovtsev <Vadim.Lomovtsev@cavium.com>
> ---
> drivers/net/ethernet/cavium/thunder/Makefile | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/net/ethernet/cavium/thunder/Makefile b/drivers/net/ethernet/cavium/thunder/Makefile
> index 6b4d4add7353..f5642337d0fe 100644
> --- a/drivers/net/ethernet/cavium/thunder/Makefile
> +++ b/drivers/net/ethernet/cavium/thunder/Makefile
> @@ -4,9 +4,9 @@
>
> obj-$(CONFIG_THUNDER_NIC_RGX) += thunder_xcv.o
> obj-$(CONFIG_THUNDER_NIC_BGX) += thunder_bgx.o
> -obj-$(CONFIG_THUNDER_NIC_PF) += nicpf.o
> -obj-$(CONFIG_THUNDER_NIC_VF) += nicvf.o
> +obj-$(CONFIG_THUNDER_NIC_PF) += thunder_nicpf.o
> +obj-$(CONFIG_THUNDER_NIC_VF) += thunder_nicvf.o
>
> -nicpf-y := nic_main.o
> -nicvf-y := nicvf_main.o nicvf_queues.o
> -nicvf-y += nicvf_ethtool.o
> +thunder_nicpf-y := nic_main.o
> +thunder_nicvf-y := nicvf_main.o nicvf_queues.o
> +thunder_nicvf-y += nicvf_ethtool.o
> --
> 2.14.3
>
^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH v2] net: ethernet: cavium: Correct Cavium Thunderx nicvf/nicpf modules names
2018-01-18 15:42 [PATCH] net: ethernet: cavium: Correct Cacivum Thunderx nicvf/nicpf modules names Vadim Lomovtsev
2018-01-18 15:49 ` Vadim Lomovtsev
@ 2018-01-18 15:53 ` Vadim Lomovtsev
2018-01-18 18:18 ` Vadim Lomovtsev
2018-01-22 14:13 ` [PATCH v3] net: ethernet: cavium: Correct Cavium Thunderx NIC module and driver names Vadim Lomovtsev
1 sibling, 2 replies; 9+ messages in thread
From: Vadim Lomovtsev @ 2018-01-18 15:53 UTC (permalink / raw)
To: sgoutham, rric, linux-arm-kernel, netdev, linux-kernel
Cc: Vadim Lomovtsev, Dean Nelson
From: Vadim Lomovtsev <Vadim.Lomovtsev@cavium.com>
It was found that ethtool provides unexisting module name while
it queries the specified network device for associated driver
information.
This patch is to correct Cavium CN88xx Thunder nicvf/nicpf modules
names 'nicvf' to 'thunder_nicvf' and 'nicpf' to 'thunder_nicpf'.
Signed-off-by: Dean Nelson <dnelson@redhat.com>
Signed-off-by: Vadim Lomovtsev <Vadim.Lomovtsev@cavium.com>
---
drivers/net/ethernet/cavium/thunder/Makefile | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/net/ethernet/cavium/thunder/Makefile b/drivers/net/ethernet/cavium/thunder/Makefile
index 6b4d4add7353..f5642337d0fe 100644
--- a/drivers/net/ethernet/cavium/thunder/Makefile
+++ b/drivers/net/ethernet/cavium/thunder/Makefile
@@ -4,9 +4,9 @@
obj-$(CONFIG_THUNDER_NIC_RGX) += thunder_xcv.o
obj-$(CONFIG_THUNDER_NIC_BGX) += thunder_bgx.o
-obj-$(CONFIG_THUNDER_NIC_PF) += nicpf.o
-obj-$(CONFIG_THUNDER_NIC_VF) += nicvf.o
+obj-$(CONFIG_THUNDER_NIC_PF) += thunder_nicpf.o
+obj-$(CONFIG_THUNDER_NIC_VF) += thunder_nicvf.o
-nicpf-y := nic_main.o
-nicvf-y := nicvf_main.o nicvf_queues.o
-nicvf-y += nicvf_ethtool.o
+thunder_nicpf-y := nic_main.o
+thunder_nicvf-y := nicvf_main.o nicvf_queues.o
+thunder_nicvf-y += nicvf_ethtool.o
--
2.14.3
^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [PATCH v2] net: ethernet: cavium: Correct Cavium Thunderx nicvf/nicpf modules names
2018-01-18 15:53 ` [PATCH v2] net: ethernet: cavium: Correct Cavium " Vadim Lomovtsev
@ 2018-01-18 18:18 ` Vadim Lomovtsev
2018-01-22 14:13 ` [PATCH v3] net: ethernet: cavium: Correct Cavium Thunderx NIC module and driver names Vadim Lomovtsev
1 sibling, 0 replies; 9+ messages in thread
From: Vadim Lomovtsev @ 2018-01-18 18:18 UTC (permalink / raw)
To: sgoutham, rric, linux-arm-kernel, netdev, linux-kernel
Cc: Vadim Lomovtsev, Dean Nelson
Self NACK here: modules names has to contain dashes instead
of underscores, as it defined at sources (or update modules
DRV_NAME definitions whithin the source files with underscores).
Shame on me.
Vadim
On Thu, Jan 18, 2018 at 07:53:09AM -0800, Vadim Lomovtsev wrote:
> From: Vadim Lomovtsev <Vadim.Lomovtsev@cavium.com>
>
> It was found that ethtool provides unexisting module name while
> it queries the specified network device for associated driver
> information.
>
> This patch is to correct Cavium CN88xx Thunder nicvf/nicpf modules
> names 'nicvf' to 'thunder_nicvf' and 'nicpf' to 'thunder_nicpf'.
>
> Signed-off-by: Dean Nelson <dnelson@redhat.com>
> Signed-off-by: Vadim Lomovtsev <Vadim.Lomovtsev@cavium.com>
> ---
> drivers/net/ethernet/cavium/thunder/Makefile | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/net/ethernet/cavium/thunder/Makefile b/drivers/net/ethernet/cavium/thunder/Makefile
> index 6b4d4add7353..f5642337d0fe 100644
> --- a/drivers/net/ethernet/cavium/thunder/Makefile
> +++ b/drivers/net/ethernet/cavium/thunder/Makefile
> @@ -4,9 +4,9 @@
>
> obj-$(CONFIG_THUNDER_NIC_RGX) += thunder_xcv.o
> obj-$(CONFIG_THUNDER_NIC_BGX) += thunder_bgx.o
> -obj-$(CONFIG_THUNDER_NIC_PF) += nicpf.o
> -obj-$(CONFIG_THUNDER_NIC_VF) += nicvf.o
> +obj-$(CONFIG_THUNDER_NIC_PF) += thunder_nicpf.o
> +obj-$(CONFIG_THUNDER_NIC_VF) += thunder_nicvf.o
>
> -nicpf-y := nic_main.o
> -nicvf-y := nicvf_main.o nicvf_queues.o
> -nicvf-y += nicvf_ethtool.o
> +thunder_nicpf-y := nic_main.o
> +thunder_nicvf-y := nicvf_main.o nicvf_queues.o
> +thunder_nicvf-y += nicvf_ethtool.o
> --
> 2.14.3
>
^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH v3] net: ethernet: cavium: Correct Cavium Thunderx NIC module and driver names
2018-01-18 15:53 ` [PATCH v2] net: ethernet: cavium: Correct Cavium " Vadim Lomovtsev
2018-01-18 18:18 ` Vadim Lomovtsev
@ 2018-01-22 14:13 ` Vadim Lomovtsev
2018-01-24 21:27 ` David Miller
2018-01-25 11:38 ` [PATCH v4] net: ethernet: cavium: Correct Cavium Thunderx NIC driver names accordingly to module name Vadim Lomovtsev
1 sibling, 2 replies; 9+ messages in thread
From: Vadim Lomovtsev @ 2018-01-22 14:13 UTC (permalink / raw)
To: sgoutham, rric, linux-arm-kernel, netdev, linux-kernel
Cc: Vadim Lomovtsev, Dean Nelson
From: Vadim Lomovtsev <Vadim.Lomovtsev@cavium.com>
It was found that ethtool provides unexisting module name while
it queries the specified network device for associated driver
information. Then user tries to unload that module by provided
module name and fails.
This happens because ethtool reads value of DRV_NAME macro,
while module name is defined at the driver's Makefile.
This patch is to correct Cavium CN88xx Thunder NIC driver modules
names 'nicvf' to 'thunder_nicvf' and 'nicpf' to 'thunder_nicpf' along
with updating DRV_NAME macro values accordingly.
Signed-off-by: Dean Nelson <dnelson@redhat.com>
Signed-off-by: Vadim Lomovtsev <Vadim.Lomovtsev@cavium.com>
---
drivers/net/ethernet/cavium/thunder/Makefile | 10 +++++-----
drivers/net/ethernet/cavium/thunder/nic_main.c | 2 +-
drivers/net/ethernet/cavium/thunder/nicvf_ethtool.c | 2 +-
drivers/net/ethernet/cavium/thunder/nicvf_main.c | 2 +-
drivers/net/ethernet/cavium/thunder/thunder_bgx.c | 2 +-
drivers/net/ethernet/cavium/thunder/thunder_xcv.c | 2 +-
6 files changed, 10 insertions(+), 10 deletions(-)
diff --git a/drivers/net/ethernet/cavium/thunder/Makefile b/drivers/net/ethernet/cavium/thunder/Makefile
index 6b4d4add7353..f5642337d0fe 100644
--- a/drivers/net/ethernet/cavium/thunder/Makefile
+++ b/drivers/net/ethernet/cavium/thunder/Makefile
@@ -4,9 +4,9 @@
obj-$(CONFIG_THUNDER_NIC_RGX) += thunder_xcv.o
obj-$(CONFIG_THUNDER_NIC_BGX) += thunder_bgx.o
-obj-$(CONFIG_THUNDER_NIC_PF) += nicpf.o
-obj-$(CONFIG_THUNDER_NIC_VF) += nicvf.o
+obj-$(CONFIG_THUNDER_NIC_PF) += thunder_nicpf.o
+obj-$(CONFIG_THUNDER_NIC_VF) += thunder_nicvf.o
-nicpf-y := nic_main.o
-nicvf-y := nicvf_main.o nicvf_queues.o
-nicvf-y += nicvf_ethtool.o
+thunder_nicpf-y := nic_main.o
+thunder_nicvf-y := nicvf_main.o nicvf_queues.o
+thunder_nicvf-y += nicvf_ethtool.o
diff --git a/drivers/net/ethernet/cavium/thunder/nic_main.c b/drivers/net/ethernet/cavium/thunder/nic_main.c
index 8f1dd55b3e08..a8c0d2bde9c8 100644
--- a/drivers/net/ethernet/cavium/thunder/nic_main.c
+++ b/drivers/net/ethernet/cavium/thunder/nic_main.c
@@ -18,7 +18,7 @@
#include "q_struct.h"
#include "thunder_bgx.h"
-#define DRV_NAME "thunder-nic"
+#define DRV_NAME "thunder_nicpf"
#define DRV_VERSION "1.0"
struct hw_info {
diff --git a/drivers/net/ethernet/cavium/thunder/nicvf_ethtool.c b/drivers/net/ethernet/cavium/thunder/nicvf_ethtool.c
index b9ece9cbf98b..8a3e3b70afda 100644
--- a/drivers/net/ethernet/cavium/thunder/nicvf_ethtool.c
+++ b/drivers/net/ethernet/cavium/thunder/nicvf_ethtool.c
@@ -16,7 +16,7 @@
#include "q_struct.h"
#include "thunder_bgx.h"
-#define DRV_NAME "thunder-nicvf"
+#define DRV_NAME "thunder_nicvf"
#define DRV_VERSION "1.0"
struct nicvf_stat {
diff --git a/drivers/net/ethernet/cavium/thunder/nicvf_main.c b/drivers/net/ethernet/cavium/thunder/nicvf_main.c
index 7cb7571f9ad9..de38105fc649 100644
--- a/drivers/net/ethernet/cavium/thunder/nicvf_main.c
+++ b/drivers/net/ethernet/cavium/thunder/nicvf_main.c
@@ -26,7 +26,7 @@
#include "nicvf_queues.h"
#include "thunder_bgx.h"
-#define DRV_NAME "thunder-nicvf"
+#define DRV_NAME "thunder_nicvf"
#define DRV_VERSION "1.0"
/* Supported devices */
diff --git a/drivers/net/ethernet/cavium/thunder/thunder_bgx.c b/drivers/net/ethernet/cavium/thunder/thunder_bgx.c
index 5e5c4d7796b8..79fae7de3404 100644
--- a/drivers/net/ethernet/cavium/thunder/thunder_bgx.c
+++ b/drivers/net/ethernet/cavium/thunder/thunder_bgx.c
@@ -21,7 +21,7 @@
#include "nic.h"
#include "thunder_bgx.h"
-#define DRV_NAME "thunder-BGX"
+#define DRV_NAME "thunder_bgx"
#define DRV_VERSION "1.0"
struct lmac {
diff --git a/drivers/net/ethernet/cavium/thunder/thunder_xcv.c b/drivers/net/ethernet/cavium/thunder/thunder_xcv.c
index 578c7f8f11bf..2d5e8dab1f70 100644
--- a/drivers/net/ethernet/cavium/thunder/thunder_xcv.c
+++ b/drivers/net/ethernet/cavium/thunder/thunder_xcv.c
@@ -20,7 +20,7 @@
#include "nic.h"
#include "thunder_bgx.h"
-#define DRV_NAME "thunder-xcv"
+#define DRV_NAME "thunder_xcv"
#define DRV_VERSION "1.0"
/* Register offsets */
--
2.14.3
^ permalink raw reply related [flat|nested] 9+ messages in thread* Re: [PATCH v3] net: ethernet: cavium: Correct Cavium Thunderx NIC module and driver names
2018-01-22 14:13 ` [PATCH v3] net: ethernet: cavium: Correct Cavium Thunderx NIC module and driver names Vadim Lomovtsev
@ 2018-01-24 21:27 ` David Miller
2018-01-25 11:11 ` Vadim Lomovtsev
2018-01-25 11:38 ` [PATCH v4] net: ethernet: cavium: Correct Cavium Thunderx NIC driver names accordingly to module name Vadim Lomovtsev
1 sibling, 1 reply; 9+ messages in thread
From: David Miller @ 2018-01-24 21:27 UTC (permalink / raw)
To: Vadim.Lomovtsev
Cc: sgoutham, rric, linux-arm-kernel, netdev, linux-kernel,
Vadim.Lomovtsev, dnelson
From: Vadim Lomovtsev <Vadim.Lomovtsev@caviumnetworks.com>
Date: Mon, 22 Jan 2018 06:13:27 -0800
> From: Vadim Lomovtsev <Vadim.Lomovtsev@cavium.com>
>
> It was found that ethtool provides unexisting module name while
> it queries the specified network device for associated driver
> information. Then user tries to unload that module by provided
> module name and fails.
>
> This happens because ethtool reads value of DRV_NAME macro,
> while module name is defined at the driver's Makefile.
>
> This patch is to correct Cavium CN88xx Thunder NIC driver modules
> names 'nicvf' to 'thunder_nicvf' and 'nicpf' to 'thunder_nicpf' along
> with updating DRV_NAME macro values accordingly.
>
> Signed-off-by: Dean Nelson <dnelson@redhat.com>
> Signed-off-by: Vadim Lomovtsev <Vadim.Lomovtsev@cavium.com>
Once your driver has been deployed in a real upstream release you
should never change the driver module name.
So if you want to fix things, you'll have to fix them the other
way around, by not changing the module name but changing the
strings that ethtool ends up with instead.
Thank you.
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH v3] net: ethernet: cavium: Correct Cavium Thunderx NIC module and driver names
2018-01-24 21:27 ` David Miller
@ 2018-01-25 11:11 ` Vadim Lomovtsev
0 siblings, 0 replies; 9+ messages in thread
From: Vadim Lomovtsev @ 2018-01-25 11:11 UTC (permalink / raw)
To: David Miller
Cc: sgoutham, rric, linux-arm-kernel, netdev, linux-kernel,
Vadim.Lomovtsev, dnelson
On Wed, Jan 24, 2018 at 04:27:37PM -0500, David Miller wrote:
> From: Vadim Lomovtsev <Vadim.Lomovtsev@caviumnetworks.com>
> Date: Mon, 22 Jan 2018 06:13:27 -0800
>
> > From: Vadim Lomovtsev <Vadim.Lomovtsev@cavium.com>
> >
> > It was found that ethtool provides unexisting module name while
> > it queries the specified network device for associated driver
> > information. Then user tries to unload that module by provided
> > module name and fails.
> >
> > This happens because ethtool reads value of DRV_NAME macro,
> > while module name is defined at the driver's Makefile.
> >
> > This patch is to correct Cavium CN88xx Thunder NIC driver modules
> > names 'nicvf' to 'thunder_nicvf' and 'nicpf' to 'thunder_nicpf' along
> > with updating DRV_NAME macro values accordingly.
> >
> > Signed-off-by: Dean Nelson <dnelson@redhat.com>
> > Signed-off-by: Vadim Lomovtsev <Vadim.Lomovtsev@cavium.com>
>
> Once your driver has been deployed in a real upstream release you
> should never change the driver module name.
>
> So if you want to fix things, you'll have to fix them the other
> way around, by not changing the module name but changing the
> strings that ethtool ends up with instead.
>
> Thank you.
Ok, understood.
Will update patch and re-send.
Thank you.
Vadim
^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH v4] net: ethernet: cavium: Correct Cavium Thunderx NIC driver names accordingly to module name
2018-01-22 14:13 ` [PATCH v3] net: ethernet: cavium: Correct Cavium Thunderx NIC module and driver names Vadim Lomovtsev
2018-01-24 21:27 ` David Miller
@ 2018-01-25 11:38 ` Vadim Lomovtsev
2018-01-29 17:22 ` David Miller
1 sibling, 1 reply; 9+ messages in thread
From: Vadim Lomovtsev @ 2018-01-25 11:38 UTC (permalink / raw)
To: sgoutham, rric, linux-arm-kernel, netdev, linux-kernel, davem
Cc: Vadim Lomovtsev
From: Vadim Lomovtsev <Vadim.Lomovtsev@cavium.com>
It was found that ethtool provides unexisting module name while
it queries the specified network device for associated driver
information. Then user tries to unload that module by provided
module name and fails.
This happens because ethtool reads value of DRV_NAME macro,
while module name is defined at the driver's Makefile.
This patch is to correct Cavium CN88xx Thunder NIC driver names
(DRV_NAME macro) 'thunder-nicvf' to 'nicvf' and 'thunder-nic'
to 'nicpf', sync bgx and xcv driver names accordingly to their
module names.
Signed-off-by: Vadim Lomovtsev <Vadim.Lomovtsev@cavium.com>
---
drivers/net/ethernet/cavium/thunder/nic_main.c | 2 +-
drivers/net/ethernet/cavium/thunder/nicvf_ethtool.c | 2 +-
drivers/net/ethernet/cavium/thunder/nicvf_main.c | 2 +-
drivers/net/ethernet/cavium/thunder/thunder_bgx.c | 2 +-
drivers/net/ethernet/cavium/thunder/thunder_xcv.c | 2 +-
5 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/net/ethernet/cavium/thunder/nic_main.c b/drivers/net/ethernet/cavium/thunder/nic_main.c
index 8f1dd55b3e08..159b422da7fa 100644
--- a/drivers/net/ethernet/cavium/thunder/nic_main.c
+++ b/drivers/net/ethernet/cavium/thunder/nic_main.c
@@ -18,7 +18,7 @@
#include "q_struct.h"
#include "thunder_bgx.h"
-#define DRV_NAME "thunder-nic"
+#define DRV_NAME "nicpf"
#define DRV_VERSION "1.0"
struct hw_info {
diff --git a/drivers/net/ethernet/cavium/thunder/nicvf_ethtool.c b/drivers/net/ethernet/cavium/thunder/nicvf_ethtool.c
index b9ece9cbf98b..07f00558af9c 100644
--- a/drivers/net/ethernet/cavium/thunder/nicvf_ethtool.c
+++ b/drivers/net/ethernet/cavium/thunder/nicvf_ethtool.c
@@ -16,7 +16,7 @@
#include "q_struct.h"
#include "thunder_bgx.h"
-#define DRV_NAME "thunder-nicvf"
+#define DRV_NAME "nicvf"
#define DRV_VERSION "1.0"
struct nicvf_stat {
diff --git a/drivers/net/ethernet/cavium/thunder/nicvf_main.c b/drivers/net/ethernet/cavium/thunder/nicvf_main.c
index 7cb7571f9ad9..0a8f3e3ce637 100644
--- a/drivers/net/ethernet/cavium/thunder/nicvf_main.c
+++ b/drivers/net/ethernet/cavium/thunder/nicvf_main.c
@@ -26,7 +26,7 @@
#include "nicvf_queues.h"
#include "thunder_bgx.h"
-#define DRV_NAME "thunder-nicvf"
+#define DRV_NAME "nicvf"
#define DRV_VERSION "1.0"
/* Supported devices */
diff --git a/drivers/net/ethernet/cavium/thunder/thunder_bgx.c b/drivers/net/ethernet/cavium/thunder/thunder_bgx.c
index 5e5c4d7796b8..79fae7de3404 100644
--- a/drivers/net/ethernet/cavium/thunder/thunder_bgx.c
+++ b/drivers/net/ethernet/cavium/thunder/thunder_bgx.c
@@ -21,7 +21,7 @@
#include "nic.h"
#include "thunder_bgx.h"
-#define DRV_NAME "thunder-BGX"
+#define DRV_NAME "thunder_bgx"
#define DRV_VERSION "1.0"
struct lmac {
diff --git a/drivers/net/ethernet/cavium/thunder/thunder_xcv.c b/drivers/net/ethernet/cavium/thunder/thunder_xcv.c
index 578c7f8f11bf..2d5e8dab1f70 100644
--- a/drivers/net/ethernet/cavium/thunder/thunder_xcv.c
+++ b/drivers/net/ethernet/cavium/thunder/thunder_xcv.c
@@ -20,7 +20,7 @@
#include "nic.h"
#include "thunder_bgx.h"
-#define DRV_NAME "thunder-xcv"
+#define DRV_NAME "thunder_xcv"
#define DRV_VERSION "1.0"
/* Register offsets */
--
2.14.3
^ permalink raw reply related [flat|nested] 9+ messages in thread* Re: [PATCH v4] net: ethernet: cavium: Correct Cavium Thunderx NIC driver names accordingly to module name
2018-01-25 11:38 ` [PATCH v4] net: ethernet: cavium: Correct Cavium Thunderx NIC driver names accordingly to module name Vadim Lomovtsev
@ 2018-01-29 17:22 ` David Miller
0 siblings, 0 replies; 9+ messages in thread
From: David Miller @ 2018-01-29 17:22 UTC (permalink / raw)
To: Vadim.Lomovtsev
Cc: sgoutham, rric, linux-arm-kernel, netdev, linux-kernel, Vadim.Lomovtsev
From: Vadim Lomovtsev <Vadim.Lomovtsev@caviumnetworks.com>
Date: Thu, 25 Jan 2018 03:38:17 -0800
> From: Vadim Lomovtsev <Vadim.Lomovtsev@cavium.com>
>
> It was found that ethtool provides unexisting module name while
> it queries the specified network device for associated driver
> information. Then user tries to unload that module by provided
> module name and fails.
>
> This happens because ethtool reads value of DRV_NAME macro,
> while module name is defined at the driver's Makefile.
>
> This patch is to correct Cavium CN88xx Thunder NIC driver names
> (DRV_NAME macro) 'thunder-nicvf' to 'nicvf' and 'thunder-nic'
> to 'nicpf', sync bgx and xcv driver names accordingly to their
> module names.
>
> Signed-off-by: Vadim Lomovtsev <Vadim.Lomovtsev@cavium.com>
Applied to net-next, thank you.
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2018-01-29 17:22 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-01-18 15:42 [PATCH] net: ethernet: cavium: Correct Cacivum Thunderx nicvf/nicpf modules names Vadim Lomovtsev
2018-01-18 15:49 ` Vadim Lomovtsev
2018-01-18 15:53 ` [PATCH v2] net: ethernet: cavium: Correct Cavium " Vadim Lomovtsev
2018-01-18 18:18 ` Vadim Lomovtsev
2018-01-22 14:13 ` [PATCH v3] net: ethernet: cavium: Correct Cavium Thunderx NIC module and driver names Vadim Lomovtsev
2018-01-24 21:27 ` David Miller
2018-01-25 11:11 ` Vadim Lomovtsev
2018-01-25 11:38 ` [PATCH v4] net: ethernet: cavium: Correct Cavium Thunderx NIC driver names accordingly to module name Vadim Lomovtsev
2018-01-29 17:22 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).