* [PATCH] xfrm: fix boolean assignment in xfrm_get_type_offload
@ 2018-01-22 22:34 Gustavo A. R. Silva
2018-01-24 6:12 ` Steffen Klassert
0 siblings, 1 reply; 2+ messages in thread
From: Gustavo A. R. Silva @ 2018-01-22 22:34 UTC (permalink / raw)
To: Steffen Klassert, Herbert Xu, David S. Miller
Cc: netdev, linux-kernel, Gustavo A. R. Silva
Assign true or false to boolean variables instead of an integer value.
This issue was detected with the help of Coccinelle.
Fixes: ffdb5211da1c ("xfrm: Auto-load xfrm offload modules")
Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com>
---
net/xfrm/xfrm_state.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/xfrm/xfrm_state.c b/net/xfrm/xfrm_state.c
index 20b1e41..9f063c6 100644
--- a/net/xfrm/xfrm_state.c
+++ b/net/xfrm/xfrm_state.c
@@ -317,7 +317,7 @@ xfrm_get_type_offload(u8 proto, unsigned short family, bool try_load)
if (!type && try_load) {
request_module("xfrm-offload-%d-%d", family, proto);
- try_load = 0;
+ try_load = false;
goto retry;
}
--
2.7.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] xfrm: fix boolean assignment in xfrm_get_type_offload
2018-01-22 22:34 [PATCH] xfrm: fix boolean assignment in xfrm_get_type_offload Gustavo A. R. Silva
@ 2018-01-24 6:12 ` Steffen Klassert
0 siblings, 0 replies; 2+ messages in thread
From: Steffen Klassert @ 2018-01-24 6:12 UTC (permalink / raw)
To: Gustavo A. R. Silva; +Cc: Herbert Xu, David S. Miller, netdev, linux-kernel
On Mon, Jan 22, 2018 at 04:34:09PM -0600, Gustavo A. R. Silva wrote:
> Assign true or false to boolean variables instead of an integer value.
>
> This issue was detected with the help of Coccinelle.
>
> Fixes: ffdb5211da1c ("xfrm: Auto-load xfrm offload modules")
> Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com>
Patch applied, thanks!
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-01-24 6:12 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-01-22 22:34 [PATCH] xfrm: fix boolean assignment in xfrm_get_type_offload Gustavo A. R. Silva
2018-01-24 6:12 ` Steffen Klassert
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).