* [PATCH] lan78xx: remove redundant initialization of pointer 'phydev'
@ 2018-02-01 17:10 Colin King
2018-02-01 19:54 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Colin King @ 2018-02-01 17:10 UTC (permalink / raw)
To: Woojung Huh, Microchip Linux Driver Support, netdev
Cc: kernel-janitors, linux-kernel
From: Colin Ian King <colin.king@canonical.com>
Pointer phydev is initialized and this value is never read, phydev
is immediately updated to a new value, hence this initialization
is redundant and can be removed
Cleans up clang warning:
drivers/net/usb/lan78xx.c:2009:21: warning: Value stored to 'phydev'
during its initialization is never read
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
drivers/net/usb/lan78xx.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/usb/lan78xx.c b/drivers/net/usb/lan78xx.c
index ec56ff29aac4..60a604cc7647 100644
--- a/drivers/net/usb/lan78xx.c
+++ b/drivers/net/usb/lan78xx.c
@@ -2006,7 +2006,7 @@ static int lan78xx_phy_init(struct lan78xx_net *dev)
{
int ret;
u32 mii_adv;
- struct phy_device *phydev = dev->net->phydev;
+ struct phy_device *phydev;
phydev = phy_find_first(dev->mdiobus);
if (!phydev) {
--
2.15.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] lan78xx: remove redundant initialization of pointer 'phydev'
2018-02-01 17:10 [PATCH] lan78xx: remove redundant initialization of pointer 'phydev' Colin King
@ 2018-02-01 19:54 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2018-02-01 19:54 UTC (permalink / raw)
To: colin.king
Cc: woojung.huh, UNGLinuxDriver, netdev, kernel-janitors, linux-kernel
From: Colin King <colin.king@canonical.com>
Date: Thu, 1 Feb 2018 17:10:18 +0000
> From: Colin Ian King <colin.king@canonical.com>
>
> Pointer phydev is initialized and this value is never read, phydev
> is immediately updated to a new value, hence this initialization
> is redundant and can be removed
>
> Cleans up clang warning:
> drivers/net/usb/lan78xx.c:2009:21: warning: Value stored to 'phydev'
> during its initialization is never read
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Applied.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-02-01 19:54 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-02-01 17:10 [PATCH] lan78xx: remove redundant initialization of pointer 'phydev' Colin King
2018-02-01 19:54 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).