* [PATCH] net: aquantia: make function aq_fw2x_get_mac_permanent static
@ 2018-06-01 15:28 Colin King
2018-06-04 15:31 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Colin King @ 2018-06-01 15:28 UTC (permalink / raw)
To: David S . Miller, Igor Russkikh, netdev; +Cc: kernel-janitors, linux-kernel
From: Colin Ian King <colin.king@canonical.com>
The function aq_fw2x_get_mac_permanent is local to the source and does
not need to be in global scope, so make it static.
Cleans up sparse warning:
warning: symbol 'aq_fw2x_get_mac_permanent' was not declared. Should it
be static?
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
.../net/ethernet/aquantia/atlantic/hw_atl/hw_atl_utils_fw2x.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/aquantia/atlantic/hw_atl/hw_atl_utils_fw2x.c b/drivers/net/ethernet/aquantia/atlantic/hw_atl/hw_atl_utils_fw2x.c
index 8cfce95c82fc..39cd3a27fe77 100644
--- a/drivers/net/ethernet/aquantia/atlantic/hw_atl/hw_atl_utils_fw2x.c
+++ b/drivers/net/ethernet/aquantia/atlantic/hw_atl/hw_atl_utils_fw2x.c
@@ -107,7 +107,7 @@ static int aq_fw2x_update_link_status(struct aq_hw_s *self)
return 0;
}
-int aq_fw2x_get_mac_permanent(struct aq_hw_s *self, u8 *mac)
+static int aq_fw2x_get_mac_permanent(struct aq_hw_s *self, u8 *mac)
{
int err = 0;
u32 h = 0U;
--
2.17.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] net: aquantia: make function aq_fw2x_get_mac_permanent static
2018-06-01 15:28 [PATCH] net: aquantia: make function aq_fw2x_get_mac_permanent static Colin King
@ 2018-06-04 15:31 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2018-06-04 15:31 UTC (permalink / raw)
To: colin.king; +Cc: igor.russkikh, netdev, kernel-janitors, linux-kernel
From: Colin King <colin.king@canonical.com>
Date: Fri, 1 Jun 2018 16:28:34 +0100
> From: Colin Ian King <colin.king@canonical.com>
>
> The function aq_fw2x_get_mac_permanent is local to the source and does
> not need to be in global scope, so make it static.
>
> Cleans up sparse warning:
> warning: symbol 'aq_fw2x_get_mac_permanent' was not declared. Should it
> be static?
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Applied to net-next, thank you.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-06-04 15:31 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-06-01 15:28 [PATCH] net: aquantia: make function aq_fw2x_get_mac_permanent static Colin King
2018-06-04 15:31 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).