* [PATCH net-next] bpfilter: fix OUTPUT_FORMAT
@ 2018-06-07 17:29 Alexei Starovoitov
2018-06-07 20:57 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Alexei Starovoitov @ 2018-06-07 17:29 UTC (permalink / raw)
To: David S . Miller; +Cc: daniel, netdev, kernel-team
From: Alexei Starovoitov <ast@fb.com>
CONFIG_OUTPUT_FORMAT is x86 only macro.
Used objdump to extract elf file format.
Fixes: d2ba09c17a06 ("net: add skeleton of bpfilter kernel module")
Reported-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Alexei Starovoitov <ast@kernel.org>
---
net/bpfilter/Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/bpfilter/Makefile b/net/bpfilter/Makefile
index aafa72001fcd..e0bbe7583e58 100644
--- a/net/bpfilter/Makefile
+++ b/net/bpfilter/Makefile
@@ -21,7 +21,7 @@ endif
# which bpfilter_kern.c passes further into umh blob loader at run-time
quiet_cmd_copy_umh = GEN $@
cmd_copy_umh = echo ':' > $(obj)/.bpfilter_umh.o.cmd; \
- $(OBJCOPY) -I binary -O $(CONFIG_OUTPUT_FORMAT) \
+ $(OBJCOPY) -I binary -O `$(OBJDUMP) -f $<|grep format|cut -d' ' -f8` \
-B `$(OBJDUMP) -f $<|grep architecture|cut -d, -f1|cut -d' ' -f2` \
--rename-section .data=.init.rodata $< $@
--
2.9.5
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH net-next] bpfilter: fix OUTPUT_FORMAT
2018-06-07 17:29 [PATCH net-next] bpfilter: fix OUTPUT_FORMAT Alexei Starovoitov
@ 2018-06-07 20:57 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2018-06-07 20:57 UTC (permalink / raw)
To: ast; +Cc: daniel, netdev, kernel-team
From: Alexei Starovoitov <ast@kernel.org>
Date: Thu, 7 Jun 2018 10:29:29 -0700
> From: Alexei Starovoitov <ast@fb.com>
>
> CONFIG_OUTPUT_FORMAT is x86 only macro.
> Used objdump to extract elf file format.
>
> Fixes: d2ba09c17a06 ("net: add skeleton of bpfilter kernel module")
> Reported-by: David S. Miller <davem@davemloft.net>
> Signed-off-by: Alexei Starovoitov <ast@kernel.org>
Applied.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-06-07 20:57 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-06-07 17:29 [PATCH net-next] bpfilter: fix OUTPUT_FORMAT Alexei Starovoitov
2018-06-07 20:57 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).