* [PATCH net-next] net: dsa: mv88e6xxx: bitwise vs logical bug
@ 2018-08-14 9:06 Dan Carpenter
2018-08-14 13:41 ` Andrew Lunn
2018-08-14 17:05 ` David Miller
0 siblings, 2 replies; 3+ messages in thread
From: Dan Carpenter @ 2018-08-14 9:06 UTC (permalink / raw)
To: Andrew Lunn
Cc: Vivien Didelot, Florian Fainelli, David S. Miller, netdev,
kernel-janitors
We are trying to test if these flags are set but there are some && vs &
typos.
Fixes: efd1ba6af93f ("net: dsa: mv88e6xxx: Add SERDES phydev_mac_change up for 6390")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/drivers/net/dsa/mv88e6xxx/serdes.c b/drivers/net/dsa/mv88e6xxx/serdes.c
index f007d109b385..e82983975754 100644
--- a/drivers/net/dsa/mv88e6xxx/serdes.c
+++ b/drivers/net/dsa/mv88e6xxx/serdes.c
@@ -502,8 +502,8 @@ static irqreturn_t mv88e6390_serdes_thread_fn(int irq, void *dev_id)
err = mv88e6390_serdes_irq_status_sgmii(chip, lane, &status);
if (err)
goto out;
- if (status && (MV88E6390_SGMII_INT_LINK_DOWN ||
- MV88E6390_SGMII_INT_LINK_UP)) {
+ if (status & (MV88E6390_SGMII_INT_LINK_DOWN |
+ MV88E6390_SGMII_INT_LINK_UP)) {
ret = IRQ_HANDLED;
mv88e6390_serdes_irq_link_sgmii(chip, port->port, lane);
}
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH net-next] net: dsa: mv88e6xxx: bitwise vs logical bug
2018-08-14 9:06 [PATCH net-next] net: dsa: mv88e6xxx: bitwise vs logical bug Dan Carpenter
@ 2018-08-14 13:41 ` Andrew Lunn
2018-08-14 17:05 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: Andrew Lunn @ 2018-08-14 13:41 UTC (permalink / raw)
To: Dan Carpenter
Cc: Vivien Didelot, Florian Fainelli, David S. Miller, netdev,
kernel-janitors
On Tue, Aug 14, 2018 at 12:06:43PM +0300, Dan Carpenter wrote:
> We are trying to test if these flags are set but there are some && vs &
> typos.
>
> Fixes: efd1ba6af93f ("net: dsa: mv88e6xxx: Add SERDES phydev_mac_change up for 6390")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Andrew
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH net-next] net: dsa: mv88e6xxx: bitwise vs logical bug
2018-08-14 9:06 [PATCH net-next] net: dsa: mv88e6xxx: bitwise vs logical bug Dan Carpenter
2018-08-14 13:41 ` Andrew Lunn
@ 2018-08-14 17:05 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2018-08-14 17:05 UTC (permalink / raw)
To: dan.carpenter; +Cc: andrew, vivien.didelot, f.fainelli, netdev, kernel-janitors
From: Dan Carpenter <dan.carpenter@oracle.com>
Date: Tue, 14 Aug 2018 12:06:43 +0300
> We are trying to test if these flags are set but there are some && vs &
> typos.
>
> Fixes: efd1ba6af93f ("net: dsa: mv88e6xxx: Add SERDES phydev_mac_change up for 6390")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Applied.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-08-14 19:53 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-08-14 9:06 [PATCH net-next] net: dsa: mv88e6xxx: bitwise vs logical bug Dan Carpenter
2018-08-14 13:41 ` Andrew Lunn
2018-08-14 17:05 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).