* [PATCH net] Revert "rtnetlink: add rtnl_link_state check in rtnl_configure_link"
@ 2018-09-11 23:11 mcbirnie.l
2018-09-12 7:56 ` mcbirnie.l
0 siblings, 1 reply; 2+ messages in thread
From: mcbirnie.l @ 2018-09-11 23:11 UTC (permalink / raw)
To: netdev; +Cc: Liam McBirnie
From: Liam McBirnie <liam.mcbirnie@boeing.com>
This reverts commit 8d356b89f36d234a56434a110ae779e8ac389ca2.
This commit was intended to remove duplicate RTM_NEWLINK notifications
by only sending the notification if the link hadn't been initialized.
However, if a vxlan is created and set up with the same message,
then no netlink notification is sent showing that the link has been
set up.
This commit was part of a series of commits which fixed the ordering
of netlink notifications for vxlans.
Reverting this commit preserves the ordering but adds another
RTM_NEWLINK notification to the end.
Signed-off-by: Liam McBirnie <liam.mcbirnie@boeing.com>
---
net/core/rtnetlink.c | 9 +++------
1 file changed, 3 insertions(+), 6 deletions(-)
diff --git a/net/core/rtnetlink.c b/net/core/rtnetlink.c
index 60c928894a78..3bd5455a1cb1 100644
--- a/net/core/rtnetlink.c
+++ b/net/core/rtnetlink.c
@@ -2809,12 +2809,9 @@ int rtnl_configure_link(struct net_device *dev, const struct ifinfomsg *ifm)
return err;
}
- if (dev->rtnl_link_state == RTNL_LINK_INITIALIZED) {
- __dev_notify_flags(dev, old_flags, 0U);
- } else {
- dev->rtnl_link_state = RTNL_LINK_INITIALIZED;
- __dev_notify_flags(dev, old_flags, ~0U);
- }
+ dev->rtnl_link_state = RTNL_LINK_INITIALIZED;
+
+ __dev_notify_flags(dev, old_flags, ~0U);
return 0;
}
EXPORT_SYMBOL(rtnl_configure_link);
--
2.14.3
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH net] Revert "rtnetlink: add rtnl_link_state check in rtnl_configure_link"
2018-09-11 23:11 [PATCH net] Revert "rtnetlink: add rtnl_link_state check in rtnl_configure_link" mcbirnie.l
@ 2018-09-12 7:56 ` mcbirnie.l
0 siblings, 0 replies; 2+ messages in thread
From: mcbirnie.l @ 2018-09-12 7:56 UTC (permalink / raw)
To: netdev; +Cc: Liam McBirnie
From: Liam McBirnie <liam.mcbirnie@boeing.com>
Please reject this patch.
The author of the original commit is working on a better patch.
https://bugzilla.kernel.org/show_bug.cgi?id=201071
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-09-12 12:57 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-09-11 23:11 [PATCH net] Revert "rtnetlink: add rtnl_link_state check in rtnl_configure_link" mcbirnie.l
2018-09-12 7:56 ` mcbirnie.l
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).