* [PATCH net-next] rtnetlink: Update comment in rtnl_stats_dump regarding strict data checking
@ 2018-10-08 20:58 David Ahern
2018-10-11 5:26 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: David Ahern @ 2018-10-08 20:58 UTC (permalink / raw)
To: netdev; +Cc: David Ahern
From: David Ahern <dsahern@gmail.com>
The NLM_F_DUMP_PROPER_HDR netlink flag was replaced by a setsockopt.
Update the comment in rtnl_stats_dump.
Fixes: 841891ec0c65 ("rtnetlink: Update rtnl_stats_dump for strict data checking")
Reported-by: Christian Brauner <christian@brauner.io>
Signed-off-by: David Ahern <dsahern@gmail.com>
---
net/core/rtnetlink.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/net/core/rtnetlink.c b/net/core/rtnetlink.c
index c894c4af8981..6406e26171ff 100644
--- a/net/core/rtnetlink.c
+++ b/net/core/rtnetlink.c
@@ -4775,8 +4775,8 @@ static int rtnl_stats_dump(struct sk_buff *skb, struct netlink_callback *cb)
ifsm = nlmsg_data(cb->nlh);
- /* only requests using NLM_F_DUMP_PROPER_HDR can pass data to
- * influence the dump. The legacy exception is filter_mask.
+ /* only requests using strict checks can pass data to influence
+ * the dump. The legacy exception is filter_mask.
*/
if (cb->strict_check) {
if (ifsm->pad1 || ifsm->pad2 || ifsm->ifindex) {
--
2.11.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH net-next] rtnetlink: Update comment in rtnl_stats_dump regarding strict data checking
2018-10-08 20:58 [PATCH net-next] rtnetlink: Update comment in rtnl_stats_dump regarding strict data checking David Ahern
@ 2018-10-11 5:26 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2018-10-11 5:26 UTC (permalink / raw)
To: dsahern; +Cc: netdev, dsahern
From: David Ahern <dsahern@kernel.org>
Date: Mon, 8 Oct 2018 13:58:07 -0700
> From: David Ahern <dsahern@gmail.com>
>
> The NLM_F_DUMP_PROPER_HDR netlink flag was replaced by a setsockopt.
> Update the comment in rtnl_stats_dump.
>
> Fixes: 841891ec0c65 ("rtnetlink: Update rtnl_stats_dump for strict data checking")
> Reported-by: Christian Brauner <christian@brauner.io>
> Signed-off-by: David Ahern <dsahern@gmail.com>
Applied.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-10-11 12:51 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-10-08 20:58 [PATCH net-next] rtnetlink: Update comment in rtnl_stats_dump regarding strict data checking David Ahern
2018-10-11 5:26 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).