netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH][ipsec-next] xfrm: remove unnecessary check in xfrmi_get_stats64
@ 2018-10-07  1:56 Li RongQing
  2018-10-09  8:20 ` Steffen Klassert
  0 siblings, 1 reply; 2+ messages in thread
From: Li RongQing @ 2018-10-07  1:56 UTC (permalink / raw)
  To: netdev, steffen.klassert

if tstats of a device is not allocated, this device is not
registered correctly and can not be used.

Signed-off-by: Li RongQing <lirongqing@baidu.com>
---
 net/xfrm/xfrm_interface.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/net/xfrm/xfrm_interface.c b/net/xfrm/xfrm_interface.c
index dc5b20bf29cf..abafd49cc65d 100644
--- a/net/xfrm/xfrm_interface.c
+++ b/net/xfrm/xfrm_interface.c
@@ -561,9 +561,6 @@ static void xfrmi_get_stats64(struct net_device *dev,
 {
 	int cpu;
 
-	if (!dev->tstats)
-		return;
-
 	for_each_possible_cpu(cpu) {
 		struct pcpu_sw_netstats *stats;
 		struct pcpu_sw_netstats tmp;
-- 
2.16.2

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH][ipsec-next] xfrm: remove unnecessary check in xfrmi_get_stats64
  2018-10-07  1:56 [PATCH][ipsec-next] xfrm: remove unnecessary check in xfrmi_get_stats64 Li RongQing
@ 2018-10-09  8:20 ` Steffen Klassert
  0 siblings, 0 replies; 2+ messages in thread
From: Steffen Klassert @ 2018-10-09  8:20 UTC (permalink / raw)
  To: Li RongQing; +Cc: netdev

On Sun, Oct 07, 2018 at 09:56:15AM +0800, Li RongQing wrote:
> if tstats of a device is not allocated, this device is not
> registered correctly and can not be used.
> 
> Signed-off-by: Li RongQing <lirongqing@baidu.com>

Applied to ipsec-next, thanks!

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2018-10-09 15:35 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-10-07  1:56 [PATCH][ipsec-next] xfrm: remove unnecessary check in xfrmi_get_stats64 Li RongQing
2018-10-09  8:20 ` Steffen Klassert

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).