From: Andrew Lunn <andrew@lunn.ch>
To: Jose Abreu <jose.abreu@synopsys.com>
Cc: netdev@vger.kernel.org, Florian Fainelli <f.fainelli@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
Joao Pinto <joao.pinto@synopsys.com>
Subject: Re: [PATCH net-next 3/4] net: phy-c45: Implement reset/suspend/resume callbacks
Date: Mon, 22 Oct 2018 14:28:39 +0200 [thread overview]
Message-ID: <20181022122839.GB24112@lunn.ch> (raw)
In-Reply-To: <b65cd0978587224eb1496ad60d224394525b8ba6.1540204183.git.joabreu@synopsys.com>
> EXPORT_SYMBOL_GPL(gen10g_resume);
> @@ -327,7 +381,7 @@ struct phy_driver genphy_10g_driver = {
> .phy_id = 0xffffffff,
> .phy_id_mask = 0xffffffff,
> .name = "Generic 10G PHY",
> - .soft_reset = gen10g_no_soft_reset,
> + .soft_reset = gen10g_soft_reset,
> .config_init = gen10g_config_init,
> .features = 0,
> .aneg_done = genphy_c45_aneg_done,
Hi Jose
You need to be careful here. There is a reason this is called
gen10g_no_soft_reset, rather than having an empty
gen10g_soft_reset. Some PHYs break when you do a reset. So adding a
gen10g_soft_reset is fine, but don't change this here, without first
understanding the history, and talking to Russell King.
Andrew
next prev parent reply other threads:[~2018-10-22 20:47 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-22 10:32 [PATCH net-next 0/4] net: phy: Misc improvements for Generic 10G PHY Jose Abreu
2018-10-22 10:32 ` [PATCH net-next 1/4] net: phy: Use C45 Helpers when forcing PHY Jose Abreu
2018-10-22 17:11 ` Florian Fainelli
2018-10-23 10:20 ` Jose Abreu
2018-10-22 10:32 ` [PATCH net-next 2/4] net: phy-c45: Populate autoneg_done callback Jose Abreu
2018-10-22 12:21 ` Andrew Lunn
2018-10-22 10:32 ` [PATCH net-next 3/4] net: phy-c45: Implement reset/suspend/resume callbacks Jose Abreu
2018-10-22 12:28 ` Andrew Lunn [this message]
2018-10-22 12:47 ` Jose Abreu
2018-10-22 15:48 ` Russell King - ARM Linux
2018-10-22 17:13 ` Florian Fainelli
2018-10-23 10:17 ` Jose Abreu
2018-10-23 10:20 ` Russell King - ARM Linux
2018-10-23 10:28 ` Jose Abreu
2018-10-23 10:58 ` Russell King - ARM Linux
2018-10-24 7:50 ` Jose Abreu
2018-10-24 12:03 ` Andrew Lunn
2018-10-23 12:38 ` Andrew Lunn
2018-10-22 10:32 ` [PATCH net-next 4/4] net: phy-c45: Populate missing features Jose Abreu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181022122839.GB24112@lunn.ch \
--to=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=joao.pinto@synopsys.com \
--cc=jose.abreu@synopsys.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).