* [PATCH net-next] net: hns3: Fix for warning uninitialized symbol hw_err_lst3
@ 2018-10-24 14:32 Salil Mehta
2018-10-24 21:26 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Salil Mehta @ 2018-10-24 14:32 UTC (permalink / raw)
To: davem
Cc: salil.mehta, yisen.zhuang, lipeng321, mehta.salil, dan.carpenter,
netdev, linux-kernel, linuxarm, Shiju Jose
From: Shiju Jose <shiju.jose@huawei.com>
This patch fixes the smatch warning,
drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_err.c:700
hclge_log_and_clear_ppp_error() error: uninitialized symbol
'hw_err_lst3'
Link: https://lkml.org/lkml/2018/10/23/430
Fixes: da2d072a9ea7 ("net: hns3: Add enable and process hw errors from PPP")
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Shiju Jose <shiju.jose@huawei.com>
Signed-off-by: Salil Mehta <salil.mehta@huawei.com>
---
drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_err.c | 10 ++++++----
1 file changed, 6 insertions(+), 4 deletions(-)
diff --git a/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_err.c b/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_err.c
index f7e363b..dca6f23 100644
--- a/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_err.c
+++ b/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_err.c
@@ -859,10 +859,12 @@ static int hclge_log_and_clear_ppp_error(struct hclge_dev *hdev, u32 cmd,
reset_level = HNAE3_FUNC_RESET;
}
- err_sts = (le32_to_cpu(desc[0].data[4]) >> 8) & 0x3;
- if (err_sts) {
- hclge_log_error(dev, hw_err_lst3, err_sts);
- reset_level = HNAE3_FUNC_RESET;
+ if (cmd == HCLGE_PPP_CMD0_INT_CMD) {
+ err_sts = (le32_to_cpu(desc[0].data[4]) >> 8) & 0x3;
+ if (err_sts) {
+ hclge_log_error(dev, hw_err_lst3, err_sts);
+ reset_level = HNAE3_FUNC_RESET;
+ }
}
/* clear PPP INT */
--
1.9.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH net-next] net: hns3: Fix for warning uninitialized symbol hw_err_lst3
2018-10-24 14:32 [PATCH net-next] net: hns3: Fix for warning uninitialized symbol hw_err_lst3 Salil Mehta
@ 2018-10-24 21:26 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2018-10-24 21:26 UTC (permalink / raw)
To: salil.mehta
Cc: yisen.zhuang, lipeng321, mehta.salil, dan.carpenter, netdev,
linux-kernel, linuxarm, shiju.jose
From: Salil Mehta <salil.mehta@huawei.com>
Date: Wed, 24 Oct 2018 15:32:18 +0100
> From: Shiju Jose <shiju.jose@huawei.com>
>
> This patch fixes the smatch warning,
>
> drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_err.c:700
> hclge_log_and_clear_ppp_error() error: uninitialized symbol
> 'hw_err_lst3'
>
> Link: https://lkml.org/lkml/2018/10/23/430
>
> Fixes: da2d072a9ea7 ("net: hns3: Add enable and process hw errors from PPP")
> Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
> Signed-off-by: Shiju Jose <shiju.jose@huawei.com>
> Signed-off-by: Salil Mehta <salil.mehta@huawei.com>
Applied.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-10-24 21:26 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-10-24 14:32 [PATCH net-next] net: hns3: Fix for warning uninitialized symbol hw_err_lst3 Salil Mehta
2018-10-24 21:26 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).