* [PATCH net] ipv6: Consider sk_bound_dev_if when binding a socket to an address
@ 2019-01-03 2:57 David Ahern
2019-01-03 4:17 ` David Miller
2019-01-03 22:22 ` Ralf Jung
0 siblings, 2 replies; 3+ messages in thread
From: David Ahern @ 2019-01-03 2:57 UTC (permalink / raw)
To: davem; +Cc: post, netdev, David Ahern
From: David Ahern <dsahern@gmail.com>
IPv6 does not consider if the socket is bound to a device when binding
to an address. The result is that a socket can be bound to eth0 and then
bound to the address of eth1. If the device is a VRF, the result is that
a socket can only be bound to an address in the default VRF.
Resolve by considering the device if sk_bound_dev_if is set.
This problem exists from the beginning of git history.
Signed-off-by: David Ahern <dsahern@gmail.com>
---
net/ipv6/af_inet6.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/net/ipv6/af_inet6.c b/net/ipv6/af_inet6.c
index f0cd291034f0..0bfb6cc0a30a 100644
--- a/net/ipv6/af_inet6.c
+++ b/net/ipv6/af_inet6.c
@@ -350,6 +350,9 @@ static int __inet6_bind(struct sock *sk, struct sockaddr *uaddr, int addr_len,
err = -EINVAL;
goto out_unlock;
}
+ }
+
+ if (sk->sk_bound_dev_if) {
dev = dev_get_by_index_rcu(net, sk->sk_bound_dev_if);
if (!dev) {
err = -ENODEV;
--
2.11.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH net] ipv6: Consider sk_bound_dev_if when binding a socket to an address
2019-01-03 2:57 [PATCH net] ipv6: Consider sk_bound_dev_if when binding a socket to an address David Ahern
@ 2019-01-03 4:17 ` David Miller
2019-01-03 22:22 ` Ralf Jung
1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2019-01-03 4:17 UTC (permalink / raw)
To: dsahern; +Cc: post, netdev, dsahern
From: David Ahern <dsahern@kernel.org>
Date: Wed, 2 Jan 2019 18:57:09 -0800
> From: David Ahern <dsahern@gmail.com>
>
> IPv6 does not consider if the socket is bound to a device when binding
> to an address. The result is that a socket can be bound to eth0 and then
> bound to the address of eth1. If the device is a VRF, the result is that
> a socket can only be bound to an address in the default VRF.
>
> Resolve by considering the device if sk_bound_dev_if is set.
>
> This problem exists from the beginning of git history.
>
> Signed-off-by: David Ahern <dsahern@gmail.com>
Applied and queued up for -stable.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH net] ipv6: Consider sk_bound_dev_if when binding a socket to an address
2019-01-03 2:57 [PATCH net] ipv6: Consider sk_bound_dev_if when binding a socket to an address David Ahern
2019-01-03 4:17 ` David Miller
@ 2019-01-03 22:22 ` Ralf Jung
1 sibling, 0 replies; 3+ messages in thread
From: Ralf Jung @ 2019-01-03 22:22 UTC (permalink / raw)
To: David Ahern, davem; +Cc: netdev, David Ahern
Hi all,
thanks a lot! I can confirm that this fixes my test script.
Kind regards,
Ralf
On 03.01.19 03:57, David Ahern wrote:
> From: David Ahern <dsahern@gmail.com>
>
> IPv6 does not consider if the socket is bound to a device when binding
> to an address. The result is that a socket can be bound to eth0 and then
> bound to the address of eth1. If the device is a VRF, the result is that
> a socket can only be bound to an address in the default VRF.
>
> Resolve by considering the device if sk_bound_dev_if is set.
>
> This problem exists from the beginning of git history.
>
> Signed-off-by: David Ahern <dsahern@gmail.com>
> ---
> net/ipv6/af_inet6.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/net/ipv6/af_inet6.c b/net/ipv6/af_inet6.c
> index f0cd291034f0..0bfb6cc0a30a 100644
> --- a/net/ipv6/af_inet6.c
> +++ b/net/ipv6/af_inet6.c
> @@ -350,6 +350,9 @@ static int __inet6_bind(struct sock *sk, struct sockaddr *uaddr, int addr_len,
> err = -EINVAL;
> goto out_unlock;
> }
> + }
> +
> + if (sk->sk_bound_dev_if) {
> dev = dev_get_by_index_rcu(net, sk->sk_bound_dev_if);
> if (!dev) {
> err = -ENODEV;
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-01-03 22:22 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-01-03 2:57 [PATCH net] ipv6: Consider sk_bound_dev_if when binding a socket to an address David Ahern
2019-01-03 4:17 ` David Miller
2019-01-03 22:22 ` Ralf Jung
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).