netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] net: lmc: remove -I. header search path
@ 2019-01-25 14:22 Masahiro Yamada
  2019-01-27  2:27 ` David Miller
  0 siblings, 1 reply; 2+ messages in thread
From: Masahiro Yamada @ 2019-01-25 14:22 UTC (permalink / raw)
  To: David S . Miller, netdev; +Cc: Masahiro Yamada, linux-kernel

The header search path -I. in kernel Makefiles is very suspicious;
it allows the compiler to search for headers in the top of $(srctree),
where obviously no header file exists.

I was able to build without this header search path.

Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
---

 drivers/net/wan/lmc/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/wan/lmc/Makefile b/drivers/net/wan/lmc/Makefile
index 609710d..247f60c 100644
--- a/drivers/net/wan/lmc/Makefile
+++ b/drivers/net/wan/lmc/Makefile
@@ -14,4 +14,4 @@ lmc-objs := lmc_debug.o lmc_media.o lmc_main.o lmc_proto.o
 # -DDEBUG \
 # -DLMC_PACKET_LOG
 
-ccflags-y := -I. $(DBGDEF)
+ccflags-y := $(DBGDEF)
-- 
2.7.4


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] net: lmc: remove -I. header search path
  2019-01-25 14:22 [PATCH] net: lmc: remove -I. header search path Masahiro Yamada
@ 2019-01-27  2:27 ` David Miller
  0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2019-01-27  2:27 UTC (permalink / raw)
  To: yamada.masahiro; +Cc: netdev, linux-kernel

From: Masahiro Yamada <yamada.masahiro@socionext.com>
Date: Fri, 25 Jan 2019 23:22:29 +0900

> The header search path -I. in kernel Makefiles is very suspicious;
> it allows the compiler to search for headers in the top of $(srctree),
> where obviously no header file exists.
> 
> I was able to build without this header search path.
> 
> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>

Applied to net-next, thanks.

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2019-01-27  2:27 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-01-25 14:22 [PATCH] net: lmc: remove -I. header search path Masahiro Yamada
2019-01-27  2:27 ` David Miller

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).