netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH bpf-next v2 0/3] selftests: bpf: break up test_verifier
@ 2019-01-25 23:24 Jakub Kicinski
  2019-01-25 23:24 ` [PATCH bpf-next v2 1/3] selftests: bpf: prepare for break up of verifier tests Jakub Kicinski
                   ` (2 more replies)
  0 siblings, 3 replies; 10+ messages in thread
From: Jakub Kicinski @ 2019-01-25 23:24 UTC (permalink / raw)
  To: alexei.starovoitov, daniel; +Cc: oss-drivers, netdev, Jakub Kicinski

Hi!

The tools/testing/selftests/bpf/test_verifier.c file is
way too large, and since most people add their at the
end of the list it's very prone to conflicts.

Break it up in the simplest possible way - slice the
array up into smaller C files and include them in the
right spot.

Tested:
$ make -C tools/testing/selftests/bpf/
$ cd tools/testing/selftests/bpf/ ; make

v2:

The indentation is reduced further as discussed and lines folded.
The conversion was scripted, and double checked by hand.

Jakub Kicinski (3):
  selftests: bpf: prepare for break up of verifier tests
  selftests: bpf: break up test_verifier
  selftests: bpf: break up the rest of test_verifier

 tools/testing/selftests/bpf/Makefile          |    13 +
 tools/testing/selftests/bpf/test_verifier.c   | 16288 +---------------
 .../testing/selftests/bpf/verifier/.gitignore |     1 +
 tools/testing/selftests/bpf/verifier/and.c    |    50 +
 .../selftests/bpf/verifier/array_access.c     |   219 +
 tools/testing/selftests/bpf/verifier/basic.c  |    23 +
 .../selftests/bpf/verifier/basic_call.c       |    50 +
 .../selftests/bpf/verifier/basic_instr.c      |   134 +
 .../selftests/bpf/verifier/basic_stack.c      |    64 +
 .../selftests/bpf/verifier/basic_stx_ldx.c    |    45 +
 tools/testing/selftests/bpf/verifier/bounds.c |   508 +
 .../selftests/bpf/verifier/bounds_deduction.c |   124 +
 .../bpf/verifier/bounds_mix_sign_unsign.c     |   406 +
 .../selftests/bpf/verifier/bpf_get_stack.c    |    44 +
 tools/testing/selftests/bpf/verifier/calls.c  |  1942 ++
 tools/testing/selftests/bpf/verifier/cfg.c    |    70 +
 .../bpf/verifier/cgroup_inv_retcode.c         |    72 +
 .../selftests/bpf/verifier/cgroup_skb.c       |   197 +
 .../selftests/bpf/verifier/cgroup_storage.c   |   220 +
 .../testing/selftests/bpf/verifier/const_or.c |    60 +
 tools/testing/selftests/bpf/verifier/ctx.c    |    93 +
 .../selftests/bpf/verifier/ctx_sk_msg.c       |   180 +
 .../testing/selftests/bpf/verifier/ctx_skb.c  |  1033 +
 .../selftests/bpf/verifier/dead_code.c        |   159 +
 .../bpf/verifier/direct_packet_access.c       |   633 +
 .../verifier/direct_stack_access_wraparound.c |    40 +
 tools/testing/selftests/bpf/verifier/div0.c   |   184 +
 .../selftests/bpf/verifier/div_overflow.c     |   104 +
 .../bpf/verifier/helper_access_var_len.c      |   614 +
 .../bpf/verifier/helper_packet_access.c       |   460 +
 .../bpf/verifier/helper_value_access.c        |   953 +
 tools/testing/selftests/bpf/verifier/jit.c    |    88 +
 tools/testing/selftests/bpf/verifier/jmp32.c  |   724 +
 tools/testing/selftests/bpf/verifier/jset.c   |   165 +
 tools/testing/selftests/bpf/verifier/jump.c   |   180 +
 .../selftests/bpf/verifier/junk_insn.c        |    45 +
 tools/testing/selftests/bpf/verifier/ld_abs.c |   286 +
 tools/testing/selftests/bpf/verifier/ld_dw.c  |    36 +
 .../testing/selftests/bpf/verifier/ld_imm64.c |   141 +
 tools/testing/selftests/bpf/verifier/ld_ind.c |    72 +
 .../testing/selftests/bpf/verifier/leak_ptr.c |    67 +
 tools/testing/selftests/bpf/verifier/lwt.c    |   189 +
 .../selftests/bpf/verifier/map_in_map.c       |    62 +
 .../selftests/bpf/verifier/map_ptr_mixing.c   |   100 +
 .../selftests/bpf/verifier/map_ret_val.c      |    65 +
 .../testing/selftests/bpf/verifier/masking.c  |   322 +
 .../selftests/bpf/verifier/meta_access.c      |   235 +
 .../bpf/verifier/perf_event_sample_period.c   |    59 +
 .../bpf/verifier/prevent_map_lookup.c         |    74 +
 .../selftests/bpf/verifier/raw_stack.c        |   305 +
 .../selftests/bpf/verifier/ref_tracking.c     |   607 +
 .../selftests/bpf/verifier/runtime_jit.c      |    80 +
 .../selftests/bpf/verifier/search_pruning.c   |   156 +
 .../selftests/bpf/verifier/spill_fill.c       |    75 +
 .../selftests/bpf/verifier/stack_ptr.c        |   317 +
 tools/testing/selftests/bpf/verifier/uninit.c |    39 +
 tools/testing/selftests/bpf/verifier/unpriv.c |   521 +
 tools/testing/selftests/bpf/verifier/value.c  |   104 +
 .../selftests/bpf/verifier/value_adj_spill.c  |    43 +
 .../bpf/verifier/value_illegal_alu.c          |    94 +
 .../selftests/bpf/verifier/value_or_null.c    |   152 +
 .../selftests/bpf/verifier/value_ptr_arith.c  |   792 +
 .../testing/selftests/bpf/verifier/var_off.c  |    66 +
 tools/testing/selftests/bpf/verifier/xadd.c   |    97 +
 tools/testing/selftests/bpf/verifier/xdp.c    |    14 +
 .../bpf/verifier/xdp_direct_packet_access.c   |   900 +
 66 files changed, 15970 insertions(+), 16285 deletions(-)
 create mode 100644 tools/testing/selftests/bpf/verifier/.gitignore
 create mode 100644 tools/testing/selftests/bpf/verifier/and.c
 create mode 100644 tools/testing/selftests/bpf/verifier/array_access.c
 create mode 100644 tools/testing/selftests/bpf/verifier/basic.c
 create mode 100644 tools/testing/selftests/bpf/verifier/basic_call.c
 create mode 100644 tools/testing/selftests/bpf/verifier/basic_instr.c
 create mode 100644 tools/testing/selftests/bpf/verifier/basic_stack.c
 create mode 100644 tools/testing/selftests/bpf/verifier/basic_stx_ldx.c
 create mode 100644 tools/testing/selftests/bpf/verifier/bounds.c
 create mode 100644 tools/testing/selftests/bpf/verifier/bounds_deduction.c
 create mode 100644 tools/testing/selftests/bpf/verifier/bounds_mix_sign_unsign.c
 create mode 100644 tools/testing/selftests/bpf/verifier/bpf_get_stack.c
 create mode 100644 tools/testing/selftests/bpf/verifier/calls.c
 create mode 100644 tools/testing/selftests/bpf/verifier/cfg.c
 create mode 100644 tools/testing/selftests/bpf/verifier/cgroup_inv_retcode.c
 create mode 100644 tools/testing/selftests/bpf/verifier/cgroup_skb.c
 create mode 100644 tools/testing/selftests/bpf/verifier/cgroup_storage.c
 create mode 100644 tools/testing/selftests/bpf/verifier/const_or.c
 create mode 100644 tools/testing/selftests/bpf/verifier/ctx.c
 create mode 100644 tools/testing/selftests/bpf/verifier/ctx_sk_msg.c
 create mode 100644 tools/testing/selftests/bpf/verifier/ctx_skb.c
 create mode 100644 tools/testing/selftests/bpf/verifier/dead_code.c
 create mode 100644 tools/testing/selftests/bpf/verifier/direct_packet_access.c
 create mode 100644 tools/testing/selftests/bpf/verifier/direct_stack_access_wraparound.c
 create mode 100644 tools/testing/selftests/bpf/verifier/div0.c
 create mode 100644 tools/testing/selftests/bpf/verifier/div_overflow.c
 create mode 100644 tools/testing/selftests/bpf/verifier/helper_access_var_len.c
 create mode 100644 tools/testing/selftests/bpf/verifier/helper_packet_access.c
 create mode 100644 tools/testing/selftests/bpf/verifier/helper_value_access.c
 create mode 100644 tools/testing/selftests/bpf/verifier/jit.c
 create mode 100644 tools/testing/selftests/bpf/verifier/jmp32.c
 create mode 100644 tools/testing/selftests/bpf/verifier/jset.c
 create mode 100644 tools/testing/selftests/bpf/verifier/jump.c
 create mode 100644 tools/testing/selftests/bpf/verifier/junk_insn.c
 create mode 100644 tools/testing/selftests/bpf/verifier/ld_abs.c
 create mode 100644 tools/testing/selftests/bpf/verifier/ld_dw.c
 create mode 100644 tools/testing/selftests/bpf/verifier/ld_imm64.c
 create mode 100644 tools/testing/selftests/bpf/verifier/ld_ind.c
 create mode 100644 tools/testing/selftests/bpf/verifier/leak_ptr.c
 create mode 100644 tools/testing/selftests/bpf/verifier/lwt.c
 create mode 100644 tools/testing/selftests/bpf/verifier/map_in_map.c
 create mode 100644 tools/testing/selftests/bpf/verifier/map_ptr_mixing.c
 create mode 100644 tools/testing/selftests/bpf/verifier/map_ret_val.c
 create mode 100644 tools/testing/selftests/bpf/verifier/masking.c
 create mode 100644 tools/testing/selftests/bpf/verifier/meta_access.c
 create mode 100644 tools/testing/selftests/bpf/verifier/perf_event_sample_period.c
 create mode 100644 tools/testing/selftests/bpf/verifier/prevent_map_lookup.c
 create mode 100644 tools/testing/selftests/bpf/verifier/raw_stack.c
 create mode 100644 tools/testing/selftests/bpf/verifier/ref_tracking.c
 create mode 100644 tools/testing/selftests/bpf/verifier/runtime_jit.c
 create mode 100644 tools/testing/selftests/bpf/verifier/search_pruning.c
 create mode 100644 tools/testing/selftests/bpf/verifier/spill_fill.c
 create mode 100644 tools/testing/selftests/bpf/verifier/stack_ptr.c
 create mode 100644 tools/testing/selftests/bpf/verifier/uninit.c
 create mode 100644 tools/testing/selftests/bpf/verifier/unpriv.c
 create mode 100644 tools/testing/selftests/bpf/verifier/value.c
 create mode 100644 tools/testing/selftests/bpf/verifier/value_adj_spill.c
 create mode 100644 tools/testing/selftests/bpf/verifier/value_illegal_alu.c
 create mode 100644 tools/testing/selftests/bpf/verifier/value_or_null.c
 create mode 100644 tools/testing/selftests/bpf/verifier/value_ptr_arith.c
 create mode 100644 tools/testing/selftests/bpf/verifier/var_off.c
 create mode 100644 tools/testing/selftests/bpf/verifier/xadd.c
 create mode 100644 tools/testing/selftests/bpf/verifier/xdp.c
 create mode 100644 tools/testing/selftests/bpf/verifier/xdp_direct_packet_access.c

-- 
2.19.2


^ permalink raw reply	[flat|nested] 10+ messages in thread

end of thread, other threads:[~2019-01-28 16:45 UTC | newest]

Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-01-25 23:24 [PATCH bpf-next v2 0/3] selftests: bpf: break up test_verifier Jakub Kicinski
2019-01-25 23:24 ` [PATCH bpf-next v2 1/3] selftests: bpf: prepare for break up of verifier tests Jakub Kicinski
2019-01-25 23:24 ` [PATCH bpf-next v2 3/3] selftests: bpf: break up the rest of test_verifier Jakub Kicinski
2019-01-26  5:55 ` [PATCH bpf-next v2 0/3] selftests: bpf: break up test_verifier Alexei Starovoitov
2019-01-26  6:17   ` Jakub Kicinski
2019-01-26  6:21     ` Alexei Starovoitov
2019-01-27 18:33       ` Jakub Kicinski
2019-01-27 20:56         ` Alexei Starovoitov
     [not found]           ` <20190127205413.231fcc05@cakuba.hsd1.ca.comcast.net>
2019-01-28  5:57             ` Alexei Starovoitov
2019-01-28 16:45               ` Jakub Kicinski

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).