[PATCH V2] net: i825xx: replace dev_kfree_skb_irq by dev_consume_skb_irq

[PATCH V2] net: i825xx: replace dev_kfree_skb_irq by dev_consume_skb_irq

[Yang Wei]

dev_consume_skb_irq() should be called in i596_interrupt() when
xmit done. It makes drop profiles more friendly.

Signed-off-by: Yang Wei <yang.wei9@zte.com.cn>
---
 drivers/net/ethernet/i825xx/82596.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/i825xx/82596.c b/drivers/net/ethernet/i825xx/82596.c
index d719668..855900a 100644
--- a/drivers/net/ethernet/i825xx/82596.c
+++ b/drivers/net/ethernet/i825xx/82596.c
@@ -1310,7 +1310,7 @@ static irqreturn_t i596_interrupt(int irq, void *dev_id)
 						dev->stats.tx_aborted_errors++;
 				}
 
-				dev_kfree_skb_irq(skb);
+				dev_consume_skb_irq(skb);
 
 				tx_cmd->cmd.command = 0; /* Mark free */
 				break;
-- 
2.7.4

Re: [PATCH V2] net: i825xx: replace dev_kfree_skb_irq by dev_consume_skb_irq

[Andrew Lunn]

On Sun, Jan 27, 2019 at 11:53:08PM +0800, Yang Wei wrote:
> dev_consume_skb_irq() should be called in i596_interrupt() when
> xmit done. It makes drop profiles more friendly.
>
> Signed-off-by: Yang Wei <yang.wei9@zte.com.cn>
> ---

Hi Yang

It is normal to include here, under the ---, what has changed since
the previous version of the patch.

Please also read

https://www.kernel.org/doc/html/latest/networking/netdev-FAQ.html

Your patches don't have the correct subject.

Thanks
	Andrew

Re: [PATCH V2] net: i825xx: replace dev_kfree_skb_irq bydev_consume_skb_irq

[Andrew Lunn]

On Mon, Jan 28, 2019 at 09:50:42AM +0800, yang.wei9@zte.com.cn wrote:
> > It is normal to include here, under the ---, what has changed since
> > the previous version of the patch.
> >
> > Please also read
> >
> > https://www.kernel.org/doc/html/latest/networking/netdev-FAQ.html
> >
> > Your patches don't have the correct subject.
> 
> Hi Andrew
> 
> The previous patch (as follow) is wrong, so I submit a new and named V2.
> Please reject the previous patch.
> 
> net: i825xx: replace dev_kfree_skb_irq by dev_consume_skb_irq
> http://patchwork.ozlabs.org/patch/1031590/
> 
> The original suject in patch is as follow, but it be truncated due to return character.
> I have changed it, make the suject in one line. Do I need to resubmit it?

https://www.kernel.org/doc/html/latest/networking/netdev-FAQ.html#q-how-do-i-indicate-which-tree-net-vs-net-next-my-patch-should-be-in

	Andrew