* [PATCH net] net: caif: call dev_consume_skb_any when skb xmit done
@ 2019-01-29 15:32 Yang Wei
2019-01-29 18:11 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Yang Wei @ 2019-01-29 15:32 UTC (permalink / raw)
To: netdev; +Cc: dmitry.tarnyagin, davem, yang.wei9
From: Yang Wei <yang.wei9@zte.com.cn>
The skb shouled be consumed when xmit done, it makes drop profiles
(dropwatch, perf) more friendly.
dev_kfree_skb_irq()/kfree_skb() shouled be replaced by
dev_consume_skb_any(), it makes code cleaner.
Signed-off-by: Yang Wei <yang.wei9@zte.com.cn>
---
drivers/net/caif/caif_serial.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/drivers/net/caif/caif_serial.c b/drivers/net/caif/caif_serial.c
index a0f954f..44e6c7b 100644
--- a/drivers/net/caif/caif_serial.c
+++ b/drivers/net/caif/caif_serial.c
@@ -257,10 +257,7 @@ static int handle_tx(struct ser_device *ser)
if (skb->len == 0) {
struct sk_buff *tmp = skb_dequeue(&ser->head);
WARN_ON(tmp != skb);
- if (in_interrupt())
- dev_kfree_skb_irq(skb);
- else
- kfree_skb(skb);
+ dev_consume_skb_any(skb);
}
}
/* Send flow off if queue is empty */
--
2.7.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH net] net: caif: call dev_consume_skb_any when skb xmit done
2019-01-29 15:32 [PATCH net] net: caif: call dev_consume_skb_any when skb xmit done Yang Wei
@ 2019-01-29 18:11 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2019-01-29 18:11 UTC (permalink / raw)
To: albin_yang; +Cc: netdev, dmitry.tarnyagin, yang.wei9
From: Yang Wei <albin_yang@163.com>
Date: Tue, 29 Jan 2019 23:32:22 +0800
> From: Yang Wei <yang.wei9@zte.com.cn>
>
> The skb shouled be consumed when xmit done, it makes drop profiles
> (dropwatch, perf) more friendly.
> dev_kfree_skb_irq()/kfree_skb() shouled be replaced by
> dev_consume_skb_any(), it makes code cleaner.
>
> Signed-off-by: Yang Wei <yang.wei9@zte.com.cn>
Applied.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-01-29 18:11 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-01-29 15:32 [PATCH net] net: caif: call dev_consume_skb_any when skb xmit done Yang Wei
2019-01-29 18:11 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).