* [PATCH iproute2] tc: fix memory leak in error path
@ 2019-02-06 18:44 Stephen Hemminger
0 siblings, 0 replies; only message in thread
From: Stephen Hemminger @ 2019-02-06 18:44 UTC (permalink / raw)
To: netdev; +Cc: Stephen Hemminger
If value passed to parse_percent was not valid, it would
leak the dynamic allocation from sscanf.
Fixes: 927e3cfb52b5 ("tc: B.W limits can now be specified in %.")
Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
---
tc/tc_util.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/tc/tc_util.c b/tc/tc_util.c
index ab717890bb2a..1377b536e72f 100644
--- a/tc/tc_util.c
+++ b/tc/tc_util.c
@@ -195,7 +195,7 @@ static int parse_percent_rate(char *rate, const char *str, const char *dev)
long dev_mbit;
int ret;
double perc, rate_mbit;
- char *str_perc;
+ char *str_perc = NULL;
if (!dev[0]) {
fprintf(stderr, "No device specified; specify device to rate limit by percentage\n");
@@ -230,6 +230,7 @@ static int parse_percent_rate(char *rate, const char *str, const char *dev)
return 0;
malf:
+ free(str_perc);
fprintf(stderr, "Specified rate value could not be read or is malformed\n");
return -1;
}
--
2.20.1
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2019-02-06 18:44 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-02-06 18:44 [PATCH iproute2] tc: fix memory leak in error path Stephen Hemminger
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).