Netdev Archive on lore.kernel.org
 help / Atom feed
* [PATCH net] geneve: change NET_UDP_TUNNEL dependency to select
@ 2019-02-11 14:32 Matteo Croce
  2019-02-12 17:24 ` David Miller
  0 siblings, 1 reply; 2+ messages in thread
From: Matteo Croce @ 2019-02-11 14:32 UTC (permalink / raw)
  To: netdev; +Cc: David S . Miller

Due to the depends on NET_UDP_TUNNEL, at the moment it is impossible to
compile GENEVE if no other protocol depending on NET_UDP_TUNNEL is
selected.

Fix this changing the depends to a select, and drop NET_IP_TUNNEL from the
select list, as it already depends on NET_UDP_TUNNEL.

Signed-off-by: Matteo Croce <mcroce@redhat.com>
Reviewed-and-tested-by: Andrea Claudi <aclaudi@redhat.com>
Tested-by: Davide Caratti <dcaratti@redhat.com>
---
 drivers/net/Kconfig | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/net/Kconfig b/drivers/net/Kconfig
index edb1c023a753..21bf8ac78380 100644
--- a/drivers/net/Kconfig
+++ b/drivers/net/Kconfig
@@ -197,9 +197,9 @@ config VXLAN
 
 config GENEVE
        tristate "Generic Network Virtualization Encapsulation"
-       depends on INET && NET_UDP_TUNNEL
+       depends on INET
        depends on IPV6 || !IPV6
-       select NET_IP_TUNNEL
+       select NET_UDP_TUNNEL
        select GRO_CELLS
        ---help---
 	  This allows one to create geneve virtual interfaces that provide
-- 
2.20.1


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH net] geneve: change NET_UDP_TUNNEL dependency to select
  2019-02-11 14:32 [PATCH net] geneve: change NET_UDP_TUNNEL dependency to select Matteo Croce
@ 2019-02-12 17:24 ` David Miller
  0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2019-02-12 17:24 UTC (permalink / raw)
  To: mcroce; +Cc: netdev

From: Matteo Croce <mcroce@redhat.com>
Date: Mon, 11 Feb 2019 15:32:36 +0100

> Due to the depends on NET_UDP_TUNNEL, at the moment it is impossible to
> compile GENEVE if no other protocol depending on NET_UDP_TUNNEL is
> selected.
> 
> Fix this changing the depends to a select, and drop NET_IP_TUNNEL from the
> select list, as it already depends on NET_UDP_TUNNEL.
> 
> Signed-off-by: Matteo Croce <mcroce@redhat.com>
> Reviewed-and-tested-by: Andrea Claudi <aclaudi@redhat.com>
> Tested-by: Davide Caratti <dcaratti@redhat.com>

Applied.

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, back to index

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-02-11 14:32 [PATCH net] geneve: change NET_UDP_TUNNEL dependency to select Matteo Croce
2019-02-12 17:24 ` David Miller

Netdev Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/netdev/0 netdev/git/0.git
	git clone --mirror https://lore.kernel.org/netdev/1 netdev/git/1.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 netdev netdev/ https://lore.kernel.org/netdev \
		netdev@vger.kernel.org netdev@archiver.kernel.org
	public-inbox-index netdev


Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.netdev


AGPL code for this site: git clone https://public-inbox.org/ public-inbox