* [PATCH net] vhost: correctly check the return value of translate_desc() in log_used()
@ 2019-02-15 7:53 Jason Wang
2019-02-15 16:45 ` Stephen Hemminger
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Jason Wang @ 2019-02-15 7:53 UTC (permalink / raw)
To: mst, jasowang; +Cc: kvm, virtualization, netdev, linux-kernel, stephen
When fail, translate_desc() returns negative value, otherwise the
number of iovs. So we should fail when the return value is negative
instead of a blindly check against zero.
Reported-by: Stephen Hemminger <stephen@networkplumber.org>
Fixes: cc5e71075947 ("vhost: log dirty page correctly")
Signed-off-by: Jason Wang <jasowang@redhat.com>
---
drivers/vhost/vhost.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/vhost/vhost.c b/drivers/vhost/vhost.c
index 24a129fcdd61..a2e5dc7716e2 100644
--- a/drivers/vhost/vhost.c
+++ b/drivers/vhost/vhost.c
@@ -1788,7 +1788,7 @@ static int log_used(struct vhost_virtqueue *vq, u64 used_offset, u64 len)
ret = translate_desc(vq, (uintptr_t)vq->used + used_offset,
len, iov, 64, VHOST_ACCESS_WO);
- if (ret)
+ if (ret < 0)
return ret;
for (i = 0; i < ret; i++) {
--
2.17.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH net] vhost: correctly check the return value of translate_desc() in log_used()
2019-02-15 7:53 [PATCH net] vhost: correctly check the return value of translate_desc() in log_used() Jason Wang
@ 2019-02-15 16:45 ` Stephen Hemminger
2019-02-19 6:51 ` Jason Wang
2019-02-15 18:03 ` David Miller
2019-02-15 21:59 ` Michael S. Tsirkin
2 siblings, 1 reply; 6+ messages in thread
From: Stephen Hemminger @ 2019-02-15 16:45 UTC (permalink / raw)
To: Jason Wang; +Cc: mst, kvm, virtualization, netdev, linux-kernel
On Fri, 15 Feb 2019 15:53:24 +0800
Jason Wang <jasowang@redhat.com> wrote:
> When fail, translate_desc() returns negative value, otherwise the
> number of iovs. So we should fail when the return value is negative
> instead of a blindly check against zero.
>
> Reported-by: Stephen Hemminger <stephen@networkplumber.org>
> Fixes: cc5e71075947 ("vhost: log dirty page correctly")
> Signed-off-by: Jason Wang <jasowang@redhat.com>
Looks good. It is best to put the Addresses-Coverity-Id tag on these kind
of bug fixes so that the automated tools see it.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH net] vhost: correctly check the return value of translate_desc() in log_used()
2019-02-15 7:53 [PATCH net] vhost: correctly check the return value of translate_desc() in log_used() Jason Wang
2019-02-15 16:45 ` Stephen Hemminger
@ 2019-02-15 18:03 ` David Miller
2019-02-19 6:50 ` Jason Wang
2019-02-15 21:59 ` Michael S. Tsirkin
2 siblings, 1 reply; 6+ messages in thread
From: David Miller @ 2019-02-15 18:03 UTC (permalink / raw)
To: jasowang; +Cc: mst, kvm, virtualization, netdev, linux-kernel, stephen
From: Jason Wang <jasowang@redhat.com>
Date: Fri, 15 Feb 2019 15:53:24 +0800
> When fail, translate_desc() returns negative value, otherwise the
> number of iovs. So we should fail when the return value is negative
> instead of a blindly check against zero.
>
> Reported-by: Stephen Hemminger <stephen@networkplumber.org>
> Fixes: cc5e71075947 ("vhost: log dirty page correctly")
> Signed-off-by: Jason Wang <jasowang@redhat.com>
Jason, please put the Fixes tag first.
Thank you.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH net] vhost: correctly check the return value of translate_desc() in log_used()
2019-02-15 7:53 [PATCH net] vhost: correctly check the return value of translate_desc() in log_used() Jason Wang
2019-02-15 16:45 ` Stephen Hemminger
2019-02-15 18:03 ` David Miller
@ 2019-02-15 21:59 ` Michael S. Tsirkin
2 siblings, 0 replies; 6+ messages in thread
From: Michael S. Tsirkin @ 2019-02-15 21:59 UTC (permalink / raw)
To: Jason Wang; +Cc: kvm, virtualization, netdev, linux-kernel, stephen
On Fri, Feb 15, 2019 at 03:53:24PM +0800, Jason Wang wrote:
> When fail, translate_desc() returns negative value, otherwise the
> number of iovs. So we should fail when the return value is negative
> instead of a blindly check against zero.
>
> Reported-by: Stephen Hemminger <stephen@networkplumber.org>
> Fixes: cc5e71075947 ("vhost: log dirty page correctly")
> Signed-off-by: Jason Wang <jasowang@redhat.com>
Acked-by: Michael S. Tsirkin <mst@redhat.com>
and I guess the log was backported to stable so we want
this backported too.
> ---
> drivers/vhost/vhost.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/vhost/vhost.c b/drivers/vhost/vhost.c
> index 24a129fcdd61..a2e5dc7716e2 100644
> --- a/drivers/vhost/vhost.c
> +++ b/drivers/vhost/vhost.c
> @@ -1788,7 +1788,7 @@ static int log_used(struct vhost_virtqueue *vq, u64 used_offset, u64 len)
>
> ret = translate_desc(vq, (uintptr_t)vq->used + used_offset,
> len, iov, 64, VHOST_ACCESS_WO);
> - if (ret)
> + if (ret < 0)
> return ret;
>
> for (i = 0; i < ret; i++) {
> --
> 2.17.1
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH net] vhost: correctly check the return value of translate_desc() in log_used()
2019-02-15 18:03 ` David Miller
@ 2019-02-19 6:50 ` Jason Wang
0 siblings, 0 replies; 6+ messages in thread
From: Jason Wang @ 2019-02-19 6:50 UTC (permalink / raw)
To: David Miller; +Cc: mst, kvm, virtualization, netdev, linux-kernel, stephen
On 2019/2/16 上午2:03, David Miller wrote:
> From: Jason Wang<jasowang@redhat.com>
> Date: Fri, 15 Feb 2019 15:53:24 +0800
>
>> When fail, translate_desc() returns negative value, otherwise the
>> number of iovs. So we should fail when the return value is negative
>> instead of a blindly check against zero.
>>
>> Reported-by: Stephen Hemminger<stephen@networkplumber.org>
>> Fixes: cc5e71075947 ("vhost: log dirty page correctly")
>> Signed-off-by: Jason Wang<jasowang@redhat.com>
> Jason, please put the Fixes tag first.
>
> Thank you.
Ok. Will post V2.
Thanks
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH net] vhost: correctly check the return value of translate_desc() in log_used()
2019-02-15 16:45 ` Stephen Hemminger
@ 2019-02-19 6:51 ` Jason Wang
0 siblings, 0 replies; 6+ messages in thread
From: Jason Wang @ 2019-02-19 6:51 UTC (permalink / raw)
To: Stephen Hemminger; +Cc: mst, kvm, virtualization, netdev, linux-kernel
On 2019/2/16 上午12:45, Stephen Hemminger wrote:
> On Fri, 15 Feb 2019 15:53:24 +0800
> Jason Wang <jasowang@redhat.com> wrote:
>
>> When fail, translate_desc() returns negative value, otherwise the
>> number of iovs. So we should fail when the return value is negative
>> instead of a blindly check against zero.
>>
>> Reported-by: Stephen Hemminger <stephen@networkplumber.org>
>> Fixes: cc5e71075947 ("vhost: log dirty page correctly")
>> Signed-off-by: Jason Wang <jasowang@redhat.com>
> Looks good. It is best to put the Addresses-Coverity-Id tag on these kind
> of bug fixes so that the automated tools see it.
Ok. Will do this in V2.
Thanks
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2019-02-19 6:51 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-02-15 7:53 [PATCH net] vhost: correctly check the return value of translate_desc() in log_used() Jason Wang
2019-02-15 16:45 ` Stephen Hemminger
2019-02-19 6:51 ` Jason Wang
2019-02-15 18:03 ` David Miller
2019-02-19 6:50 ` Jason Wang
2019-02-15 21:59 ` Michael S. Tsirkin
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).