* [PATCH net-next] igc: Make function igc_write_rss_indir_tbl() static
@ 2019-02-16 2:04 Wei Yongjun
2019-02-17 10:06 ` Neftin, Sasha
0 siblings, 1 reply; 3+ messages in thread
From: Wei Yongjun @ 2019-02-16 2:04 UTC (permalink / raw)
To: Jeff Kirsher, Sasha Neftin
Cc: Wei Yongjun, intel-wired-lan, netdev, kernel-janitors
Fixes the following sparse warning:
drivers/net/ethernet/intel/igc/igc_ethtool.c:646:6: warning:
symbol 'igc_write_rss_indir_tbl' was not declared. Should it be static?
Fixes: 8c5ad0dae93c ("igc: Add ethtool support")
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
---
drivers/net/ethernet/intel/igc/igc_ethtool.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/intel/igc/igc_ethtool.c b/drivers/net/ethernet/intel/igc/igc_ethtool.c
index eff37a6c0afa..544239422577 100644
--- a/drivers/net/ethernet/intel/igc/igc_ethtool.c
+++ b/drivers/net/ethernet/intel/igc/igc_ethtool.c
@@ -643,7 +643,7 @@ static int igc_set_coalesce(struct net_device *netdev,
return 0;
}
-void igc_write_rss_indir_tbl(struct igc_adapter *adapter)
+static void igc_write_rss_indir_tbl(struct igc_adapter *adapter)
{
struct igc_hw *hw = &adapter->hw;
u32 reg = IGC_RETA(0);
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH net-next] igc: Make function igc_write_rss_indir_tbl() static
2019-02-16 2:04 [PATCH net-next] igc: Make function igc_write_rss_indir_tbl() static Wei Yongjun
@ 2019-02-17 10:06 ` Neftin, Sasha
2019-02-17 10:59 ` [Intel-wired-lan] " Neftin, Sasha
0 siblings, 1 reply; 3+ messages in thread
From: Neftin, Sasha @ 2019-02-17 10:06 UTC (permalink / raw)
To: Wei Yongjun, Jeff Kirsher; +Cc: intel-wired-lan, netdev, kernel-janitors
On 2/16/2019 04:04, Wei Yongjun wrote:
> Fixes the following sparse warning:
>
> drivers/net/ethernet/intel/igc/igc_ethtool.c:646:6: warning:
> symbol 'igc_write_rss_indir_tbl' was not declared. Should it be static?
>
> Fixes: 8c5ad0dae93c ("igc: Add ethtool support")
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
> ---
> drivers/net/ethernet/intel/igc/igc_ethtool.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/intel/igc/igc_ethtool.c b/drivers/net/ethernet/intel/igc/igc_ethtool.c
> index eff37a6c0afa..544239422577 100644
> --- a/drivers/net/ethernet/intel/igc/igc_ethtool.c
> +++ b/drivers/net/ethernet/intel/igc/igc_ethtool.c
> @@ -643,7 +643,7 @@ static int igc_set_coalesce(struct net_device *netdev,
> return 0;
> }
>
> -void igc_write_rss_indir_tbl(struct igc_adapter *adapter)
> +static void igc_write_rss_indir_tbl(struct igc_adapter *adapter)
> {
> struct igc_hw *hw = &adapter->hw;
> u32 reg = IGC_RETA(0);
>
>
> NACK
'igc_write_rss_indir_tbl' method declared in igc.h file. This method
used in both igc_ethtool.c and igc_main.c and can't be a 'static'
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Intel-wired-lan] [PATCH net-next] igc: Make function igc_write_rss_indir_tbl() static
2019-02-17 10:06 ` Neftin, Sasha
@ 2019-02-17 10:59 ` Neftin, Sasha
0 siblings, 0 replies; 3+ messages in thread
From: Neftin, Sasha @ 2019-02-17 10:59 UTC (permalink / raw)
To: Wei Yongjun, Jeff Kirsher; +Cc: netdev, kernel-janitors, intel-wired-lan
On 2/17/2019 12:06, Neftin, Sasha wrote:
> On 2/16/2019 04:04, Wei Yongjun wrote:
>> Fixes the following sparse warning:
>>
>> drivers/net/ethernet/intel/igc/igc_ethtool.c:646:6: warning:
>> symbol 'igc_write_rss_indir_tbl' was not declared. Should it be static?
>>
>> Fixes: 8c5ad0dae93c ("igc: Add ethtool support")
>> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
>> ---
>> drivers/net/ethernet/intel/igc/igc_ethtool.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/net/ethernet/intel/igc/igc_ethtool.c
>> b/drivers/net/ethernet/intel/igc/igc_ethtool.c
>> index eff37a6c0afa..544239422577 100644
>> --- a/drivers/net/ethernet/intel/igc/igc_ethtool.c
>> +++ b/drivers/net/ethernet/intel/igc/igc_ethtool.c
>> @@ -643,7 +643,7 @@ static int igc_set_coalesce(struct net_device
>> *netdev,
>> return 0;
>> }
>> -void igc_write_rss_indir_tbl(struct igc_adapter *adapter)
>> +static void igc_write_rss_indir_tbl(struct igc_adapter *adapter)
>> {
>> struct igc_hw *hw = &adapter->hw;
>> u32 reg = IGC_RETA(0);
>>
>>
>> NACK
> 'igc_write_rss_indir_tbl' method declared in igc.h file. This method
> used in both igc_ethtool.c and igc_main.c and can't be a 'static'
> __
please, refer to commit 429abdf0cd3c... (Add multiple receive queues
control supporting)
_____________________________________________
> Intel-wired-lan mailing list
> Intel-wired-lan@osuosl.org
> https://lists.osuosl.org/mailman/listinfo/intel-wired-lan
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-02-17 10:59 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-02-16 2:04 [PATCH net-next] igc: Make function igc_write_rss_indir_tbl() static Wei Yongjun
2019-02-17 10:06 ` Neftin, Sasha
2019-02-17 10:59 ` [Intel-wired-lan] " Neftin, Sasha
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).