From: Alexei Starovoitov <alexei.starovoitov@gmail.com>
To: David Ahern <dsahern@gmail.com>
Cc: Peter Oskolkov <posk@google.com>,
Alexei Starovoitov <ast@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>,
netdev@vger.kernel.org, Peter Oskolkov <posk@posk.io>
Subject: Re: [PATCH bpf-next] selftests: bpf: test_lwt_ip_encap: add negative tests.
Date: Sat, 16 Feb 2019 18:46:18 -0800 [thread overview]
Message-ID: <20190217024616.kisygfnlqsrtlh7m@ast-mbp.dhcp.thefacebook.com> (raw)
In-Reply-To: <b8a76f3d-93e8-1287-05e0-a671a3991cbe@gmail.com>
On Sat, Feb 16, 2019 at 04:13:12PM -0700, David Ahern wrote:
> On 2/15/19 4:49 PM, Peter Oskolkov wrote:
> > @@ -178,7 +205,7 @@ set -e # exit on error
> > # configure IPv4 GRE device in NS3, and a route to it via the "bottom" route
> > ip -netns ${NS3} tunnel add gre_dev mode gre remote ${IPv4_1} local ${IPv4_GRE} ttl 255
> > ip -netns ${NS3} link set gre_dev up
> > - ip -netns ${NS3} addr add ${IPv4_GRE} dev gre_dev
> > + ip -netns ${NS3} addr add ${IPv4_GRE} nodad dev gre_dev
>
> nodad is only effective for IPv6.
>
> other than that LGTM. Thanks for the update.
>
> Reviewed-by: David Ahern <dsahern@gmail.com>
Applied as-is.
Pls send a follow up if you feel strongly about it.
Thanks
prev parent reply other threads:[~2019-02-17 2:46 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-15 23:49 [PATCH bpf-next] selftests: bpf: test_lwt_ip_encap: add negative tests Peter Oskolkov
2019-02-16 23:13 ` David Ahern
2019-02-17 2:46 ` Alexei Starovoitov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190217024616.kisygfnlqsrtlh7m@ast-mbp.dhcp.thefacebook.com \
--to=alexei.starovoitov@gmail.com \
--cc=ast@kernel.org \
--cc=daniel@iogearbox.net \
--cc=dsahern@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=posk@google.com \
--cc=posk@posk.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).